From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9313581E6E for ; Wed, 16 Nov 2016 08:36:43 -0800 (PST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP; 16 Nov 2016 08:36:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,500,1473145200"; d="scan'208";a="5113944" Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by orsmga002.jf.intel.com with ESMTP; 16 Nov 2016 08:36:29 -0800 Received: from orsmsx116.amr.corp.intel.com (10.22.240.14) by ORSMSX108.amr.corp.intel.com (10.22.240.6) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 16 Nov 2016 08:36:28 -0800 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.63]) by ORSMSX116.amr.corp.intel.com ([10.22.240.14]) with mapi id 14.03.0248.002; Wed, 16 Nov 2016 08:36:28 -0800 From: "Kinney, Michael D" To: "Gao, Liming" , "edk2-devel@lists.01.org" , "Kinney, Michael D" Thread-Topic: [edk2] [PATCH v2] BaseTools gitignore: Ignore VS intermediate files *.obj and *.pdb Thread-Index: AQHSPyy4kYNdNKIk2Uej/n9+4EE0jqDaOnewgAEeboCAAHd6IA== Date: Wed, 16 Nov 2016 16:36:28 +0000 Message-ID: References: <1479191390-30812-1-git-send-email-liming.gao@intel.com> <1479206377-35532-1-git-send-email-liming.gao@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14B4B3811@shsmsx102.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14B4B3811@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjEyZTQ5ZmMtZmM1MS00NGQwLTk2YTYtYjYwNGRlMmIzMzU1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkNCVm1EQk9NZUo3emdoSGRqaXZWTlZ5YjExcVp5d1BwenRoQlRjK1lhTDQ9In0= x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Subject: Re: [PATCH v2] BaseTools gitignore: Ignore VS intermediate files *.obj and *.pdb X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Nov 2016 16:36:43 -0000 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Liming, I agree. The current patch is good. Reviewed-by: Michael Kinney Mike From: Gao, Liming=20 Sent: Tuesday, November 15, 2016 5:27 PM To: Kinney, Michael D ; edk2-devel@lists.01.org Subject: RE: [edk2] [PATCH v2] BaseTools gitignore: Ignore VS intermediate = files *.obj and *.pdb Mike: =A0 We don't need to add C tools .exe in edk2 git repo. All C tools .exe ar= e in another git repo edk2-BaseTools-win32. And, Bin/Win32 directory is alr= eady in .gitignore. All exe files in Bin directory have been ignored.=20 Thanks Liming From: Kinney, Michael D=20 Sent: Wednesday, November 16, 2016 12:25 AM To: Gao, Liming ; edk2-devel@lists.01.org; Kinney, Mi= chael D Subject: RE: [edk2] [PATCH v2] BaseTools gitignore: Ignore VS intermediate = files *.obj and *.pdb Liming, The current patch would ignore .exe in BaseTools/Bin Since you had to add .exe, should this be done in .gitignore in BaseTools/Source instead? Thanks, Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Li= ming Gao > Sent: Tuesday, November 15, 2016 2:40 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH v2] BaseTools gitignore: Ignore VS intermediate fi= les > *.obj and *.pdb >=20 > In V2, ignore .exe and .ilk files >=20 > Cc: Yonghong Zhu=20 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Liming Gao=20 > --- > BaseTools/.gitignore | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/BaseTools/.gitignore b/BaseTools/.gitignore > index 5ca024c..a45689b 100644 > --- a/BaseTools/.gitignore > +++ b/BaseTools/.gitignore > @@ -1,5 +1,9 @@ > *.d > *.o > +*.obj > +*.pdb > +*.ilk > +*.exe > *.pyc > Source/C/VfrCompile/EfiVfrParser.cpp > Source/C/VfrCompile/EfiVfrParser.h > -- > 2.8.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel