From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 59FFF81E06 for ; Tue, 29 Nov 2016 18:16:09 -0800 (PST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP; 29 Nov 2016 18:16:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,719,1473145200"; d="scan'208";a="1092370138" Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132]) by fmsmga002.fm.intel.com with ESMTP; 29 Nov 2016 18:16:08 -0800 Received: from orsmsx162.amr.corp.intel.com (10.22.240.85) by ORSMSX105.amr.corp.intel.com (10.22.225.132) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 29 Nov 2016 18:16:08 -0800 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.63]) by ORSMSX162.amr.corp.intel.com ([10.22.240.85]) with mapi id 14.03.0248.002; Tue, 29 Nov 2016 18:15:58 -0800 From: "Kinney, Michael D" To: "Yao, Jiewen" , "edk2-devel@lists.01.org" , "Kinney, Michael D" CC: "Wei, David" , "Guo, Mang" Thread-Topic: [Patch] Vlv2TbltDevicePkg: Use 4K aligned PE/COFF sections Thread-Index: AQHSSqu/riT0HebY+kus55zIY1R6R6Dwyc3A Date: Wed, 30 Nov 2016 02:15:58 +0000 Message-ID: References: <1480447327-13908-1-git-send-email-michael.d.kinney@intel.com> <74D8A39837DF1E4DA445A8C0B3885C50386DC7B2@shsmsx102.ccr.corp.intel.com> In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C50386DC7B2@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTQ0ZTc0ZGUtYmVmZS00ODhiLThkMzAtNTNkMmZjN2RhOTcxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjRjY3NSbWFrUEUrTkhFdGo1WFpuWjh2Q3B6UnFtS2FMY3dieUgwQVBNT2s9In0= x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Subject: Re: [Patch] Vlv2TbltDevicePkg: Use 4K aligned PE/COFF sections X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Nov 2016 02:16:09 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Jiewen, I agree. I have entered an additional Bugzilla issue to get the binaries f= ixed. https://bugzilla.tianocore.org/show_bug.cgi?id=3D268 Best regards, Mike > -----Original Message----- > From: Yao, Jiewen > Sent: Tuesday, November 29, 2016 5:48 PM > To: Kinney, Michael D ; edk2-devel@lists.01.o= rg > Cc: Wei, David ; Guo, Mang > Subject: RE: [Patch] Vlv2TbltDevicePkg: Use 4K aligned PE/COFF sections >=20 > HI Mike > I agree on this change. > But I would like to mention that the protection does not takes effect, un= til all > VLV2 binary uses this build option, too. >=20 > We should feedback to VLV2 binary provider as well. >=20 > Reviewed-by: Jiewen.yao@intel.com >=20 > Thank you > Yao Jiewen >=20 > > -----Original Message----- > > From: Kinney, Michael D > > Sent: Wednesday, November 30, 2016 3:22 AM > > To: edk2-devel@lists.01.org > > Cc: Yao, Jiewen ; Wei, David > > ; Guo, Mang > > Subject: [Patch] Vlv2TbltDevicePkg: Use 4K aligned PE/COFF sections > > > > Update [BuildOptions] to use of 4K aligned PE/COFF > > image sections to support page level protection of > > DXE_RUNTIME_DRIVER, SMM_CORE, and DXE_SMM_DRIVER > > modules. > > > > Cc: Jiewen Yao > > Cc: David Wei > > Cc: Mang Guo > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Michael Kinney > > --- > > Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 16 ++++++++++++++++ > > Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 16 ++++++++++++++++ > > Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 16 ++++++++++++++++ > > 3 files changed, 48 insertions(+) > > > > diff --git a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > > b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > > index c3dc25f..6da2a8a 100644 > > --- a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > > +++ b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > > @@ -1676,6 +1676,22 @@ > > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fT > > PMInitPeim.inf > > INTEL:*_*_X64_GENFW_FLAGS =3D --keepexceptiontable > > !endif > > > > +# > > +# Force PE/COFF sections to be aligned at 4KB boundaries to support pa= ge > > level > > +# protection of DXE_RUNTIME_DRIVER modules > > +# > > +[BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER] > > + MSFT:*_*_*_DLINK_FLAGS =3D /ALIGN:4096 > > + GCC:*_*_*_DLINK_FLAGS =3D -z common-page-size=3D0x1000 > > + > > +# > > +# Force PE/COFF sections to be aligned at 4KB boundaries to support pa= ge > > level > > +# protection of DXE_SMM_DRIVER/SMM_CORE modules > > +# > > +[BuildOptions.common.EDKII.DXE_SMM_DRIVER, > > BuildOptions.common.EDKII.SMM_CORE] > > + MSFT:*_*_*_DLINK_FLAGS =3D /ALIGN:4096 > > + GCC:*_*_*_DLINK_FLAGS =3D -z common-page-size=3D0x1000 > > + > > [BuildOptions.Common.EDK] > > > > # > > diff --git a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > > b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > > index 3a5776a..5b5523f 100644 > > --- a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > > +++ b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > > @@ -1659,6 +1659,22 @@ > > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fT > > PMInitPeim.inf > > > > !endif > > > > +# > > +# Force PE/COFF sections to be aligned at 4KB boundaries to support pa= ge > > level > > +# protection of DXE_RUNTIME_DRIVER modules > > +# > > +[BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER] > > + MSFT:*_*_*_DLINK_FLAGS =3D /ALIGN:4096 > > + GCC:*_*_*_DLINK_FLAGS =3D -z common-page-size=3D0x1000 > > + > > +# > > +# Force PE/COFF sections to be aligned at 4KB boundaries to support pa= ge > > level > > +# protection of DXE_SMM_DRIVER/SMM_CORE modules > > +# > > +[BuildOptions.common.EDKII.DXE_SMM_DRIVER, > > BuildOptions.common.EDKII.SMM_CORE] > > + MSFT:*_*_*_DLINK_FLAGS =3D /ALIGN:4096 > > + GCC:*_*_*_DLINK_FLAGS =3D -z common-page-size=3D0x1000 > > + > > [BuildOptions.Common.EDK] > > > > # > > diff --git a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > > b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > > index 83cbb0a..54d2b81 100644 > > --- a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > > +++ b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > > @@ -1668,6 +1668,22 @@ > > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fT > > PMInitPeim.inf > > > > !endif > > > > +# > > +# Force PE/COFF sections to be aligned at 4KB boundaries to support pa= ge > > level > > +# protection of DXE_RUNTIME_DRIVER modules > > +# > > +[BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER] > > + MSFT:*_*_*_DLINK_FLAGS =3D /ALIGN:4096 > > + GCC:*_*_*_DLINK_FLAGS =3D -z common-page-size=3D0x1000 > > + > > +# > > +# Force PE/COFF sections to be aligned at 4KB boundaries to support pa= ge > > level > > +# protection of DXE_SMM_DRIVER/SMM_CORE modules > > +# > > +[BuildOptions.common.EDKII.DXE_SMM_DRIVER, > > BuildOptions.common.EDKII.SMM_CORE] > > + MSFT:*_*_*_DLINK_FLAGS =3D /ALIGN:4096 > > + GCC:*_*_*_DLINK_FLAGS =3D -z common-page-size=3D0x1000 > > + > > [BuildOptions.Common.EDK] > > > > # > > -- > > 2.6.3.windows.1