public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Kinney, Michael D" <michael.d.kinney@intel.com>
To: "Bi, Dandan" <dandan.bi@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "Fan, Jeff" <jeff.fan@intel.com>
Subject: Re: [patch 2/2] UefiCpuPkg/SmmCpuFeaturesLib: Fix coding style issues
Date: Tue, 20 Dec 2016 16:59:19 +0000	[thread overview]
Message-ID: <E92EE9817A31E24EB0585FDF735412F56487E2A6@ORSMSX113.amr.corp.intel.com> (raw)
In-Reply-To: <1482220390-11616-2-git-send-email-dandan.bi@intel.com>

Reviewed-by: Michael Kinney <michael.d.kinney@intel.com>

> -----Original Message-----
> From: Bi, Dandan
> Sent: Monday, December 19, 2016 11:53 PM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Fan, Jeff
> <jeff.fan@intel.com>
> Subject: [patch 2/2] UefiCpuPkg/SmmCpuFeaturesLib: Fix coding style issues
> 
> Cc: Michael Kinney <michael.d.kinney@intel.com>
> Cc: Jeff Fan <jeff.fan@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
>  UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c      | 2 +-
>  UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLibNoStm.c | 2 +-
>  UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c                 | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c
> b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c
> index 31d73cd..079baa4 100644
> --- a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c
> +++ b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c
> @@ -41,11 +41,11 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER
> EXPRESS OR IMPLIED.
>  #define SMM_FEATURES_LIB_IA32_MCA_CAP              0x17D
>  #define   SMM_CODE_ACCESS_CHK_BIT                  BIT58
> 
>  /**
>    Internal worker function that is called to complete CPU initialization at the
> -  end of SmmCpuFeaturesInitializeProcessor()
> +  end of SmmCpuFeaturesInitializeProcessor().
> 
>  **/
>  VOID
>  FinishSmmCpuFeaturesInitializeProcessor (
>    VOID
> diff --git a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLibNoStm.c
> b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLibNoStm.c
> index e872eec..5276856 100644
> --- a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLibNoStm.c
> +++ b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLibNoStm.c
> @@ -16,11 +16,11 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER
> EXPRESS OR IMPLIED.
>  #include <PiSmm.h>
>  #include <Library/SmmCpuFeaturesLib.h>
> 
>  /**
>    Internal worker function that is called to complete CPU initialization at the
> -  end of SmmCpuFeaturesInitializeProcessor()
> +  end of SmmCpuFeaturesInitializeProcessor().
> 
>  **/
>  VOID
>  FinishSmmCpuFeaturesInitializeProcessor (
>    VOID
> diff --git a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c
> b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c
> index 59c49e3..bb123ba 100644
> --- a/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c
> +++ b/UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmStm.c
> @@ -188,11 +188,11 @@ SmmCpuFeaturesLibStmConstructor (
>    return EFI_SUCCESS;
>  }
> 
>  /**
>    Internal worker function that is called to complete CPU initialization at the
> -  end of SmmCpuFeaturesInitializeProcessor()
> +  end of SmmCpuFeaturesInitializeProcessor().
> 
>  **/
>  VOID
>  FinishSmmCpuFeaturesInitializeProcessor (
>    VOID
> --
> 1.9.5.msysgit.1



  reply	other threads:[~2016-12-20 16:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-20  7:53 [patch 1/2] UefiCpuPkg: Add Pcd info to uni file Dandan Bi
2016-12-20  7:53 ` [patch 2/2] UefiCpuPkg/SmmCpuFeaturesLib: Fix coding style issues Dandan Bi
2016-12-20 16:59   ` Kinney, Michael D [this message]
2016-12-20 16:59 ` [patch 1/2] UefiCpuPkg: Add Pcd info to uni file Kinney, Michael D

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E92EE9817A31E24EB0585FDF735412F56487E2A6@ORSMSX113.amr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox