From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E99678038D for ; Wed, 22 Mar 2017 08:39:31 -0700 (PDT) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP; 22 Mar 2017 08:39:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,205,1486454400"; d="scan'208";a="1111103139" Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132]) by orsmga001.jf.intel.com with ESMTP; 22 Mar 2017 08:39:31 -0700 Received: from orsmsx161.amr.corp.intel.com (10.22.240.84) by ORSMSX105.amr.corp.intel.com (10.22.225.132) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 22 Mar 2017 08:39:31 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.211]) by ORSMSX161.amr.corp.intel.com ([169.254.4.174]) with mapi id 14.03.0319.002; Wed, 22 Mar 2017 08:39:31 -0700 From: "Kinney, Michael D" To: "Carsey, Jaben" , Ard Biesheuvel , "Kinney, Michael D" CC: "Ni, Ruiyu" , "edk2-devel@lists.01.org" , "leif.lindholm@linaro.org" , "lersek@redhat.com" Thread-Topic: [edk2] [PATCH 1/4] ShellPkg: add GUID declaration for FILE_GUID of UEFI Shell app to package Thread-Index: AQHSoxU8AhFzK3haZUKkoAJ6FAba9KGhbOEAgAAB1QCAAABbAP//jwSA Date: Wed, 22 Mar 2017 15:39:31 +0000 Message-ID: References: <1490191448-22398-1-git-send-email-ard.biesheuvel@linaro.org> <1490191448-22398-2-git-send-email-ard.biesheuvel@linaro.org> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDhjM2VlYTctZTM0OC00YTIyLWJkZjctZTk5N2VlZDEzZGZiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Im9TTnBRWTcxU1MzM1wvcEtEeFlQU0JUd294c1E1NFd5XC8xdXRhWjdjU2ExZz0ifQ== x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Subject: Re: [PATCH 1/4] ShellPkg: add GUID declaration for FILE_GUID of UEFI Shell app to package X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Mar 2017 15:39:32 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Jaben, I like the added comment. Maybe we should consider an INF spec enhancement to support a GUID C Name=20 for the FILE_GUID define, and the GUID C Names can be any GUID declared in a dependent packages from the [Packages] section of the INF. This would eliminate the GUID value duplication for this use case. Mike > -----Original Message----- > From: Carsey, Jaben > Sent: Wednesday, March 22, 2017 8:21 AM > To: Ard Biesheuvel > Cc: Ni, Ruiyu ; edk2-devel@lists.01.org; leif.lindhol= m@linaro.org; > Kinney, Michael D ; lersek@redhat.com; Carsey= , Jaben > > Subject: RE: [edk2] [PATCH 1/4] ShellPkg: add GUID declaration for FILE_G= UID of UEFI > Shell app to package >=20 > Yes. that looks great. >=20 > For the changes to ShellPkg. > Reviewed-by: Jaben Carsey >=20 > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > > Ard Biesheuvel > > Sent: Wednesday, March 22, 2017 8:20 AM > > To: Carsey, Jaben > > Cc: Ni, Ruiyu ; edk2-devel@lists.01.org; > > leif.lindholm@linaro.org; Kinney, Michael D ; > > lersek@redhat.com > > Subject: Re: [edk2] [PATCH 1/4] ShellPkg: add GUID declaration for > > FILE_GUID of UEFI Shell app to package > > Importance: High > > > > On 22 March 2017 at 15:13, Carsey, Jaben wrote= : > > > Ard, > > > > > > I am good with this change. > > > > > > What do you think about a comment to the INF file so that if someone > > makes a change to the GUI there, they are informed that they need to > > change this location? I worry as usually updating an INF GUID is permi= tted > > without any need to change another file... > > > > > > > Something like this perhaps? > > > > --- a/ShellPkg/Application/Shell/Shell.inf > > +++ b/ShellPkg/Application/Shell/Shell.inf > > @@ -17,7 +17,7 @@ > > [Defines] > > INF_VERSION =3D 0x00010006 > > BASE_NAME =3D Shell > > - FILE_GUID =3D 7C04A583-9E3E-4f1c-AD65-E05268D0B4D1 > > + FILE_GUID =3D 7C04A583-9E3E-4f1c-AD65-E05268D0B4D1 # > > gUefiShellFileGuid > > MODULE_TYPE =3D UEFI_APPLICATION > > VERSION_STRING =3D 1.0 > > ENTRY_POINT =3D UefiMain > > > > (Note that the same FILE_GUID occurs in ShellBinPkg as well, but > > people are unlikely that randomly change that one without regard to > > the source build) > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel