From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6DA9980294 for ; Wed, 22 Mar 2017 08:43:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490197393; x=1521733393; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=qdSc0+mnGNmWi3iNokhrnz1WmCEm4CAEwYEuFTWjUes=; b=Hqs+kVnaEuXLTSCmjZV9W/higivky+u1Pkg4DquUEZK++CmVnsJo/mUT Ekcc+J5x1nZWNGzBj3noci/n7PhSIA==; Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Mar 2017 08:43:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,206,1486454400"; d="scan'208";a="69723465" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by orsmga004.jf.intel.com with ESMTP; 22 Mar 2017 08:43:13 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.211]) by ORSMSX104.amr.corp.intel.com ([169.254.4.72]) with mapi id 14.03.0319.002; Wed, 22 Mar 2017 08:43:12 -0700 From: "Kinney, Michael D" To: Ard Biesheuvel , "edk2-devel@lists.01.org" , "leif.lindholm@linaro.org" , "lersek@redhat.com" , "Carsey, Jaben" , "Ni, Ruiyu" , "Steele, Kelly" , "Kinney, Michael D" Thread-Topic: [PATCH 2/4] QuarkPlatformPkg/PlatformBootManagerLib: use new UefiShellFileGuid definition Thread-Index: AQHSoxU/OfwzwWYJyUeybo24rH4NN6Gg/2iQ Date: Wed, 22 Mar 2017 15:43:11 +0000 Message-ID: References: <1490191448-22398-1-git-send-email-ard.biesheuvel@linaro.org> <1490191448-22398-3-git-send-email-ard.biesheuvel@linaro.org> In-Reply-To: <1490191448-22398-3-git-send-email-ard.biesheuvel@linaro.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzg5NTU0MDUtMmNkNS00ZjRhLWFlOTItMTUwMWVhYzY0MGYwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Im5BWmdkQ1FGRHYxSm90WXZxOWtrWXRRb2FpYWJpK2VGaDVFSkJvSXozM289In0= x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Subject: Re: [PATCH 2/4] QuarkPlatformPkg/PlatformBootManagerLib: use new UefiShellFileGuid definition X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Mar 2017 15:43:13 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Michael Kinney Mike > -----Original Message----- > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > Sent: Wednesday, March 22, 2017 7:04 AM > To: edk2-devel@lists.01.org; leif.lindholm@linaro.org; lersek@redhat.com;= Carsey, > Jaben ; Ni, Ruiyu ; Kinney, M= ichael D > ; Steele, Kelly > Cc: Ard Biesheuvel > Subject: [PATCH 2/4] QuarkPlatformPkg/PlatformBootManagerLib: use new > UefiShellFileGuid definition >=20 > Move to the new definition of UefiShellFileGuid, which is defined in the > ShellPkg package declaration file rather than hardcoded in this module. >=20 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > --- > QuarkPlatformPkg/Library/PlatformBootManagerLib/PlatformBootManager.c = | 4 +--- > QuarkPlatformPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.i= nf | 2 ++ > 2 files changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/QuarkPlatformPkg/Library/PlatformBootManagerLib/PlatformBoot= Manager.c > b/QuarkPlatformPkg/Library/PlatformBootManagerLib/PlatformBootManager.c > index b61eb03360a2..3c213180690d 100644 > --- a/QuarkPlatformPkg/Library/PlatformBootManagerLib/PlatformBootManager= .c > +++ b/QuarkPlatformPkg/Library/PlatformBootManagerLib/PlatformBootManager= .c > @@ -15,8 +15,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITH= ER EXPRESS OR > IMPLIED. >=20 > #include "PlatformBootManager.h" >=20 > -EFI_GUID mUefiShellFileGuid =3D {0x7C04A583, 0x9E3E, 0x4f1c, {0xAD, 0x65= , 0xE0, 0x52, > 0x68, 0xD0, 0xB4, 0xD1 }}; > - > /** > Return the index of the load option in the load option array. >=20 > @@ -246,7 +244,7 @@ PlatformBootManagerBeforeConsole ( > // > // Register UEFI Shell > // > - PlatformRegisterFvBootOption (&mUefiShellFileGuid, L"UEFI Shell", > LOAD_OPTION_ACTIVE); > + PlatformRegisterFvBootOption (&gUefiShellFileGuid, L"UEFI Shell", > LOAD_OPTION_ACTIVE); >=20 > Status =3D gBS->LocateProtocol(&gEsrtManagementProtocolGuid, NULL, (VO= ID > **)&EsrtManagement); > if (EFI_ERROR(Status)) { > diff --git > a/QuarkPlatformPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.= inf > b/QuarkPlatformPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.= inf > index af399e529a92..25394d8ca000 100644 > --- a/QuarkPlatformPkg/Library/PlatformBootManagerLib/PlatformBootManager= Lib.inf > +++ b/QuarkPlatformPkg/Library/PlatformBootManagerLib/PlatformBootManager= Lib.inf > @@ -40,6 +40,7 @@ [Packages] > SourceLevelDebugPkg/SourceLevelDebugPkg.dec > QuarkPlatformPkg/QuarkPlatformPkg.dec > SecurityPkg/SecurityPkg.dec > + ShellPkg/ShellPkg.dec > SignedCapsulePkg/SignedCapsulePkg.dec >=20 > [LibraryClasses] > @@ -70,6 +71,7 @@ [Guids] > gEfiVTUTF8Guid > gEfiTtyTermGuid > gEfiEndOfDxeEventGroupGuid > + gUefiShellFileGuid >=20 > [Pcd] > gEfiMdePkgTokenSpaceGuid.PcdUartDefaultBaudRate > -- > 2.7.4