From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CFF9321A0483B for ; Wed, 19 Apr 2017 21:15:42 -0700 (PDT) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Apr 2017 21:15:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,223,1488873600"; d="scan'208";a="251286366" Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132]) by fmsmga004.fm.intel.com with ESMTP; 19 Apr 2017 21:15:41 -0700 Received: from orsmsx155.amr.corp.intel.com (10.22.240.21) by ORSMSX105.amr.corp.intel.com (10.22.225.132) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 19 Apr 2017 21:15:41 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.59]) by ORSMSX155.amr.corp.intel.com ([169.254.7.202]) with mapi id 14.03.0319.002; Wed, 19 Apr 2017 21:15:40 -0700 From: "Kinney, Michael D" To: "Zhu, Yonghong" , "edk2-devel@lists.01.org" , "Kinney, Michael D" CC: "Gao, Liming" , "Shaw, Kevin W" Thread-Topic: [edk2-BuildSpecification PATCH 3/3] Add report section for mixed PCD access Thread-Index: AQHSuYMsTUXaOvH3RkGs8hnD7rgdxKHNpkow Date: Thu, 20 Apr 2017 04:15:40 +0000 Message-ID: References: <1492634248-15292-1-git-send-email-michael.d.kinney@intel.com> <1492634248-15292-4-git-send-email-michael.d.kinney@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmZiN2MwNGUtNTU4MS00MDg3LWJmMDgtZTBhNWIzOTFiMDk4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlpJQWF4Ujk2K25kXC9BRjFjem1zeEh4RWs1Y2gwSWg4YlN2RXdTVlYrWDBnPSJ9 dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Subject: Re: [edk2-BuildSpecification PATCH 3/3] Add report section for mixed PCD access X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Apr 2017 04:15:43 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Zhu Yonghong, Yes. That is supposed to be 13.5. I will fix before I checkin. Mike > -----Original Message----- > From: Zhu, Yonghong > Sent: Wednesday, April 19, 2017 8:07 PM > To: Kinney, Michael D ; edk2-devel@lists.01.o= rg > Cc: Gao, Liming ; Shaw, Kevin W ; > Zhu, Yonghong > Subject: RE: [edk2-BuildSpecification PATCH 3/3] Add report section for m= ixed PCD > access >=20 > Hi Mike, >=20 > Is this section 13.5 but not 13.6 ? others are good to me. Reviewed-by: = Yonghong > Zhu >=20 > ## 13.6 Mixed PCD Section >=20 > Best Regards, > Zhu Yonghong >=20 > -----Original Message----- > From: Kinney, Michael D > Sent: Thursday, April 20, 2017 4:37 AM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Zhu, Yonghong ; > Shaw, Kevin W > Subject: [edk2-BuildSpecification PATCH 3/3] Add report section for mixed= PCD > access >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D485 >=20 > The build tools currently require a PCD to use the same access method fro= m all > modules. This update still requires modules built from sources to use th= e same > access method, but binary modules are allowed to use alternate access met= hods. >=20 > Cc: Liming Gao > Cc: Yonghong Zhu > Cc: Kevin W Shaw > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Michael Kinney > --- > 13_build_reports/133_output.md | 1 + > 13_build_reports/135_mixed_pcd_section.md | 54 ++++++++++++++++= ++++++ > 13_build_reports/136_global_pcd_section.md | 14 +++--- > 13_build_reports/137_fd_section.md | 10 ++-- > 13_build_reports/138_module_section.md | 16 +++---- > .../139_execution_order_prediction_section.md | 4 +- > README.md | 1 + > SUMMARY.md | 9 ++-- > 8 files changed, 83 insertions(+), 26 deletions(-) create mode 100644 > 13_build_reports/135_mixed_pcd_section.md >=20 > diff --git a/13_build_reports/133_output.md b/13_build_reports/133_output= .md > index 5363b7f..ce64efd 100644 > --- a/13_build_reports/133_output.md > +++ b/13_build_reports/133_output.md > @@ -51,6 +51,7 @@ The layout of the text report file: >=20 > ``` > |---- Platform summary > + |----- Mixed PCD section > |----- Global PCD section > |----- FD section* > |---- FD Region sub-section* > diff --git a/13_build_reports/135_mixed_pcd_section.md > b/13_build_reports/135_mixed_pcd_section.md > new file mode 100644 > index 0000000..98d6662 > --- /dev/null > +++ b/13_build_reports/135_mixed_pcd_section.md > @@ -0,0 +1,54 @@ > + > + > +## 13.6 Mixed PCD Section > + > +There is an optional sub-section that, when present, lists the PCDs in > +the platform that use multiple access methods. This sub-section is only > +present if there are Binary modules included in the platform build and > +the binary module uses a different PCD access method than other modules > +in the same platform build. > + > +The sub-section header is: > + > +``` > +>=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > +>=3D=3D=3D=3D=3D=3D=3D=3D=3D< > +The following PCDs use different access methods: > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > +.. (List of PCDs) > +<=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > +=3D=3D=3D=3D=3D=3D=3D=3D=3D> > +``` > + > +Format for the entries in this section: > + > +``` > +. > +``` > diff --git a/13_build_reports/136_global_pcd_section.md > b/13_build_reports/136_global_pcd_section.md > index 664949e..f24f97a 100644 > --- a/13_build_reports/136_global_pcd_section.md > +++ b/13_build_reports/136_global_pcd_section.md > @@ -1,5 +1,5 @@ > >=20 > -## 13.5 Global PCD Section > +## 13.6 Global PCD Section >=20 > This section contains the information for all PCDs whose values are the = same > for all modules in a platform. The content of global PCD sub-section is g= rouped > @@ -47,7 +47,7 @@ gEfiMdeModulePkgTokenSpaceGuid >=20 > Each global PCD item contains one or more lines: >=20 > -### 13.5.1 Required line > +### 13.6.1 Required line >=20 > The first line is required: >=20 > @@ -67,9 +67,9 @@ The first line is required: > DEC DEFAULT =3D 0x0 `= `` >=20 > -### 13.5.2 Optional lines > +### 13.6.2 Optional lines >=20 > -#### 13.5.2.1 Dynamic/DynamicEx > +#### 13.6.2.1 Dynamic/DynamicEx >=20 > * if `` is DYN-HII >=20 > @@ -93,7 +93,7 @@ The first line is required: > 0x0001FFF > ``` >=20 > -#### 13.5.2.2 Default (optional) line > +#### 13.6.2.2 Default (optional) line >=20 > The second optional line is present if the value from the DEC was overri= dden. > It is formatted as follows: > @@ -107,7 +107,7 @@ It is formatted as follows: > DEC DEFAULT =3D 0x0 ``` >=20 > -#### 13.5.2.3 Additional optional lines > +#### 13.6.2.3 Additional optional lines >=20 > Additional lines are optional and show if the PCD's value was obtained f= rom the > INF file. This will be listed if the module's final PCD value is not the = same > diff --git a/13_build_reports/137_fd_section.md > b/13_build_reports/137_fd_section.md > index 81b8831..49c2695 100644 > --- a/13_build_reports/137_fd_section.md > +++ b/13_build_reports/137_fd_section.md > @@ -1,5 +1,5 @@ > >=20 > -## 13.6 FD Section > +## 13.7 FD Section >=20 > This section contains platform flash device information and its layout. >=20 > -### 13.6.1 FD Section Header > +### 13.7.1 FD Section Header >=20 > Given that a platform may have multi-Firmware device, this section may a= ppear > more than once in the output report. The section header lists the name of= FD > @@ -59,7 +59,7 @@ Size: 0x2a0000(2688KB) > <=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D> > ``` >=20 > -### 13.6.2 FD Region Sub-section > +### 13.7.2 FD Region Sub-section >=20 > This sub-section contains FD region information of platform flash device= . If > the region is a firmware volume, it lists the set of modules and its spac= e > @@ -122,7 +122,7 @@ Size: 0x2000 (8K) > ...(More list of FD regions) > ``` >=20 > -### 13.6.3 VPD PCD Sub-section > +### 13.7.3 VPD PCD Sub-section >=20 > This section lists, in Offset order, every VPD PCD specified in the DSC = file. > The line format for this section is PcdName SkuId Offset PcdSize PcdValu= e. > diff --git a/13_build_reports/138_module_section.md > b/13_build_reports/138_module_section.md > index 96200a2..23e039b 100644 > --- a/13_build_reports/138_module_section.md > +++ b/13_build_reports/138_module_section.md > @@ -1,5 +1,5 @@ > >=20 > -## 13.7 Module Section > +## 13.8 Module Section >=20 > Module section lists all modules involved in the platform build. If the > **EXECUTION_ORDER** option is specified in **-Y** option, the module sec= tions > are sorted according to their PEI or DXE dispatch order; otherwise the mo= dule > sections are listed according to their DSC position. >=20 > -### 13.7.1 Module Section Summary > +### 13.8.1 Module Section Summary >=20 > This sub-section lists the module basic information: Module name: INF fi= le, > file GUID, module size, module build time stamp and driver type. > @@ -99,7 +99,7 @@ Driver Type: 0x7 (DRIVER) > <=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D> > ``` >=20 > -### 13.7.2 Library Sub-section > +### 13.8.2 Library Sub-section >=20 > This sub-section, which follows each Module Summary section, holds the > information for all libraries used in this module. If it is an EDKII styl= e @@ - > 208,7 +208,7 @@ > s:\edk2\EdkCompatibilityPkg\Foundation\Framework\Guid\EdkFrameworkGuidLib= .inf > option. > ********** >=20 > -### 13.7.3 PCD Sub-section > +### 13.8.3 PCD Sub-section >=20 > This sub-section (following the Module Summary information) holds the > information for all PCDs used in this module. The content of module PCD @= @ -281,7 > +281,7 @@ Each PCD may contain up to four lines: > option. > ********** >=20 > -### 13.7.4 DEPEX Sub-section > +### 13.8.4 DEPEX Sub-section >=20 > This sub-section (following the Module Summary information) holds module > dependency expression (DEPEX) information. The sub-section header holds t= he @@ - > 353,7 +353,7 @@ EFI_HII_DATABASE_PROTOCOL_GUID option. > ********** >=20 > -### 13.7.5 Build Flags Sub-section > +### 13.8.5 Build Flags Sub-section >=20 > This sub-section (following the Module Summary information) holds module= build > flags information. The sub-section header holds the module tool chain tag= and @@ > -387,7 +387,7 @@ EHs-c- /GR- /GF /Gy /Zi /Gm `-Y` option. > ********** >=20 > -### 13.7.6 Fixed Address Prediction Sub-section > +### 13.8.6 Fixed Address Prediction Sub-section >=20 > This sub-section (following the Module Summary information) contains mod= ule > notification function information. All the notification functions are lis= ted diff > --git a/13_build_reports/139_execution_order_prediction_section.md > b/13_build_reports/139_execution_order_prediction_section.md > index c4e4a2b..7a2f277 100644 > --- a/13_build_reports/139_execution_order_prediction_section.md > +++ b/13_build_reports/139_execution_order_prediction_section.md > @@ -1,5 +1,5 @@ > >=20 > -## 13.8 Execution Order Prediction Section > +## 13.9 Execution Order Prediction Section >=20 > This section contains platform level prediction for the execution flow. = Each > phase list the following triple in their predicted order: > diff --git a/README.md b/README.md > index 21bb782..c511971 100644 > --- a/README.md > +++ b/README.md > @@ -206,3 +206,4 @@ Copyright (c) 2008-2017, Intel Corporation. All right= s > reserved. > | | [#483](https://bugzilla.tianocore.org/show_bug.cgi?id=3D4= 83) Build > Spec: add description for merge Pre-build and Post-build into build proce= ss > | | > | | [#490](https://bugzilla.tianocore.org/show_bug.cgi?id=3D4= 90) Build > Spec: specify the alignment requirements for VOID* PCDs stored in a PCD s= ection > | | > | | [#479](https://bugzilla.tianocore.org/show_bug.cgi?id=3D4= 79) Build > spec: add description for nmake long command line handling > | | > +| | [#485](https://bugzilla.tianocore.org/show_bug.cgi?id=3D4= 85) Build > spec: add support for mixed Pcd access method > | | > diff --git a/SUMMARY.md b/SUMMARY.md > index e374319..386fb4f 100644 > --- a/SUMMARY.md > +++ b/SUMMARY.md > @@ -107,10 +107,11 @@ > * [13.2 Sample Launch Steps: NT32 > platform](13_build_reports/132_sample_launch_steps_nt32_platform.md#132-s= ample- > launch-steps-nt32-platform) > * [13.3 Output](13_build_reports/133_output.md#133-output) > * [13.4 Platform Summary](13_build_reports/134_platform_summary.md#134= - > platform-summary) > - * [13.5 Global PCD Section](13_build_reports/135_global_pcd_section.md= #135- > global-pcd-section) > - * [13.6 FD Section](13_build_reports/136_fd_section.md#136-fd-section) > - * [13.7 Module Section](13_build_reports/137_module_section.md#137-mod= ule- > section) > - * [13.8 Execution Order Prediction > Section](13_build_reports/138_execution_order_prediction_section.md#138- > execution-order-prediction-section) > + * [13.5 Mixed PCD > + Section](13_build_reports/135_mixed_pcd_section.md#135-mixed-pcd-secti > + on) > + * [13.6 Global PCD > + Section](13_build_reports/136_global_pcd_section.md#136-global-pcd-sec > + tion) > + * [13.7 FD > + Section](13_build_reports/137_fd_section.md#137-fd-section) > + * [13.8 Module > + Section](13_build_reports/138_module_section.md#138-module-section) > + * [13.9 Execution Order Prediction > + Section](13_build_reports/139_execution_order_prediction_section.md#13 > + 9-execution-order-prediction-section) > * [Appendix A Variables](appendix_a_variables.md#appendix-a-variables) > * [Appendix B tools_def.txt](appendix_b_toolsdef_txt.md#appendix-b-tools= _deftxt) > * [Appendix C target.txt](appendix_c_targettxt.md#appendix-c-targettxt) > -- > 2.6.3.windows.1