From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 89165219493F4 for ; Wed, 26 Apr 2017 11:04:43 -0700 (PDT) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Apr 2017 11:04:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,255,1488873600"; d="scan'208";a="1161328872" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by fmsmga002.fm.intel.com with ESMTP; 26 Apr 2017 11:04:43 -0700 Received: from orsmsx155.amr.corp.intel.com (10.22.240.21) by ORSMSX109.amr.corp.intel.com (10.22.240.7) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 26 Apr 2017 11:04:42 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.59]) by ORSMSX155.amr.corp.intel.com ([169.254.7.202]) with mapi id 14.03.0319.002; Wed, 26 Apr 2017 11:04:42 -0700 From: "Kinney, Michael D" To: Tim Lewis , "Zeng, Star" , "edk2-devel@lists.01.org" , "Kinney, Michael D" CC: "Gao, Liming" Thread-Topic: [RFC] PCD: Extended SKU support 1 - inheritance Thread-Index: AdK8pzAQEOD5vN6pRr2+K5rEi6Vq8wCAToJwAANxi6A= Date: Wed, 26 Apr 2017 18:04:41 +0000 Message-ID: References: <0C09AFA07DD0434D9E2A0C6AEB0483103B87E776@shsmsx102.ccr.corp.intel.com> <7236196A5DF6C040855A6D96F556A53F5763C0@msmail.insydesw.com.tw> In-Reply-To: <7236196A5DF6C040855A6D96F556A53F5763C0@msmail.insydesw.com.tw> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGE4MjVlNzMtMzgwZC00MTUxLTk2N2ItZDdhNTlhMzJhYmMyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlZ5N2V3TkFTUmkrSU5yWmpTenUwXC9lNjdLWnpNeHpuMlpDVEF3SDhZT0NZPSJ9 dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Subject: Re: [RFC] PCD: Extended SKU support 1 - inheritance X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Apr 2017 18:04:43 -0000 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Tim, Can you please provide more details on your specific concerns along with so= me use cases? This RFC does not change the SKU feature in EDK II. This RFC simply provid= es a more=20 efficient way for a developer to provide PCD values for different SKUs with= fewer PCD statements in a DSC file. Today, every SKU is a based on the DEFAULT SKU and if a PCD requires a diff= erent value than the DEFAULT SKU value, then a SKU specific PCD statement is required.= =20 With this proposal, a relationship between SKUs can be declared in the DSC = file, so SKUs can inherit PCD values from other SKUs. This inheritance is limited t= o=20 the scope of the DSC file. This RFC has no impact to the PCD database or b= ehavior of PCD services. The example Star provides at the end shows the equivalent set of PCD settin= gs using the current EDK II syntax and with this RFC's backwards compatible syntax e= xtensions. One way to think about this RFC is that a DSC file using the syntax in this= RFC can be converted to a DSC file without the RFC syntax. In fact, that is what t= he=20 implementation of this RFC would do to build the set of PCD values for each= SKU. =20 Thanks, Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ti= m Lewis > Sent: Wednesday, April 26, 2017 9:21 AM > To: Zeng, Star ; edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Gao, Liming > > Subject: Re: [edk2] [RFC] PCD: Extended SKU support 1 - inheritance >=20 > Star -- >=20 > This assumes that the SKU ID is only used for PCDs, which is not the case= . The > SKU ID may be used by other components, and other components may use the > 0|DEFAULT rule as well. >=20 > 1) There is no way to read this defaulting rule at runtime. The informati= on is > buried in the PCD database, but not available externally. > 2) There is no way to read the contents of SKUID_IDENTIFIER when multiple= SKUs > are specified. While more than one SKU can be specified (separated by spa= ces), > there is no way to pass multiple values into build.exe today, nor is ther= e any > way to identify which SKUs (out of the total list of SKUs) is supported o= n one > build at runtime. >=20 > Tim >=20 >=20 > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ze= ng, Star > Sent: Tuesday, April 25, 2017 5:40 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Zeng, Star > ; Gao, Liming > Subject: [edk2] [RFC] PCD: Extended SKU support 1 - inheritance >=20 > - Requirement > Simplify the PCDs configuring for multiple SKUs in DSC. >=20 >=20 > - Current limitation > Non-DEFAULT SKU could only derive from DEFAULT SKU, but could not derive = from > another non-DEFAULT SKU. > For example below, SkuA and SkuB could only derive from DEFAULT, but SkuB= could > not derive from SkuA. >=20 > [SkuIds] > =A0 0 | DEFAULT > =A0 1 | SkuA > =A0 2 | SkuB >=20 >=20 > - Proposal: One non-DEFAULT SKU could be a derivative of another non-DEFA= ULT SKU. > This proposal only extends DSC [SkuIds] section syntax and the extension = is > optional. > This proposal keeps the backward compatibility with current SKU usage. > BaseTools update is needed to support the syntax extension, and no any ch= ange in > PCD database and driver is required. >=20 > DSC syntax: > [SkuIds] > SkuValue|SkuName[|ParentSkuName] > SkuValue: integer, 0 is reserved for DEFAULT SKU. > SkuName: string > ParentSkuName: string, optional, it is new introduced in this propo= sal and > defines which SKU the PCD value will derive from for this SKU. The PCD va= lue will > derive from DEFAULT SKU for this SKU if the ParentSkuName is absent. >=20 >=20 > - Example: SkuB is a derivative of SkuA, but not a derivative of DEFAULT. >=20 > [SkuIds] > 0 | DEFAULT > 1 | SkuA > 2 | SkuB | SkuA >=20 > [PcdsDynamicDefault.Common.DEFAULT] > gXXXPkgTokenSpaceGuid.PcdXXXSignature|"DEFAULT" > gXXXPkgTokenSpaceGuid.PcdXXXConfig1|FALSE > gXXXPkgTokenSpaceGuid.PcdXXXConfig2|FALSE > gXXXPkgTokenSpaceGuid.PcdXXXConfig3|FALSE >=20 > [PcdsDynamicDefault.Common.SkuA] > gXXXPkgTokenSpaceGuid.PcdXXXSignature|"SkuA" > gXXXPkgTokenSpaceGuid.PcdXXXConfig1|TRUE > gXXXPkgTokenSpaceGuid.PcdXXXConfig2|TRUE > # No need statement for PcdXXXConfig3 whose value will derive from DE= FAULT > SKU and be FLASE. >=20 > [PcdsDynamicDefault.Common.SkuB] > gXXXPkgTokenSpaceGuid.PcdXXXSignature|" SkuB" > # No need statement for PcdXXXConfig1 and PcdXXXConfig2 whose values = will > derive from SkuA SKU and be TRUE. > gXXXPkgTokenSpaceGuid.PcdXXXConfig3|TRUE > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel