From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1775E21A09129 for ; Thu, 18 May 2017 23:11:40 -0700 (PDT) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 May 2017 23:11:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,362,1491289200"; d="scan'208";a="1171548940" Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by fmsmga002.fm.intel.com with ESMTP; 18 May 2017 23:11:39 -0700 Received: from orsmsx163.amr.corp.intel.com (10.22.240.88) by ORSMSX102.amr.corp.intel.com (10.22.225.129) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 18 May 2017 23:11:39 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.59]) by ORSMSX163.amr.corp.intel.com ([169.254.9.67]) with mapi id 14.03.0319.002; Thu, 18 May 2017 23:11:39 -0700 From: "Kinney, Michael D" To: "Gao, Liming" , "edk2-devel@lists.01.org" , "Kinney, Michael D" CC: "Dong, Eric" , "Zeng, Star" , Andrew Fish Thread-Topic: [edk2] [Patch] MdeModulePkg/LogoDxe: Return error if HII Package not present Thread-Index: AQHSz/zEqg7oXv9Q60SVRNUIsWFS+KH7VDiA///Y5bA= Date: Fri, 19 May 2017 06:11:38 +0000 Message-ID: References: <1495128744-24324-1-git-send-email-michael.d.kinney@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14D730AAD@shsmsx102.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14D730AAD@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTQyZjA4NjUtYzdhMi00ODc1LWExNWItOWU1ZjIwMGNjNTgxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkV0R0hzN2MxdE9EQ1wveTEreDdTZXN3S1hUWWM0MTdLWU0rWEIrTXI0TUtzPSJ9 dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Subject: Re: [Patch] MdeModulePkg/LogoDxe: Return error if HII Package not present X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 May 2017 06:11:40 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Liming, I agree. I have entered a feature request for XCODE5. https://bugzilla.tianocore.org/show_bug.cgi?id=3D557 Mike > -----Original Message----- > From: Gao, Liming > Sent: Thursday, May 18, 2017 6:30 PM > To: Kinney, Michael D ; edk2-devel@lists.01.o= rg > Cc: Dong, Eric ; Zeng, Star ; A= ndrew Fish > > Subject: RE: [edk2] [Patch] MdeModulePkg/LogoDxe: Return error if HII Pac= kage not > present >=20 > Mike: > The code change is good. Reviewed-by: Liming Gao >=20 > But, I think we still need to figure out the solution to create resour= ce section in > XCODE5. >=20 > Thanks > Liming > >-----Original Message----- > >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > >Michael Kinney > >Sent: Friday, May 19, 2017 1:32 AM > >To: edk2-devel@lists.01.org > >Cc: Dong, Eric ; Zeng, Star ; > >Andrew Fish > >Subject: [edk2] [Patch] MdeModulePkg/LogoDxe: Return error if HII Packag= e > >not present > > > >https://bugzilla.tianocore.org/show_bug.cgi?id=3D554 > > > >Update LogoDxe module to exit with an error instead of > >ASSERT_EFI_ERROR() if the HII Package with the logo image > >is not present. > > > >If a tool chain does not support generation of PE/COFF > >resource sections, then this module can not produce the logo > >from an HII Image Package. XCODE5 is an example of a tool > >chain that does not currently support generation of PE/COFF > >resource sections. > > > >Cc: Star Zeng > >Cc: Eric Dong > >Cc: Andrew Fish > >Contributed-under: TianoCore Contribution Agreement 1.0 > >Signed-off-by: Michael Kinney > >--- > > MdeModulePkg/Logo/Logo.c | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > >diff --git a/MdeModulePkg/Logo/Logo.c b/MdeModulePkg/Logo/Logo.c > >index 313dd4a..b34724a 100644 > >--- a/MdeModulePkg/Logo/Logo.c > >+++ b/MdeModulePkg/Logo/Logo.c > >@@ -1,7 +1,7 @@ > > /** @file > > Logo DXE Driver, install Edkii Platform Logo protocol. > > > >-Copyright (c) 2016, Intel Corporation. All rights reserved.
> >+Copyright (c) 2016 - 2017, Intel Corporation. All rights reserved.
> > This program and the accompanying materials > > are licensed and made available under the terms and conditions of the B= SD > >License > > which accompanies this distribution. The full text of the license may = be found > >at > >@@ -133,7 +133,9 @@ InitializeLogo ( > > NULL, > > EFI_OPEN_PROTOCOL_GET_PROTOCOL > > ); > >- ASSERT_EFI_ERROR (Status); > >+ if (EFI_ERROR (Status)) { > >+ return Status; > >+ } > > > > // > > // Publish HII package list to HII Database. > >-- > >2.6.3.windows.1 > > > >_______________________________________________ > >edk2-devel mailing list > >edk2-devel@lists.01.org > >https://lists.01.org/mailman/listinfo/edk2-devel