From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <michael.d.kinney@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by ml01.01.org (Postfix) with ESMTPS id 91EBB2095A359
for <edk2-devel@lists.01.org>; Wed, 24 May 2017 09:53:02 -0700 (PDT)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
by fmsmga105.fm.intel.com with ESMTP; 24 May 2017 09:53:02 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.38,387,1491289200"; d="scan'208";a="972614593"
Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131])
by orsmga003.jf.intel.com with ESMTP; 24 May 2017 09:53:01 -0700
Received: from orsmsx112.amr.corp.intel.com (10.22.240.13) by
ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS)
id 14.3.319.2; Wed, 24 May 2017 09:53:01 -0700
Received: from orsmsx113.amr.corp.intel.com ([169.254.9.59]) by
ORSMSX112.amr.corp.intel.com ([169.254.3.213]) with mapi id 14.03.0319.002;
Wed, 24 May 2017 09:53:00 -0700
From: "Kinney, Michael D" <michael.d.kinney@intel.com>
To: Laszlo Ersek <lersek@redhat.com>, edk2-devel-01 <edk2-devel@lists.01.org>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
CC: "Justen, Jordan L" <jordan.l.justen@intel.com>
Thread-Topic: [edk2] [PATCH 7/8] QuarkPlatformPkg/SpiFvbServices: correct
NumOfLba vararg type in EraseBlocks()
Thread-Index: AQHSz+g63kan+YpodkKzw2GgotU3mqIDvHdw
Date: Wed, 24 May 2017 16:52:59 +0000
Message-ID: <E92EE9817A31E24EB0585FDF735412F57D177980@ORSMSX113.amr.corp.intel.com>
References: <20170518150427.16435-1-lersek@redhat.com>
<20170518150427.16435-8-lersek@redhat.com>
In-Reply-To: <20170518150427.16435-8-lersek@redhat.com>
Accept-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ctpclassification: CTP_IC
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWM4ZjNjMTQtY2M1Zi00MzQ1LWJjOTYtNDcwOGQwODE0MmZiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImhNcFdwNUV3UVFNZnpJZk9HZXdsOU5DM1h1eUJOZm1kVHhDUUhxeVhsSkE9In0=
dlp-product: dlpe-windows
dlp-version: 10.0.102.7
dlp-reaction: no-action
x-originating-ip: [10.22.254.139]
MIME-Version: 1.0
Subject: Re: [PATCH 7/8] QuarkPlatformPkg/SpiFvbServices: correct NumOfLba vararg type in EraseBlocks()
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: EDK II Development <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
<mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
<mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Wed, 24 May 2017 16:53:02 -0000
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Mike
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of La=
szlo Ersek
> Sent: Thursday, May 18, 2017 8:04 AM
> To: edk2-devel-01 <edk2-devel@lists.01.org>
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Justen, Jordan L
> <jordan.l.justen@intel.com>
> Subject: [edk2] [PATCH 7/8] QuarkPlatformPkg/SpiFvbServices: correct NumO=
fLba vararg
> type in EraseBlocks()
>=20
> According to the PI spec, Volume 3,
> EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL.EraseBlocks():
>=20
> > The variable argument list is a list of tuples. Each tuple describes a
> > range of LBAs to erase and consists of the following:
> > * An EFI_LBA that indicates the starting LBA
> > * A UINTN that indicates the number of blocks to erase
>=20
> (NB, in edk2, EFI_FIRMWARE_VOLUME_BLOCK_PROTOCOL is a typedef to
> EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL.)
>=20
> In this driver, the NumOfLba local variable is defined with type UINTN,
> but the TYPE argument passed to VA_ARG() is UINT32. Fix the mismatch.
>=20
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Kelly Steele <kelly.steele@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Reported-by: Jordan Justen <jordan.l.justen@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>=20
> Notes:
> unbuilt, untested
>=20
> QuarkPlatformPkg/Platform/SpiFvbServices/FwBlockService.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/QuarkPlatformPkg/Platform/SpiFvbServices/FwBlockService.c
> b/QuarkPlatformPkg/Platform/SpiFvbServices/FwBlockService.c
> index dbb5512f386e..0e7a7b79a1cf 100644
> --- a/QuarkPlatformPkg/Platform/SpiFvbServices/FwBlockService.c
> +++ b/QuarkPlatformPkg/Platform/SpiFvbServices/FwBlockService.c
> @@ -1211,7 +1211,7 @@ Returns:
> break;
> }
>=20
> - NumOfLba =3D VA_ARG (args, UINT32);
> + NumOfLba =3D VA_ARG (args, UINTN);
>=20
> //
> // Check input parameters
> @@ -1235,7 +1235,7 @@ Returns:
> break;
> }
>=20
> - NumOfLba =3D VA_ARG (args, UINT32);
> + NumOfLba =3D VA_ARG (args, UINTN);
>=20
> while (NumOfLba > 0) {
> Status =3D FvbEraseBlock (FvbDevice->Instance, StartingLba, mFvbMo=
duleGlobal,
> EfiGoneVirtual ());
> --
> 2.9.3
>=20
>=20
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel