From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 177EB21AE3CCD for ; Tue, 30 May 2017 23:00:19 -0700 (PDT) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 May 2017 23:01:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,422,1491289200"; d="scan'208";a="974960817" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by orsmga003.jf.intel.com with ESMTP; 30 May 2017 23:01:18 -0700 Received: from orsmsx155.amr.corp.intel.com (10.22.240.21) by ORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 30 May 2017 23:01:18 -0700 Received: from orsmsx112.amr.corp.intel.com ([169.254.3.182]) by ORSMSX155.amr.corp.intel.com ([169.254.7.103]) with mapi id 14.03.0319.002; Tue, 30 May 2017 23:01:17 -0700 From: "Kinney, Michael D" To: "Zhu, Yonghong" , "edk2-devel@lists.01.org" , "Kinney, Michael D" CC: "Gao, Liming" , "Shaw, Kevin W" Thread-Topic: [edk2-DscSpecification PATCH] Update Precedence of PCD Values Thread-Index: AQHS2a8Au13Yry3xh0qh5qgOTPytFaIN8xrg Date: Wed, 31 May 2017 06:01:17 +0000 Message-ID: References: <1495913686-36548-1-git-send-email-michael.d.kinney@intel.com> <1495913686-36548-2-git-send-email-michael.d.kinney@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmUzOTQyZTgtOGRiYy00OTFkLWJhNDEtZWE0MmE1MzY2YmE0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlRZckIwR2p5YzNOa0ZMN0lWcCtIMjRacUdrSGhQSUVycU5QUmd4UXR3MjA9In0= dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Subject: Re: [edk2-DscSpecification PATCH] Update Precedence of PCD Values X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2017 06:00:19 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Yonghong, Thanks for the feedback. I have sent V2 with these corrections. Mike -----Original Message----- From: Zhu, Yonghong=20 Sent: Tuesday, May 30, 2017 6:41 PM To: Kinney, Michael D ; edk2-devel@lists.01.org Cc: Gao, Liming ; Shaw, Kevin W ; Zhu, Yonghong Subject: RE: [edk2-DscSpecification PATCH] Update Precedence of PCD Values Hi Mike, 1. Is this 'p' typo error is sentence "DSC file, p FeatureFlag, PatchableIn= Module or FixedAtBuild PCD value"? 2. How about remove the "FeatureFlag, PatchableInModule or FixedAtBuild" fr= om below sentence since current Dynamic/DynamicEx also can have the specifi= c arch info. "DSC file, a FeatureFlag, PatchableInModule or FixedAtBuild PCD value defin= ed in a PCD access method section with an architectural modifier" Best Regards, Zhu Yonghong -----Original Message----- From: Kinney, Michael D=20 Sent: Sunday, May 28, 2017 3:35 AM To: edk2-devel@lists.01.org Cc: Gao, Liming ; Zhu, Yonghong ; Shaw, Kevin W Subject: [edk2-DscSpecification PATCH] Update Precedence of PCD Values https://bugzilla.tianocore.org/show_bug.cgi?id=3D519 Cc: Liming Gao Cc: Yonghong Zhu Cc: Kevin W Shaw Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Michael Kinney --- 2_dsc_overview/28_pcd_section_processing.md | 56 ++++++++++++++-----------= ---- README.md | 5 +-- 2 files changed, 31 insertions(+), 30 deletions(-) diff --git a/2_dsc_overview/28_pcd_section_processing.md b/2_dsc_overview/2= 8_pcd_section_processing.md index 60e7de7..3736cde 100644 --- a/2_dsc_overview/28_pcd_section_processing.md +++ b/2_dsc_overview/28_pcd_section_processing.md @@ -312,45 +312,45 @@ string plus 1 byte for the null terminator, for L"str= ing" entries to be the length of the UCS-2 character string plus 2 bytes f= or the null terminator and the exact length of a byte array. =20 -Precedence for determining PCD values (high to low, last in position) is a= s -follows: +The values that are assigned to individual PCDs required by a build may=20 +come from different locations and different meta-data files. The=20 +following provides the precedence (high to low) to assign a value to a PCD= . =20 -* A PCD value defined by a MACRO, ("MacroName" in this example), and the M= acro - is defined on the command-line using -D MacroName=3DValue +* Command-line, `--pcd` flags (left most has higher priority) =20 -* A PCD value defined in the FDF file SET statements +* DSC file, p FeatureFlag, PatchableInModule or FixedAtBuild PCD value=20 +defined + in the `[Components]` INF scoping `` section statements =20 -* A PCD value defined positionally in the FDF file +* FDF file, grammar describing automatic assignment of PCD values =20 -* A FeatureFlag, PatchableInModule or FixedAtBuild PCD value defined in th= e - `[Components]` INF scoping section +* FDF file, SET statements within a section =20 -* A FeatureFlag, PatchableInModule or FixedAtBuild PCD value defined in a = PCD - access method section with an architectural modifier (the access method = for a - PCD in a section with an architectural modifier takes precedence over an= y - other access method) +* FDF file, SET statement in the [Defines] section =20 -In this example, modules built for IA32 architecture, the PCD will use -Pa= tchableInModule access, while modules built for all other architectures, th= e -PCD will use the FixedAtBuild access method: +* DSC file, a FeatureFlag, PatchableInModule or FixedAtBuild PCD value=20 +defined + in a PCD access method section with an architectural modifier. =20 -```ini -[PcdsFixedAtBuild.common] - gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeMemorySize|1 - gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FAL= SE + In this example, modules built for IA32 architecture, the PCD will=20 + use PatchableInModule access, while modules built for all other=20 + architectures, the PCD will use the FixedAtBuild access method: =20 -[PcdsPatchableInModule.IA32] - gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeMemorySize|1 - gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FAL= SE -``` + ```ini + [PcdsFixedAtBuild.common] + gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeMemorySize|1 + =20 + gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|F + ALSE + + [PcdsPatchableInModule.IA32] + gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeMemorySize|1 + =20 + gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|F + ALSE + ``` =20 -* A PCD value defined in a PCD access method (item type) section for commo= n - architectures +* DSC file, A PCD value defined in a PCD access method (item type)=20 +global + `[Pcd*]` section for common architectures. =20 -* A PCD value defined in an INF (provided all INF files have defined the s= ame - value) +* INF file, PCD sections, Default Values (provided all INF files have=20 +defined + the same value) =20 -* A PCD default value defined in the DEC file that declares the PCD. +* DEC file, PCD sections, Default Values =20 ********** **Note:** Dynamic or DynamicEx PCD sections with architectural modifiers i= s not diff --git a/README.md b/README.md index 1d1f99c..3bec3b3 100644 --- a/README.md +++ b/README.md @@ -176,7 +176,8 @@ Copyright (c) 2006-2017, Intel Corporation. All rights = reserved. | | Update the DSC_SPECIFICATION version to 0x0001001A = = = = | | | | Revised WORKSPACE wording for updated build system that can= handle packages located outside of the WORKSPACE directory tree (refer to = the TianoCore.org/ EDKII website for additional instructions on setting up = a development environment). = | | | | Added new system environment variables used by the build sy= stem. = = = | | -| 1.27 | Convert to GitBooks = = = = | April 2017 | +| 1.27 | Convert to GitBooks = = = = | May 2017 | | | [#351](https://bugzilla.tianocore.org/show_bug.cgi?id=3D351= ) [DSC Spec] Extend macro usage in the !include statement = = = | | | | [#484](https://bugzilla.tianocore.org/show_bug.cgi?id=3D484= ) DSC spec: support Prebuild and Postbuild in the [Defines] section = = = | | -| | [#353](https://bugzilla.tianocore.org/show_bug.cgi?id=3D353= ) Build spec: Allow nested includes in DSC and FDF files = = = | | +| | [#353](https://bugzilla.tianocore.org/show_bug.cgi?id=3D353= ) Build spec: Allow nested includes in DSC and FDF files = = = | | +| | [#519](https://bugzilla.tianocore.org/show_bug.cgi?id=3D519= ) DSC Spec: update Precedence of PCD Values = = = | | -- 2.6.3.windows.1