Re: [Patch][edk2-platforms/minnowboard-max-udk2017] Add new platform branch minnowboard-max-udk2017

["Kinney, Michael D" <michael.d.kinney@intel.com>]

Guo Mang,

A platform in the edk2-platforms repository should not contain
the packages from the edk2 repository.

Instead, the instructions for the platform should require both
the edk2 repo and the edk2-platform repo to be cloned with the
correct branches checked out and PACKAGES_PATH set so the build 
tools can use packages from both branches.

This maximizes the reuse of the code from the edk2 repo and 
minimizes the amount of code in a platform branch in edk2-platforms.

Also, the branch name does not follow the naming convention.  Please
see: https://github.com/tianocore/edk2-platforms/blob/about/Readme.md

Thanks,

Mike

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On
> Behalf Of Guo, Mang
> Sent: Monday, July 31, 2017 2:26 AM
> To: edk2-devel@lists.01.org
> Cc: Lu, ShifeiX A <shifeix.a.lu@intel.com>; Wei, David
> <david.wei@intel.com>
> Subject: [edk2] [Patch][edk2-platforms/minnowboard-max-udk2017]
> Add new platform branch minnowboard-max-udk2017
> 
> Create a new branch (minnowboard-max-udk2017) on edk2-platforms
> for MinnowBoard Max. This code base is based on UDK2017 core
> packages.
> Code is ready in https://github.com/mangguo321/edk2-
> platforms/tree/minnowboard-max-udk2017
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> 
> Signed-off-by: Guo Mang <mang.guo@intel.com>
> ---
>  ReadMe.MD | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>  create mode 100644 ReadMe.MD
> 
> diff --git a/ReadMe.MD b/ReadMe.MD
> new file mode 100644
> index 0000000..8dcca92
> --- /dev/null
> +++ b/ReadMe.MD
> @@ -0,0 +1,10 @@
> +# MINNOWBOARD MAX/TURBOT PLATFORM FIRMWARE
> +
> +This UEFI firmware is designed for the open hardware
> MinnowBoard Max/Turbot platforms using
> +the Intel(R) Atom(tm) Processor E3800 Series, based on UDK2017
> core packages.
> +
> +http://minnowboard.org/ -- Platform Information, including
> schematics and information on where to purchase boards.
> +
> +https://firmware.intel.com/projects/minnowboard-max -- Release
> notes, pre-built release/debug binaries, build instructions, and
> binary objects required to compile firmware.
> +
> +
> --
> 2.10.1.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel