Re: [PATCH] staging/edk2-test: TestProfile bug fix

["Kinney, Michael D" <michael.d.kinney@intel.com>]

Hi Felix,

Thanks for the contribution.

Do you have a test case that reproduces the issue you found?

Thanks,

Mike

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On
> Behalf Of Felix Poludov
> Sent: Wednesday, August 2, 2017 6:54 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH] staging/edk2-test: TestProfile bug fix
> 
> The patch is a bug fix for TestFrameworkPkg/Support/TestProfile
> driver.
> AsciiStrCpy function was used to copy overlapping strings, which
> triggered an ASSERT.
> 
> The function was used on overlapping strings in a couple of
> places:
> 1. _alltrim: AsciiStrCpy is replaced with CopyMem, which can
> handle overlapping buffers
> 2. _prosessLine: AsciiStrCpy at the beginning of the function is
> removed.
> The call was redundant. The function was trying to move the data
> that have already been moved by _alltrim.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Felix Polyudov <felixp@ami.com>
> ---
> 
> diff --git a/TestFrameworkPkg/Support/TestProfile/TestProfile.c
> b/TestFrameworkPkg/Support/TestProfile/TestProfile.c
> index f02e9df..3f0e0d5 100644
> --- a/TestFrameworkPkg/Support/TestProfile/TestProfile.c
> +++ b/TestFrameworkPkg/Support/TestProfile/TestProfile.c
> @@ -269,7 +269,7 @@ Routine Description:
>    }
>    tmp[Index] = '\0';
> -  AsciiStrCpy (ptrStr, tmp);
> +  CopyMem(ptrStr, tmp, Index+1);
>    return ptrStr;
> }
> @@ -419,7 +419,7 @@ Routine Description:
>    CHAR8 ptrValue[MAX_STRING_LEN + 1];
>    INI   *ptrItem;
> -  AsciiStrCpy (ptrLine, _alltrim (ptrLine));
> +  _alltrim (ptrLine);
>    if (*ptrLine == '#') {
>      // it's a comment line
> 
> 
> Please consider the environment before printing this email.
> 
> The information contained in this message may be confidential
> and proprietary to American Megatrends, Inc.  This communication
> is intended to be read only by the individual or entity to whom
> it is addressed or by their designee. If the reader of this
> message is not the intended recipient, you are on notice that
> any distribution of this message, in any form, is strictly
> prohibited.  Please promptly notify the sender by reply e-mail
> or by telephone at 770-246-8600, and then delete or destroy all
> copies of the transmission.
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel