From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0595A2095D8FF for ; Fri, 4 Aug 2017 11:07:25 -0700 (PDT) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Aug 2017 11:09:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,321,1498546800"; d="scan'208";a="119870016" Received: from orsmsx103.amr.corp.intel.com ([10.22.225.130]) by orsmga002.jf.intel.com with ESMTP; 04 Aug 2017 11:09:37 -0700 Received: from orsmsx153.amr.corp.intel.com (10.22.226.247) by ORSMSX103.amr.corp.intel.com (10.22.225.130) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 4 Aug 2017 11:09:34 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.9]) by ORSMSX153.amr.corp.intel.com ([169.254.12.220]) with mapi id 14.03.0319.002; Fri, 4 Aug 2017 11:09:34 -0700 From: "Kinney, Michael D" To: "Dong, Eric" , "edk2-devel@lists.01.org" , "Kinney, Michael D" CC: "Ni, Ruiyu" , "Fan, Jeff" Thread-Topic: [edk2] [Patch v4 1/3] UefiCpuPkg: Add Pcds used by processor trace feature. Thread-Index: AQHTDNL7dmvolw+QQ0q5+i+L/AfGUaJ0fz4w Date: Fri, 4 Aug 2017 18:09:33 +0000 Message-ID: References: <1501817823-13992-1-git-send-email-eric.dong@intel.com> <1501817823-13992-2-git-send-email-eric.dong@intel.com> In-Reply-To: <1501817823-13992-2-git-send-email-eric.dong@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Subject: Re: [Patch v4 1/3] UefiCpuPkg: Add Pcds used by processor trace feature. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2017 18:07:25 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Eric, The 2 new PCDs have default values of 0x10 and 0x02, but there is no description of the legal values that these 2 PCDs can have and a description of the meaning of the default value is not provided. Also, if there is a specific legal range, then please add the @ tags to for range checks. Thanks, Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On > Behalf Of Eric Dong > Sent: Thursday, August 3, 2017 8:37 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Fan, Jeff > > Subject: [edk2] [Patch v4 1/3] UefiCpuPkg: Add Pcds used by > processor trace feature. >=20 > Cc: Jeff Fan > Cc: Ruiyu Ni > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Eric Dong > --- > UefiCpuPkg/UefiCpuPkg.dec | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/UefiCpuPkg/UefiCpuPkg.dec > b/UefiCpuPkg/UefiCpuPkg.dec > index e5b0334..2ddeab4 100644 > --- a/UefiCpuPkg/UefiCpuPkg.dec > +++ b/UefiCpuPkg/UefiCpuPkg.dec > @@ -285,5 +285,13 @@ > # @ValidList 0x80000001 | 0 > gUefiCpuPkgTokenSpaceGuid.PcdCpuFeaturesSetting|{0x00, 0x00, > 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}|VOID*|0x00000019 >=20 > + ## Contains the size of memory required when CPU processor > trace is enabled. > + # @Prompt The memory size used for processor trace. > + > gUefiCpuPkgTokenSpaceGuid.PcdCpuProcTraceMemSize|0x10|UINT32|0x6 > 0000012 > + > + ## Contains the processor trace output scheme when CPU > processor trace is enabled. > + # @Prompt The processor trace output scheme. > + > gUefiCpuPkgTokenSpaceGuid.PcdCpuProcTraceOutputScheme|0x2|UINT8| > 0x60000015 > + > [UserExtensions.TianoCore."ExtraFiles"] > UefiCpuPkgExtra.uni > -- > 2.7.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel