From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 944D5208F7A18 for ; Wed, 9 Aug 2017 16:05:55 -0700 (PDT) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP; 09 Aug 2017 16:08:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,349,1498546800"; d="scan'208";a="298157143" Received: from orsmsx101.amr.corp.intel.com ([10.22.225.128]) by fmsmga004.fm.intel.com with ESMTP; 09 Aug 2017 16:08:13 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.211]) by ORSMSX101.amr.corp.intel.com ([169.254.8.61]) with mapi id 14.03.0319.002; Wed, 9 Aug 2017 16:08:12 -0700 From: "Kinney, Michael D" To: "Dong, Eric" , "edk2-devel@lists.01.org" , "Kinney, Michael D" CC: "Gao, Liming" , "Ni, Ruiyu" Thread-Topic: [Patch 1/2] UefiCpuPkg: Add comments for PCDs definition. Thread-Index: AQHTENk8Jamy8/+bC0+Nu5OLuaHc9KJ8pMFg Date: Wed, 9 Aug 2017 23:08:11 +0000 Message-ID: References: <20170809063207.19284-1-eric.dong@intel.com> <20170809063207.19284-2-eric.dong@intel.com> In-Reply-To: <20170809063207.19284-2-eric.dong@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Subject: Re: [Patch 1/2] UefiCpuPkg: Add comments for PCDs definition. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Aug 2017 23:05:55 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Eric, Please add the default value settings to the detailed description. For example, PcdCpuProcTraceMemSize should say that the default value is 0x10 which disables the processor memory trace. Also, the .uni file _HELP should contains the same information as the detailed description, including the set of valid values and their meanings. Please see gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel in=20 MdePkg/MdePkg.uni for an example to follow. Thanks, Mike > -----Original Message----- > From: Dong, Eric > Sent: Tuesday, August 8, 2017 11:32 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming ; Ni, Ruiyu > ; Kinney, Michael D > > Subject: [Patch 1/2] UefiCpuPkg: Add comments for PCDs > definition. >=20 > Cc: Liming Gao > Cc: Ruiyu Ni > Cc: Michael D Kinney > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Eric Dong > --- > UefiCpuPkg/UefiCpuPkg.dec | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) >=20 > diff --git a/UefiCpuPkg/UefiCpuPkg.dec > b/UefiCpuPkg/UefiCpuPkg.dec > index 2ddeab4..1f3a992 100644 > --- a/UefiCpuPkg/UefiCpuPkg.dec > +++ b/UefiCpuPkg/UefiCpuPkg.dec > @@ -287,10 +287,32 @@ >=20 > ## Contains the size of memory required when CPU processor > trace is enabled. > # @Prompt The memory size used for processor trace. > + # 0x0: 4K, > + # 0x1: 8K, > + # 0x2: 16K, > + # 0x3: 32K, > + # 0x4: 64K, > + # 0x5: 128K, > + # 0x6: 256K, > + # 0x7: 512K, > + # 0x8: 1M, > + # 0x9: 2M, > + # 0xA: 4M, > + # 0xB: 8M, > + # 0xC: 16M, > + # 0xD: 32M, > + # 0xE: 64M, > + # 0xF: 128M, > + # 0x10: ProcTraceMemDisable > + # @ValidRange 0x80000001 | 0 - 0x10 >=20 > gUefiCpuPkgTokenSpaceGuid.PcdCpuProcTraceMemSize|0x10|UINT32|0 > x60000012 >=20 > ## Contains the processor trace output scheme when CPU > processor trace is enabled. > # @Prompt The processor trace output scheme. > + # 0: Single Range output scheme.
> + # 1: ToPA(Table of physical address) scheme.
> + # 2: Invalid scheme.
> + # @ValidRange 0x80000001 | 0 - 2 >=20 > gUefiCpuPkgTokenSpaceGuid.PcdCpuProcTraceOutputScheme|0x2|UINT > 8|0x60000015 >=20 > [UserExtensions.TianoCore."ExtraFiles"] > -- > 2.10.1.windows.1