From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 29CAB21E14537 for ; Tue, 15 Aug 2017 08:15:28 -0700 (PDT) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP; 15 Aug 2017 08:17:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,378,1498546800"; d="scan'208";a="119194204" Received: from orsmsx101.amr.corp.intel.com ([10.22.225.128]) by orsmga004.jf.intel.com with ESMTP; 15 Aug 2017 08:17:52 -0700 Received: from orsmsx112.amr.corp.intel.com (10.22.240.13) by ORSMSX101.amr.corp.intel.com (10.22.225.128) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 15 Aug 2017 08:17:52 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.211]) by ORSMSX112.amr.corp.intel.com ([169.254.3.87]) with mapi id 14.03.0319.002; Tue, 15 Aug 2017 08:17:52 -0700 From: "Kinney, Michael D" To: Laszlo Ersek , edk2-devel-01 , "Kinney, Michael D" CC: "Justen, Jordan L" , Leif Lindholm , Ard Biesheuvel Thread-Topic: [edk2] [edk2-CCodingStandardsSpecification PATCH 0/2] improvements related to line wrapping Thread-Index: AQHTEsHAJiXdbDRXfUKwEOc3bp3neqJ/YfWwgAZZjQD//9GjsA== Date: Tue, 15 Aug 2017 15:17:51 +0000 Message-ID: References: <20170811164851.9466-1-lersek@redhat.com> <20d2afa8-3bd9-8088-7248-53a656555568@redhat.com> In-Reply-To: <20d2afa8-3bd9-8088-7248-53a656555568@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Subject: Re: [edk2-CCodingStandardsSpecification PATCH 0/2] improvements related to line wrapping X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Aug 2017 15:15:28 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Laszlo, If you only change a couple of words in a sentence, it will show the differences at the work level instead of the line level. If you add/remove entire paragraphs, then you will=20 not see any differences. I am just in the habit of always adding ?w=3D1 to provide the best possible review format. I have not found a URL to auto select that view. When a=20 single patch changes several files, you get that button for each file within the patch. Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On > Behalf Of Laszlo Ersek > Sent: Tuesday, August 15, 2017 4:01 AM > To: Kinney, Michael D ; edk2-devel- > 01 > Cc: Justen, Jordan L ; Leif Lindholm > ; Ard Biesheuvel > > Subject: Re: [edk2] [edk2-CCodingStandardsSpecification PATCH > 0/2] improvements related to line wrapping >=20 > Mike, >=20 > On 08/11/17 19:07, Kinney, Michael D wrote: > > Laszlo, > > > > You can also provide links to the GitHub commits with "?w=3D1" > > flag appended. If you select the "Display the rich diff" > button > > above each changed file, GitHub renders a view with change > bars. > > > > https://github.com/lersek/edk2- > CCodingStandardsSpecification/commit/2c5534a24b15616fdaa02478858 > ed1d8908dc653?w=3D1 >=20 > I opened two browser tabs with this link, one without "?w=3D1" and > another > with "?w=3D1", and compared the contents visually (by switching > back and > forth between the tabs), checking each screen-ful. I'm not > seeing any > differences. >=20 > When I click the button that you mention, I do get a rendered > diff as > well. I wonder if this feature is javascript-only, or if it can > be > triggered with URL changes. >=20 > Thanks > Laszlo >=20 > > > > https://github.com/lersek/edk2- > CCodingStandardsSpecification/commit/e3797dc48316052005cefa26246 > ab2fd32641881?w=3D1 > > > > Best regards, > > > > Mike > > > >> -----Original Message----- > >> From: Laszlo Ersek [mailto:lersek@redhat.com] > >> Sent: Friday, August 11, 2017 9:49 AM > >> To: edk2-devel-01 > >> Cc: Ard Biesheuvel ; Justen, > Jordan L > >> ; Leif Lindholm > >> ; Kinney, Michael D > >> > >> Subject: [edk2-CCodingStandardsSpecification PATCH 0/2] > >> improvements related to line wrapping > >> > >> We've discussed these ideas repeatedly over time; I'm now > >> attempting to > >> formalize them. Also test-driving the documentation > contribution > >> process. > >> > >> - Repo: https://github.com/lersek/edk2- > >> CCodingStandardsSpecification.git > >> - Branch: line_wrapping > >> - Rendered views of the pages modified: > >> - https://lersek.gitbooks.io/laszlo-s-fork-of-the-edk-ii-c- > >> coding-standards-sp/content/v/line_wrapping/#edk-ii-c-coding- > >> standards-specification > >> - https://lersek.gitbooks.io/laszlo-s-fork-of-the-edk-ii-c- > >> coding-standards- > sp/content/v/line_wrapping/5_source_files/#51- > >> general-rules > >> - https://lersek.gitbooks.io/laszlo-s-fork-of-the-edk-ii-c- > >> coding-standards- > >> sp/content/v/line_wrapping/5_source_files/52_spacing.html#52- > >> spacing > >> > >> Cc: Ard Biesheuvel > >> Cc: Jordan Justen > >> Cc: Leif Lindholm > >> Cc: Michael D Kinney > >> > >> Thanks > >> Laszlo > >> > >> Laszlo Ersek (2): > >> Source Files / General Rules: limit line lengths to 80 > columns > >> Source Files / Spacing / Multi-line func. calls: allow > >> condensed > >> arguments > >> > >> 5_source_files/52_spacing.md | 29 +++++++++++++++++++- > >> 5_source_files/README.md | 17 ++++++++---- > >> README.md | 2 ++ > >> 3 files changed, 42 insertions(+), 6 deletions(-) > >> > >> -- > >> 2.13.1.3.g8be5a757fa67 > > >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel