From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 554BA21CFA5F7 for ; Wed, 16 Aug 2017 08:56:28 -0700 (PDT) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Aug 2017 08:58:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,383,1498546800"; d="scan'208";a="1163252870" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by orsmga001.jf.intel.com with ESMTP; 16 Aug 2017 08:58:53 -0700 Received: from orsmsx116.amr.corp.intel.com (10.22.240.14) by ORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 16 Aug 2017 08:58:53 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.211]) by ORSMSX116.amr.corp.intel.com ([169.254.7.81]) with mapi id 14.03.0319.002; Wed, 16 Aug 2017 08:58:53 -0700 From: "Kinney, Michael D" To: "Dong, Eric" , "edk2-devel@lists.01.org" , "Kinney, Michael D" CC: "Ni, Ruiyu" , "Gao, Liming" Thread-Topic: [edk2] [Patch 1/2] UefiCpuPkg: Add comments for PCDs definition. Thread-Index: AQHTFM46dlWLoHrjk06PgorEwxtss6KHJYaA Date: Wed, 16 Aug 2017 15:58:52 +0000 Message-ID: References: <1502695374-11368-1-git-send-email-eric.dong@intel.com> <1502695374-11368-2-git-send-email-eric.dong@intel.com> In-Reply-To: <1502695374-11368-2-git-send-email-eric.dong@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Subject: Re: [Patch 1/2] UefiCpuPkg: Add comments for PCDs definition. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Aug 2017 15:56:28 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Eric, For the PCD PcdCpuProcTraceOutputScheme, the description of "Invalid scheme= " does not seem like a good description for disable. Do we really need the value 0x02 for PcdCpuProcTraceOutputScheme at all? Can we use PcdCpuFeaturesSetting set to 0x10 ProcTraceMemDisable to know that the feature is disabled, and only look at=20 PcdCpuProcTraceOutputScheme if PcdCpuFeaturesSetting is set to a value where the memory size is > 0? Also, when looking at where these PCD values are used in UefiCpuPkg\Library\CpuCommonFeaturesLib\ProcTrace.c, I see use of BITxx to modify the MSR_IA32_RTIT_CTL values. Please use the bit fields in the MSR_IA32_RTIT_CTL_REGISTER structure instead. You can work on this change as a separate patch. Thanks, Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On > Behalf Of Eric Dong > Sent: Monday, August 14, 2017 12:23 AM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Kinney, Michael D > ; Gao, Liming > Subject: [edk2] [Patch 1/2] UefiCpuPkg: Add comments for PCDs > definition. >=20 > Add valid/default values for PCD PcdCpuProcTraceMemSize and > PcdCpuProcTraceOutputScheme in the comment part. >=20 > Cc: Liming Gao > Cc: Ruiyu Ni > Cc: Michael D Kinney > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Eric Dong > --- > UefiCpuPkg/UefiCpuPkg.dec | 28 ++++++++++++++++++++++++++-- > 1 file changed, 26 insertions(+), 2 deletions(-) >=20 > diff --git a/UefiCpuPkg/UefiCpuPkg.dec > b/UefiCpuPkg/UefiCpuPkg.dec > index 2ddeab4..b4e099d 100644 > --- a/UefiCpuPkg/UefiCpuPkg.dec > +++ b/UefiCpuPkg/UefiCpuPkg.dec > @@ -285,12 +285,36 @@ > # @ValidList 0x80000001 | 0 > gUefiCpuPkgTokenSpaceGuid.PcdCpuFeaturesSetting|{0x00, 0x00, > 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}|VOID*|0x00000019 >=20 > - ## Contains the size of memory required when CPU processor > trace is enabled. > + ## Contains the size of memory required when CPU processor > trace is enabled.

> + # Default value is 0x10 which disables the processor > trace.
> + # 0x0 - 4K.
> + # 0x1 - 8K.
> + # 0x2 - 16K.
> + # 0x3 - 32K.
> + # 0x4 - 64K.
> + # 0x5 - 128K.
> + # 0x6 - 256K.
> + # 0x7 - 512K.
> + # 0x8 - 1M.
> + # 0x9 - 2M.
> + # 0xA - 4M.
> + # 0xB - 8M.
> + # 0xC - 16M.
> + # 0xD - 32M.
> + # 0xE - 64M.
> + # 0xF - 128M.
> + # 0x10 - ProcTraceMemDisable.
> # @Prompt The memory size used for processor trace. > + # @ValidRange 0x80000001 | 0 - 0x10 >=20 > gUefiCpuPkgTokenSpaceGuid.PcdCpuProcTraceMemSize|0x10|UINT32|0x6 > 0000012 >=20 > - ## Contains the processor trace output scheme when CPU > processor trace is enabled. > + ## Contains the processor trace output scheme when CPU > processor trace is enabled.

> + # Default value is 2 which disables the processor trace.
> + # 0 - Single Range output scheme.
> + # 1 - ToPA(Table of physical address) scheme.
> + # 2 - Invalid scheme.
> # @Prompt The processor trace output scheme. > + # @ValidRange 0x80000001 | 0 - 2 >=20 > gUefiCpuPkgTokenSpaceGuid.PcdCpuProcTraceOutputScheme|0x2|UINT8| > 0x60000015 >=20 > [UserExtensions.TianoCore."ExtraFiles"] > -- > 2.7.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel