From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2F67621E49BCA for ; Tue, 22 Aug 2017 15:24:11 -0700 (PDT) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Aug 2017 15:26:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,414,1498546800"; d="scan'208";a="893139805" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by FMSMGA003.fm.intel.com with ESMTP; 22 Aug 2017 15:26:44 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.211]) by ORSMSX109.amr.corp.intel.com ([169.254.11.206]) with mapi id 14.03.0319.002; Tue, 22 Aug 2017 15:26:43 -0700 From: "Kinney, Michael D" To: "Song, BinX" , "Yao, Jiewen" , "Kinney, Michael D" CC: "edk2-devel@lists.01.org" Thread-Topic: [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option Thread-Index: AdMaR4/UYVIifvoQTgaAWdAk42hJAQBTe1Ig Date: Tue, 22 Aug 2017 22:26:42 +0000 Message-ID: References: <559D2DF22BC9A3468B4FA1AA547F0EF10258DBE0@shsmsx102.ccr.corp.intel.com> In-Reply-To: <559D2DF22BC9A3468B4FA1AA547F0EF10258DBE0@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Subject: Re: [PATCH V2] IntelFsp2Pkg: Fix build error with WHOLEARCHIVE option X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Aug 2017 22:24:11 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Bell Song, Why is it documented as a "Dummy" function? There must be a reference to this symbol somewhere or it would not generate a link error. The implementation is an empty=20 function. Is that a better way to describe this function? Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On > Behalf Of Song, BinX > Sent: Sunday, August 20, 2017 11:35 PM > To: Yao, Jiewen > Cc: edk2-devel@lists.01.org > Subject: [edk2] [PATCH V2] IntelFsp2Pkg: Fix build error with > WHOLEARCHIVE option >=20 > V2: > - Recover TempRamInitApi API and add dummy TempRamInitApi > function to fix > build error with WHOLEARCHIVE option >=20 > V1: > - Delete useless external TempRamInitApi API to fix > /WHOLEARCHIVE build > error with VS2015 tool chain >=20 > Cc: Jiewen Yao > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Bell Song > --- > IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm | 10 ++++++++++ > IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm | 10 ++++++++++ > 2 files changed, 20 insertions(+) >=20 > diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm > b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm > index 9744e16..81b531e 100644 > --- a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm > +++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm > @@ -195,6 +195,16 @@ ASM_PFX(AsmGetPeiCoreOffset): > ret >=20 > ;-------------------------------------------------------------- > -------------- > +; TempRamInit API > +; > +; Dummy function for VS2015 WHOLEARCHIVE build option > +; > +;-------------------------------------------------------------- > -------------- > +global ASM_PFX(TempRamInitApi) > +ASM_PFX(TempRamInitApi): > + ret > + > +;-------------------------------------------------------------- > -------------- > ; Module Entrypoint API > ;-------------------------------------------------------------- > -------------- > global ASM_PFX(_ModuleEntryPoint) > diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm > b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm > index cdc1149..06a791f 100644 > --- a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm > +++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm > @@ -54,6 +54,16 @@ ASM_PFX(FspApiCommonContinue): > ret >=20 > ;-------------------------------------------------------------- > -------------- > +; TempRamInit API > +; > +; Dummy function for VS2015 WHOLEARCHIVE build option > +; > +;-------------------------------------------------------------- > -------------- > +global ASM_PFX(TempRamInitApi) > +ASM_PFX(TempRamInitApi): > + ret > + > +;-------------------------------------------------------------- > -------------- > ; Module Entrypoint API > ;-------------------------------------------------------------- > -------------- > global ASM_PFX(_ModuleEntryPoint) > -- > 2.10.2.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel