From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B606F21E47D65 for ; Wed, 23 Aug 2017 14:57:48 -0700 (PDT) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Aug 2017 15:00:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,417,1498546800"; d="scan'208";a="143234763" Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132]) by fmsmga005.fm.intel.com with ESMTP; 23 Aug 2017 15:00:22 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.211]) by ORSMSX105.amr.corp.intel.com ([169.254.2.21]) with mapi id 14.03.0319.002; Wed, 23 Aug 2017 15:00:22 -0700 From: "Kinney, Michael D" To: "Dong, Eric" , "edk2-devel@lists.01.org" , "Kinney, Michael D" CC: "Ni, Ruiyu" Thread-Topic: [Patch 2/2] UefiCpuPkg: Update default for PcdCpuProcTraceMemSize/PcdCpuProcTraceOutputScheme. Thread-Index: AQHTG7fsJ8QnJVymV0SfgSYZ9ETJV6KSfMxw Date: Wed, 23 Aug 2017 22:00:21 +0000 Message-ID: References: <1503455473-14360-1-git-send-email-eric.dong@intel.com> <1503455473-14360-3-git-send-email-eric.dong@intel.com> In-Reply-To: <1503455473-14360-3-git-send-email-eric.dong@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Subject: Re: [Patch 2/2] UefiCpuPkg: Update default for PcdCpuProcTraceMemSize/PcdCpuProcTraceOutputScheme. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Aug 2017 21:57:48 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Eric, Some Comments embedded below. =20 Please make sure the UNI file is updated to match the DEC file. For the enum PROC_TRACE_MEM_SIZE, I would prefer the enum values have more than just "Enum" in the beginning. It would be better to use names like "ProcTraceMemSize" so the first enum value would be "ProcTraceMemSize4KB". Same for PROC_TRACE_OUTPUT_SCHEME. Use "ProcTraceOutputScheme". Thanks, Mike > -----Original Message----- > From: Dong, Eric > Sent: Tuesday, August 22, 2017 7:31 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Ni, Ruiyu > > Subject: [Patch 2/2] UefiCpuPkg: Update default for > PcdCpuProcTraceMemSize/PcdCpuProcTraceOutputScheme. >=20 > These two definitions have redundant definition which can be > handle by code. > This patch update them to follow new code definitions. >=20 > Cc: Michael Kinney > Cc: Ruiyu Ni > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Eric Dong > --- > UefiCpuPkg/UefiCpuPkg.dec | 14 ++++++-------- > UefiCpuPkg/UefiCpuPkg.uni | 8 +++----- > 2 files changed, 9 insertions(+), 13 deletions(-) >=20 > diff --git a/UefiCpuPkg/UefiCpuPkg.dec > b/UefiCpuPkg/UefiCpuPkg.dec > index b4e099d..51ae0e2 100644 > --- a/UefiCpuPkg/UefiCpuPkg.dec > +++ b/UefiCpuPkg/UefiCpuPkg.dec > @@ -286,7 +286,7 @@ > gUefiCpuPkgTokenSpaceGuid.PcdCpuFeaturesSetting|{0x00, 0x00, > 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}|VOID*|0x00000019 >=20 > ## Contains the size of memory required when CPU processor > trace is enabled.

Add a reference to the PCD and bit that enables/disables CPU=20 Processor trace and describe that this PCD is ignored if CPU processor trace is disabled. > - # Default value is 0x10 which disables the processor > trace.
> + # Default value is 0x0 which use 4K memory size.
"Default value is 0x00 which means 4KB of memory is allocated if CPU proces= sor trace is enabled." > # 0x0 - 4K.
> # 0x1 - 8K.
> # 0x2 - 16K.
> @@ -303,19 +303,17 @@ > # 0xD - 32M.
> # 0xE - 64M.
> # 0xF - 128M.
> - # 0x10 - ProcTraceMemDisable.
> # @Prompt The memory size used for processor trace. > - # @ValidRange 0x80000001 | 0 - 0x10 > - > gUefiCpuPkgTokenSpaceGuid.PcdCpuProcTraceMemSize|0x10|UINT32|0x > 60000012 > + # @ValidRange 0x80000001 | 0 - 0xF > + > gUefiCpuPkgTokenSpaceGuid.PcdCpuProcTraceMemSize|0x0|UINT32|0x6 > 0000012 >=20 > ## Contains the processor trace output scheme when CPU > processor trace is enabled.

Add a reference to the PCD and bit that enables/disable CPU=20 Processor trace and describe that this PCD is ignored if CPU processor trace is disabled. > - # Default value is 2 which disables the processor > trace.
> + # Default value is 1 which use single range output > scheme.
The default value in the statement below is 0, not 1. The UNI file looks correct. > # 0 - Single Range output scheme.
> # 1 - ToPA(Table of physical address) scheme.
> - # 2 - Invalid scheme.
> # @Prompt The processor trace output scheme. > - # @ValidRange 0x80000001 | 0 - 2 > - > gUefiCpuPkgTokenSpaceGuid.PcdCpuProcTraceOutputScheme|0x2|UINT8 > |0x60000015 > + # @ValidRange 0x80000001 | 0 - 1 > + > gUefiCpuPkgTokenSpaceGuid.PcdCpuProcTraceOutputScheme|0x0|UINT8 > |0x60000015 >=20 > [UserExtensions.TianoCore."ExtraFiles"] > UefiCpuPkgExtra.uni > diff --git a/UefiCpuPkg/UefiCpuPkg.uni > b/UefiCpuPkg/UefiCpuPkg.uni > index 858e4a7..f3be041 100644 > --- a/UefiCpuPkg/UefiCpuPkg.uni > +++ b/UefiCpuPkg/UefiCpuPkg.uni > @@ -198,7 +198,7 @@ > #string > STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuProcTraceMemSize_PROMPT > #language en-US "Memory size used by Processor Trace feature." >=20 > #string > STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuProcTraceMemSize_HELP > #language en-US "User input the memory size can be used by > processor trace feature.

\n" > - > "Default value is 0x10 which disables the processor memory > trace.
\n" > + > "Default value is 0x0 which use 4K memory size.
\n" >=20 > "0x0 - 4K.
\n" >=20 > "0x1 - 8K.
\n" >=20 > "0x2 - 16K.
\n" > @@ -215,12 +215,10 @@ >=20 > "0xD - 32M.
\n" >=20 > "0xE - 64M.
\n" >=20 > "0xF - 128M.
\n" > - > "0x10 - ProcTraceMemDisable.
\n" >=20 > #string > STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuProcTraceOutputScheme_PROMP > T #language en-US "Processor Trace output scheme type." >=20 > #string > STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuProcTraceOutputScheme_HELP > #language en-US "User input the processor trace output scheme > type.

\n" > - > "Default value is 2 which disables the processor memory > trace.
\n" >=20 > + > "Default value is 0 which use single range output > scheme.
\n" >=20 >=20 > "0 - Single Range output scheme.
\n" >=20 > - > "1 - ToPA(Table of physical address) scheme.
\n" >=20 > - > "2 - Invalid scheme.
\n" > \ No newline at end of file > + > "1 - ToPA(Table of physical address) scheme.
\n" > \ No newline at end of file > -- > 2.7.0.windows.1