From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2C16821E2BE5C for ; Tue, 29 Aug 2017 08:44:31 -0700 (PDT) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP; 29 Aug 2017 08:47:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,445,1498546800"; d="scan'208";a="123695519" Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by orsmga004.jf.intel.com with ESMTP; 29 Aug 2017 08:47:12 -0700 Received: from orsmsx160.amr.corp.intel.com (10.22.226.43) by ORSMSX102.amr.corp.intel.com (10.22.225.129) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 29 Aug 2017 08:47:11 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.25]) by ORSMSX160.amr.corp.intel.com ([169.254.13.154]) with mapi id 14.03.0319.002; Tue, 29 Aug 2017 08:47:10 -0700 From: "Kinney, Michael D" To: "Gao, Liming" , Ard Biesheuvel , "Kinney, Michael D" CC: "edk2-devel@lists.01.org" , Laszlo Ersek Thread-Topic: [edk2] [Patch] BaseTools: Enable --whole-archive in GCC tool chain as the default option Thread-Index: AQHTHKJ6lq01QdLQBUO7CFcdsmZDdKKVVfSAgAAAjgCAABWqAIAEKyaAgADisQCAAPZxgIAAEfIg Date: Tue, 29 Aug 2017 15:47:10 +0000 Message-ID: References: <1503556125-7024-1-git-send-email-liming.gao@intel.com> <2cf820ad-4a6d-648e-560b-d223bef9b45d@redhat.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14D78139F@shsmsx102.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14D783F16@shsmsx102.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14D783F16@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Subject: Re: [Patch] BaseTools: Enable --whole-archive in GCC tool chain as the default option X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Aug 2017 15:44:31 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Ard, If there is a concern about the size impact, we can add an extra Link step that uses --whole-archive to check for duplicate symbols, but the link step used to generate final image would not use --whole-archive. Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On > Behalf Of Gao, Liming > Sent: Tuesday, August 29, 2017 12:41 AM > To: Ard Biesheuvel > Cc: edk2-devel@lists.01.org; Laszlo Ersek > Subject: Re: [edk2] [Patch] BaseTools: Enable --whole-archive > in GCC tool chain as the default option >=20 > Ard: > This is the compiler check option, not debug option. I > suggest to add it for all configuration. >=20 > Thanks > Liming > >-----Original Message----- > >From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > >Sent: Tuesday, August 29, 2017 12:59 AM > >To: Gao, Liming > >Cc: Laszlo Ersek ; edk2-devel@lists.01.org > >Subject: Re: [edk2] [Patch] BaseTools: Enable --whole-archive > in GCC tool > >chain as the default option > > > >On 28 August 2017 at 04:27, Gao, Liming > wrote: > >> Laszlo: > >> I will update the patch with your comments. > >> > >> Ard: > >> We collect the size impact in Ovmf platform. Its impact is > small. So, my > >patch enable this option for all targets. Below is the data > collected on > >OvmfIa32X64.dsc with GCC5 tool chain. Raw image is a little > bigger. But, the > >compressed size is a little smaller. > >> > >> PEIFV 178472 --> 179176 +704 (Bytes) > >> DXEFV 4062512 --> 4075056 +12544 (Bytes) > >> FVMAIN_COMPACT 1190896 --> 1184920 -5976 (Bytes) > >> > > > >I don't care deeply, but given that --whole-archive is used as > a debug > >feature (we don't actually need the whole archive, but we want > to > >force a linker error if duplicate symbols exist), I don't > think it > >belongs in the RELEASE configuration. > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel