From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=michael.d.kinney@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 876EA21B00DC9 for ; Wed, 8 Nov 2017 08:25:18 -0800 (PST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP; 08 Nov 2017 08:29:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,364,1505804400"; d="scan'208";a="2516671" Received: from orsmsx103.amr.corp.intel.com ([10.22.225.130]) by orsmga001.jf.intel.com with ESMTP; 08 Nov 2017 08:29:18 -0800 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.80]) by ORSMSX103.amr.corp.intel.com ([169.254.5.89]) with mapi id 14.03.0319.002; Wed, 8 Nov 2017 08:29:17 -0800 From: "Kinney, Michael D" To: "Ni, Ruiyu" , "edk2-devel@lists.01.org" , "Kinney, Michael D" CC: "Dong, Eric" , "Zeng, Star" Thread-Topic: [edk2] [Patch] MdeModulePkg/TerminalDxe: Fix PCANSI mapping for TRIANGLE and ARROW Thread-Index: AQHTWEliO3WH74bpKkWzcLgSy1fzSKMKoSSAgAALOIA= Date: Wed, 8 Nov 2017 16:29:15 +0000 Message-ID: References: <20171108042341.16684-1-michael.d.kinney@intel.com> <734D49CCEBEEF84792F5B80ED585239D5BAB6C7F@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5BAB6C7F@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Subject: Re: [Patch] MdeModulePkg/TerminalDxe: Fix PCANSI mapping for TRIANGLE and ARROW X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Nov 2017 16:25:18 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable When DOS uses CodePage 437, 18 is an up arrow glyph. A PC ANSI terminal interprets 18 as a control character. Mike > -----Original Message----- > From: Ni, Ruiyu > Sent: Tuesday, November 7, 2017 11:47 PM > To: Kinney, Michael D ; > edk2-devel@lists.01.org > Cc: Dong, Eric ; Zeng, Star > > Subject: RE: [edk2] [Patch] MdeModulePkg/TerminalDxe: > Fix PCANSI mapping for TRIANGLE and ARROW >=20 > Mike, > I am a bit confused about mapping 0x18 to upper arrow. > I remembered that in old days, pressing ALT+18 in DOS > window can generate upper arrow. >=20 > Thanks/Ray >=20 > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel- > bounces@lists.01.org] On Behalf Of > > Michael D Kinney > > Sent: Wednesday, November 8, 2017 12:24 PM > > To: edk2-devel@lists.01.org > > Cc: Dong, Eric ; Zeng, Star > > > Subject: [edk2] [Patch] MdeModulePkg/TerminalDxe: Fix > PCANSI mapping > > for TRIANGLE and ARROW > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D761 > > > > When a TerminalType is set to PCANSI, characters in > the range 0x00 to 0x1F > > are control characters. The mapping table for PCANSI > maps TRIANGLE glyphs, > > ARROW_UP glyph, and ARROW_DOWN glyph into this > control character > > range and that causes no characters to be displayed > by PCANSI compatible > > terminal emulators. > > > > The mappings are updated so these glyphs are mapped > to ANSI characters in > > the range 0x20 to 0x7E. > > > > GEOMETRICSHAPE_UP_TRIANGLE '^' > > GEOMETRICSHAPE_RIGHT_TRIANGLE '>' > > GEOMETRICSHAPE_DOWN_TRIANGLE 'v' > > GEOMETRICSHAPE_LEFT_TRIANGLE '<' > > ARROW_UP '^' > > ARROW_DOWN 'v' > > > > Cc: Star Zeng > > Cc: Eric Dong > > Contributed-under: TianoCore Contribution Agreement > 1.1 > > Signed-off-by: Michael D Kinney > > > --- > > .../Universal/Console/TerminalDxe/TerminalConOut.c > | 18 +++++++++---- > > ----- > > 1 file changed, 9 insertions(+), 9 deletions(-) > > > > diff --git > > > a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalCo > nOut.c > > > b/MdeModulePkg/Universal/Console/TerminalDxe/TerminalCo > nOut.c > > index e677a76e6b..5a8343162f 100644 > > --- > a/MdeModulePkg/Universal/Console/TerminalDxe/TerminalCo > nOut.c > > +++ > b/MdeModulePkg/Universal/Console/TerminalDxe/TerminalCo > nOut.c > > @@ -66,15 +66,15 @@ UNICODE_TO_CHAR > UnicodeToPcAnsiOrAscii[] =3D { > > { BLOCKELEMENT_FULL_BLOCK, 0xdb, L'*' > }, > > { BLOCKELEMENT_LIGHT_SHADE, 0xb0, L'+' > }, > > > > - { GEOMETRICSHAPE_UP_TRIANGLE, 0x1e, L'^' > }, > > - { GEOMETRICSHAPE_RIGHT_TRIANGLE, 0x10, L'>' > }, > > - { GEOMETRICSHAPE_DOWN_TRIANGLE, 0x1f, L'v' > }, > > - { GEOMETRICSHAPE_LEFT_TRIANGLE, 0x11, L'<' > }, > > - > > - { ARROW_LEFT, 0x3c, L'<' > }, > > - { ARROW_UP, 0x18, L'^' > }, > > - { ARROW_RIGHT, 0x3e, L'>' > }, > > - { ARROW_DOWN, 0x19, L'v' > }, > > + { GEOMETRICSHAPE_UP_TRIANGLE, '^', L'^' }, > > + { GEOMETRICSHAPE_RIGHT_TRIANGLE, '>', L'>' }, > > + { GEOMETRICSHAPE_DOWN_TRIANGLE, 'v', L'v' }, > > + { GEOMETRICSHAPE_LEFT_TRIANGLE, '<', L'<' }, > > + > > + { ARROW_LEFT, '<', L'<' }, > > + { ARROW_UP, '^', L'^' }, > > + { ARROW_RIGHT, '>', L'>' }, > > + { ARROW_DOWN, 'v', L'v' }, > > > > { 0x0000, 0x00, L'\0' > } > > }; > > -- > > 2.14.2.windows.3 > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel