From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Permerror (SPF Permanent Error: More than 10 MX records returned) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=michael.d.kinney@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 49C90221EA0A5 for ; Thu, 7 Dec 2017 08:57:20 -0800 (PST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Dec 2017 09:01:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,373,1508828400"; d="scan'208";a="14000465" Received: from orsmsx101.amr.corp.intel.com ([10.22.225.128]) by orsmga001.jf.intel.com with ESMTP; 07 Dec 2017 09:01:52 -0800 Received: from orsmsx158.amr.corp.intel.com (10.22.240.20) by ORSMSX101.amr.corp.intel.com (10.22.225.128) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 7 Dec 2017 09:01:52 -0800 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.187]) by ORSMSX158.amr.corp.intel.com ([169.254.10.25]) with mapi id 14.03.0319.002; Thu, 7 Dec 2017 09:01:51 -0800 From: "Kinney, Michael D" To: Ard Biesheuvel , "edk2-devel@lists.01.org" , "Kinney, Michael D" CC: Leif Lindholm , "Gao, Liming" , Evan Lloyd , Alexei Fedorov Thread-Topic: [PATCH] MdePkg/DebugLib; swap if conditions in ASSERT_[EFI|RETURN]_ERROR Thread-Index: AQHTb23ut8WaJ0TL/kqjkH352S+EyKM4hrqA//+TugA= Date: Thu, 7 Dec 2017 17:01:51 +0000 Message-ID: References: <20171207151208.25648-1-ard.biesheuvel@linaro.org> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjkxYjZkMGEtZDZmMy00ODJjLWI2NGMtNzY4NGU1M2ZjNTc4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJ5QkdOQXcwalpyZVo0cldMc2xhbTJ4VktqdVRreTMxYmdyR0RJdnJ0cmdFeEI5U041MkpDUE14aDN3M0tQekhIIn0= dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Subject: Re: [PATCH] MdePkg/DebugLib; swap if conditions in ASSERT_[EFI|RETURN]_ERROR X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Dec 2017 16:57:20 -0000 Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 QXJkLA0KDQpUaGUgcmVhc29uIGZvciB0aGUgY3VycmVudCBvcmRlcmluZyBpcyBmb3Igc2l6ZSBv cHRpbWl6YXRpb24uDQoNClRoZSBtb3N0IGNvbW1vbiBpbXBsZW1lbnRhdGlvbiBvZiBEZWJ1Z0Fz c2VydEVuYWJsZWQoKSB1c2VzDQphIEZpeGVkQXRCdWlsZCBQQ0QgdG8gZGV0ZXJtaW5lIGlmIHRo ZXNlIGFyZSBlbmFibGVkLiAgVGhlIA0KY2hlY2sgb2Ygc3RhdHVzIGNhbiBiZSBvcHRpbWl6ZWQg YXdheSBpZiB0aGV5IGFyZSBkaXNhYmxlZC4NCklmIHlvdSByZXZlcnNlIHRoZW0sIHRoZW4gdGhl IHN0YXR1cyBjaGVjayBpcyBhbHdheXMgcGVyZm9ybWVkLg0KDQpNaWtlDQoNCj4gLS0tLS1Pcmln aW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogQXJkIEJpZXNoZXV2ZWwgW21haWx0bzphcmQuYmll c2hldXZlbEBsaW5hcm8ub3JnXQ0KPiBTZW50OiBUaHVyc2RheSwgRGVjZW1iZXIgNywgMjAxNyA3 OjI2IEFNDQo+IFRvOiBlZGsyLWRldmVsQGxpc3RzLjAxLm9yZw0KPiBDYzogTGVpZiBMaW5kaG9s bSA8bGVpZi5saW5kaG9sbUBsaW5hcm8ub3JnPjsgR2FvLCBMaW1pbmcNCj4gPGxpbWluZy5nYW9A aW50ZWwuY29tPjsgRXZhbiBMbG95ZCA8ZXZhbi5sbG95ZEBhcm0uY29tPjsNCj4gS2lubmV5LCBN aWNoYWVsIEQgPG1pY2hhZWwuZC5raW5uZXlAaW50ZWwuY29tPjsgQWxleGVpDQo+IEZlZG9yb3Yg PEFsZXhlaS5GZWRvcm92QGFybS5jb20+OyBBcmQgQmllc2hldXZlbA0KPiA8YXJkLmJpZXNoZXV2 ZWxAbGluYXJvLm9yZz4NCj4gU3ViamVjdDogUmU6IFtQQVRDSF0gTWRlUGtnL0RlYnVnTGliOyBz d2FwIGlmIGNvbmRpdGlvbnMNCj4gaW4gQVNTRVJUX1tFRkl8UkVUVVJOXV9FUlJPUg0KPiANCj4g T24gNyBEZWNlbWJlciAyMDE3IGF0IDE1OjEyLCBBcmQgQmllc2hldXZlbA0KPiA8YXJkLmJpZXNo ZXV2ZWxAbGluYXJvLm9yZz4gd3JvdGU6DQo+ID4gQVNTRVJUX0VGSV9FUlJPUiAoKSBpcyBjdXJy ZW50bHkgZGVmaW5lZCBhcw0KPiA+DQo+ID4gICAjaWYgIWRlZmluZWQoTURFUEtHX05ERUJVRykN Cj4gPiAgICAgI2RlZmluZSBBU1NFUlRfRUZJX0VSUk9SKFN0YXR1c1BhcmFtZXRlcikNCj4gXA0K PiA+ICAgICAgIGRvIHsNCj4gXA0KPiA+ICAgICAgICAgaWYgKERlYnVnQXNzZXJ0RW5hYmxlZCAo KSkgew0KPiBcDQo+ID4gICAgICAgICAgIGlmIChFRklfRVJST1IgKFN0YXR1c1BhcmFtZXRlcikp IHsNCj4gXA0KPiA+ICAgICAgICAgICAgIERFQlVHICgoRUZJX0RfRVJST1IsICJcbkFTU0VSVF9F RklfRVJST1INCj4gKFN0YXR1cyA9ICVyKVxuIiwgU3RhdHVzUGFyYW1ldGVyKSk7ICBcDQo+ID4g ICAgICAgICAgICAgX0FTU0VSVCAoIUVGSV9FUlJPUiAoU3RhdHVzUGFyYW1ldGVyKSk7DQo+IFwN Cj4gPiAgICAgICAgICAgfQ0KPiBcDQo+ID4gICAgICAgICB9DQo+IFwNCj4gPiAgICAgICB9IHdo aWxlIChGQUxTRSkNCj4gPiAgICNlbHNlDQo+ID4gICAgICNkZWZpbmUgQVNTRVJUX0VGSV9FUlJP UihTdGF0dXNQYXJhbWV0ZXIpDQo+ID4gICAjZW5kaWYNCj4gPg0KPiA+IFRoaXMgaXMgc3Vib3B0 aW1hbCwgZ2l2ZW4gdGhhdCB0aGUgRGVidWdBc3NlcnRFbmFibGVkDQo+ICgpIGNhbGwgaW4gdGhl DQo+ID4gb3V0ZXIgaWYgbXVzdCBiZSBleGVjdXRlZCB1bmNvbmRpdGlvbmFsbHksIHNpbmNlIHRo ZQ0KPiBjb21waWxlciBkb2VzIG5vdA0KPiA+IGtub3cgdGhhdCBpdCBkb2VzIG5vdCBoYXZlIGFu eSBzaWRlIGVmZmVjdHMuIEluc3RlYWQsDQo+IGxldCdzIHN3YXAgdGhlDQo+ID4gdHdvIGlmcywg YW5kIG9ubHkgY2FsbCBEZWJ1Z0Fzc2VydEVuYWJsZWQgKCkgaWYNCj4gU3RhdHVzUGFyYW1ldGVy IGNvbnRhaW5zDQo+ID4gYW4gZXJyb3IgdmFsdWUgdG8gYmVnaW4gd2l0aC4gRG8gdGhlIHNhbWUg Zm9yDQo+IEFTU0VSVF9SRVRVUk5fRVJST1INCj4gPiBhcyB3ZWxsLg0KPiA+DQo+IA0KPiBJIGp1 c3Qgbm90aWNlZCB3ZSBjb3VsZCBkbyB0aGUgc2FtZSBmb3IgQVNTRVJUICgpIGFzDQo+IHdlbGwu DQo+IA0KPiA+IENvbnRyaWJ1dGVkLXVuZGVyOiBUaWFub0NvcmUgQ29udHJpYnV0aW9uIEFncmVl bWVudCAxLjENCj4gPiBTaWduZWQtb2ZmLWJ5OiBBcmQgQmllc2hldXZlbA0KPiA8YXJkLmJpZXNo ZXV2ZWxAbGluYXJvLm9yZz4NCj4gPiBSZXBvcnRlZC1ieTogQWxleGVpIEZlZG9yb3YgPEFsZXhl aS5GZWRvcm92QGFybS5jb20+DQo+ID4gLS0tDQo+ID4gIE1kZVBrZy9JbmNsdWRlL0xpYnJhcnkv RGVidWdMaWIuaCB8IDggKysrKy0tLS0NCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9u cygrKSwgNCBkZWxldGlvbnMoLSkNCj4gPg0KPiA+IGRpZmYgLS1naXQgYS9NZGVQa2cvSW5jbHVk ZS9MaWJyYXJ5L0RlYnVnTGliLmgNCj4gYi9NZGVQa2cvSW5jbHVkZS9MaWJyYXJ5L0RlYnVnTGli LmgNCj4gPiBpbmRleCAzYTkxMGU2YTIwOGIuLjgzNjljMzc4ZTc5YyAxMDA2NDQNCj4gPiAtLS0g YS9NZGVQa2cvSW5jbHVkZS9MaWJyYXJ5L0RlYnVnTGliLmgNCj4gPiArKysgYi9NZGVQa2cvSW5j bHVkZS9MaWJyYXJ5L0RlYnVnTGliLmgNCj4gPiBAQCAtMzM3LDggKzMzNyw4IEBAIERlYnVnUHJp bnRMZXZlbEVuYWJsZWQgKA0KPiA+ICAjaWYgIWRlZmluZWQoTURFUEtHX05ERUJVRykNCj4gPiAg ICAjZGVmaW5lIEFTU0VSVF9FRklfRVJST1IoU3RhdHVzUGFyYW1ldGVyKQ0KPiBcDQo+ID4gICAg ICBkbyB7DQo+IFwNCj4gPiAtICAgICAgaWYgKERlYnVnQXNzZXJ0RW5hYmxlZCAoKSkgew0KPiBc DQo+ID4gLSAgICAgICAgaWYgKEVGSV9FUlJPUiAoU3RhdHVzUGFyYW1ldGVyKSkgew0KPiBcDQo+ ID4gKyAgICAgIGlmIChFRklfRVJST1IgKFN0YXR1c1BhcmFtZXRlcikpIHsNCj4gXA0KPiA+ICsg ICAgICAgIGlmIChEZWJ1Z0Fzc2VydEVuYWJsZWQgKCkpIHsNCj4gXA0KPiA+ICAgICAgICAgICAg REVCVUcgKChFRklfRF9FUlJPUiwgIlxuQVNTRVJUX0VGSV9FUlJPUg0KPiAoU3RhdHVzID0gJXIp XG4iLCBTdGF0dXNQYXJhbWV0ZXIpKTsgIFwNCj4gPiAgICAgICAgICAgIF9BU1NFUlQgKCFFRklf RVJST1IgKFN0YXR1c1BhcmFtZXRlcikpOw0KPiBcDQo+ID4gICAgICAgICAgfQ0KPiBcDQo+ID4g QEAgLTM2Myw4ICszNjMsOCBAQCBEZWJ1Z1ByaW50TGV2ZWxFbmFibGVkICgNCj4gPiAgI2lmICFk ZWZpbmVkKE1ERVBLR19OREVCVUcpDQo+ID4gICAgI2RlZmluZSBBU1NFUlRfUkVUVVJOX0VSUk9S KFN0YXR1c1BhcmFtZXRlcikNCj4gXA0KPiA+ICAgICAgZG8gew0KPiBcDQo+ID4gLSAgICAgIGlm IChEZWJ1Z0Fzc2VydEVuYWJsZWQgKCkpIHsNCj4gXA0KPiA+IC0gICAgICAgIGlmIChSRVRVUk5f RVJST1IgKFN0YXR1c1BhcmFtZXRlcikpIHsNCj4gXA0KPiA+ICsgICAgICBpZiAoUkVUVVJOX0VS Uk9SIChTdGF0dXNQYXJhbWV0ZXIpKSB7DQo+IFwNCj4gPiArICAgICAgICBpZiAoRGVidWdBc3Nl cnRFbmFibGVkICgpKSB7DQo+IFwNCj4gPiAgICAgICAgICAgIERFQlVHICgoREVCVUdfRVJST1Is ICJcbkFTU0VSVF9SRVRVUk5fRVJST1INCj4gKFN0YXR1cyA9ICVyKVxuIiwgXA0KPiA+ICAgICAg ICAgICAgICBTdGF0dXNQYXJhbWV0ZXIpKTsNCj4gXA0KPiA+ICAgICAgICAgICAgX0FTU0VSVCAo IVJFVFVSTl9FUlJPUiAoU3RhdHVzUGFyYW1ldGVyKSk7DQo+IFwNCj4gPiAtLQ0KPiA+IDIuMTEu MA0KPiA+DQo=