From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=michael.d.kinney@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8C21222225C11 for ; Fri, 22 Dec 2017 09:50:25 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Dec 2017 09:55:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,441,1508828400"; d="scan'208";a="189324441" Received: from orsmsx103.amr.corp.intel.com ([10.22.225.130]) by fmsmga006.fm.intel.com with ESMTP; 22 Dec 2017 09:55:14 -0800 Received: from orsmsx114.amr.corp.intel.com (10.22.240.10) by ORSMSX103.amr.corp.intel.com (10.22.225.130) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 22 Dec 2017 09:55:14 -0800 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.187]) by ORSMSX114.amr.corp.intel.com ([169.254.8.57]) with mapi id 14.03.0319.002; Fri, 22 Dec 2017 09:55:14 -0800 From: "Kinney, Michael D" To: M1cha , "edk2-devel@lists.01.org" , "Kinney, Michael D" CC: Ard Biesheuvel , "Gao, Liming" Thread-Topic: [edk2] [PATCH 0/3] fix GCC optimizations and warnings for SetJump/LongJump Thread-Index: AQHTevXfB8QKAA5Vj0eRpnenUBQafKNPpcvA Date: Fri, 22 Dec 2017 17:55:13 +0000 Message-ID: References: <20171222072336.23504-1-sigmaepsilon92@gmail.com> In-Reply-To: <20171222072336.23504-1-sigmaepsilon92@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Subject: Re: [PATCH 0/3] fix GCC optimizations and warnings for SetJump/LongJump X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Dec 2017 17:50:25 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I see the .h file updates here. I think the C files in MdePkg/Library/BaseLib also need to be updated for this patch series to be complete. Thanks, Mike > -----Original Message----- > From: M1cha [mailto:sigmaepsilon92@gmail.com] > Sent: Thursday, December 21, 2017 11:24 PM > To: edk2-devel@lists.01.org > Cc: Ard Biesheuvel ; Kinney, > Michael D ; Gao, Liming > > Subject: [edk2] [PATCH 0/3] fix GCC optimizations and > warnings for SetJump/LongJump >=20 > I've already discussed this in past but never actually > sent proper > patches for some reason. >=20 > This patch series is about fixing problems with these > functions when > using GCC. >=20 > M1cha (3): > MdePkg: add RETURNS_TWICE attribute > MdePkg/BaseLib: add attribute 'RETURNS_TWICE' to > SetJump > MdePkg: add NORETURN attribute to LongJump and > InternalLongJump >=20 > MdePkg/Include/Base.h | 10 > ++++++++++ > MdePkg/Include/Library/BaseLib.h | 2 ++ > MdePkg/Library/BaseLib/BaseLibInternals.h | 1 + > 3 files changed, 13 insertions(+) >=20 > -- > 2.15.1