Re: [PATCH 0/4] Coding style clean-up

["Kinney, Michael D" <michael.d.kinney@intel.com>]

Jian,

I do not think this change should be made.

One of the exceptions for not following the
EDK II code style is if the field names are
defined in a public specification.  In this case
these fields are all listed in a structure in 
the Intel 64 and IA-32 Architectures Software
Development Manual, Section 7.2.1, Figure 7-2
using upper case register names.

Thanks,

Mike



> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org]
> On Behalf Of Jian J Wang
> Sent: Sunday, December 24, 2017 5:07 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH 0/4] Coding style clean-up
> 
> This patch series are meant for cleaning up code
> according to coding style
> requirements.
> 
> Jian J Wang (4):
>   MdePkg/BaseLib.h: Coding style clean-up
>   MdeModulePkg/Core: Coding style clean-up
>   UefiCpuPkg/UefiCpuPkg.uni: Add missing string
> definition for new PCDs
>   UefiCpuPkg: Update code to use new structure field
> names
> 
>  MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c   |  5
> ++
>  MdePkg/Include/Library/BaseLib.h                   | 72
> +++++++++++-----------
>  .../Ia32/ArchExceptionHandler.c                    | 24
> ++++----
>  .../X64/ArchExceptionHandler.c                     |  6
> +-
>  UefiCpuPkg/Library/MpInitLib/MpLib.c               |  2
> +-
>  UefiCpuPkg/UefiCpuPkg.uni                          | 16
> ++++-
>  6 files changed, 71 insertions(+), 54 deletions(-)
> 
> --
> 2.15.1.windows.2
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel