From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=michael.d.kinney@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 32E492034B411 for ; Tue, 26 Dec 2017 08:43:02 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Dec 2017 08:47:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,460,1508828400"; d="scan'208";a="189912746" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by fmsmga005.fm.intel.com with ESMTP; 26 Dec 2017 08:47:56 -0800 Received: from orsmsx159.amr.corp.intel.com (10.22.240.24) by ORSMSX109.amr.corp.intel.com (10.22.240.7) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 26 Dec 2017 08:47:55 -0800 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.187]) by ORSMSX159.amr.corp.intel.com ([169.254.11.33]) with mapi id 14.03.0319.002; Tue, 26 Dec 2017 08:47:55 -0800 From: "Kinney, Michael D" To: "Wang, Jian J" , "edk2-devel@lists.01.org" , "Kinney, Michael D" Thread-Topic: [edk2] [PATCH 0/4] Coding style clean-up Thread-Index: AQHTfRy55dCY3iU3mEGHA4UYM/R2yKNV1T5w Date: Tue, 26 Dec 2017 16:47:54 +0000 Message-ID: References: <20171225010659.13428-1-jian.j.wang@intel.com> In-Reply-To: <20171225010659.13428-1-jian.j.wang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Subject: Re: [PATCH 0/4] Coding style clean-up X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Dec 2017 16:43:02 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Jian, I do not think this change should be made. One of the exceptions for not following the EDK II code style is if the field names are defined in a public specification. In this case these fields are all listed in a structure in=20 the Intel 64 and IA-32 Architectures Software Development Manual, Section 7.2.1, Figure 7-2 using upper case register names. Thanks, Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] > On Behalf Of Jian J Wang > Sent: Sunday, December 24, 2017 5:07 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH 0/4] Coding style clean-up >=20 > This patch series are meant for cleaning up code > according to coding style > requirements. >=20 > Jian J Wang (4): > MdePkg/BaseLib.h: Coding style clean-up > MdeModulePkg/Core: Coding style clean-up > UefiCpuPkg/UefiCpuPkg.uni: Add missing string > definition for new PCDs > UefiCpuPkg: Update code to use new structure field > names >=20 > MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c | 5 > ++ > MdePkg/Include/Library/BaseLib.h | 72 > +++++++++++----------- > .../Ia32/ArchExceptionHandler.c | 24 > ++++---- > .../X64/ArchExceptionHandler.c | 6 > +- > UefiCpuPkg/Library/MpInitLib/MpLib.c | 2 > +- > UefiCpuPkg/UefiCpuPkg.uni | 16 > ++++- > 6 files changed, 71 insertions(+), 54 deletions(-) >=20 > -- > 2.15.1.windows.2 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel