From: "Kinney, Michael D" <michael.d.kinney@intel.com>
To: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
"Leif Lindholm" <leif.lindholm@linaro.org>
Subject: Re: [edk2-platforms Patch] Platform: Add SafeIntLib and BmpSupportLib to DSC files
Date: Wed, 14 Feb 2018 21:14:29 +0000 [thread overview]
Message-ID: <E92EE9817A31E24EB0585FDF735412F5B8966F78@ORSMSX113.amr.corp.intel.com> (raw)
In-Reply-To: <20180213183702.17348-1-michael.d.kinney@intel.com>
The patch from Leif for this issue is a better solution using
a common DSC include.
Please ignore this one.
Mike
> -----Original Message-----
> From: Kinney, Michael D
> Sent: Tuesday, February 13, 2018 10:37 AM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Sean
> Brogan <sean.brogan@microsoft.com>; Yao, Jiewen
> <jiewen.yao@intel.com>; Ard Biesheuvel
> <ard.biesheuvel@linaro.org>; Leif Lindholm
> <leif.lindholm@linaro.org>
> Subject: [edk2-platforms Patch] Platform: Add SafeIntLib
> and BmpSupportLib to DSC files
>
> From: Michael D Kinney <michael.d.kinney@intel.com>
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=800
>
> Based on content from the following branch/commits:
> https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsule
> Support
> https://github.com/Microsoft/MS_UEFI/commit/33bab4031a417
> d7d5a7d356c15a14c2e60302b2d
> https://github.com/Microsoft/MS_UEFI/commit/ca516b1a61315
> c2d823f453e12d2135098f53d61
> https://github.com/Microsoft/MS_UEFI/commit/2b9f111f2e74a
> 4c2ef4c4e32379e111f016dbd9b
>
> BootGraphicsResourceTableDxe, GenericBdsLib, and
> CapsuleLib
> use BmpSupportLib and SafeIntLib to convert a GOP BLT
> buffers to a BMP graphics images and BMP graphics images
> to
> GOP BLT buffers. Add library mappings for these new
> library classes.
>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Michael D Kinney
> <michael.d.kinney@intel.com>
> ---
> Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> | 2 ++
> Platform/Hisilicon/D02/Pv660D02.dsc
> | 2 ++
> Platform/Hisilicon/D03/D03.dsc
> | 2 ++
> Platform/Hisilicon/D05/D05.dsc
> | 2 ++
> Platform/Socionext/DeveloperBox/DeveloperBox.dsc
> | 2 ++
>
> Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.
> dsc | 2 ++
> 6 files changed, 12 insertions(+)
>
> diff --git
> a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> index 48018abc6..5e879b16f 100644
> --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> @@ -49,6 +49,8 @@ [LibraryClasses.common]
>
> DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErro
> rLevelLib/BaseDebugPrintErrorLevelLib.inf
>
> BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
> +
> SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.i
> nf
> +
> BmpSupportLib|MdeModulePkg/Library/BaseBmpSupportLib/Base
> BmpSupportLib.inf
>
> SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/
> BaseSynchronizationLib.inf
>
> PerformanceLib|MdePkg/Library/BasePerformanceLibNull/Base
> PerformanceLibNull.inf
> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> diff --git a/Platform/Hisilicon/D02/Pv660D02.dsc
> b/Platform/Hisilicon/D02/Pv660D02.dsc
> index 9e826aeb6..c6e539c0c 100644
> --- a/Platform/Hisilicon/D02/Pv660D02.dsc
> +++ b/Platform/Hisilicon/D02/Pv660D02.dsc
> @@ -65,6 +65,8 @@ [LibraryClasses.common]
>
>
> CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCaps
> uleLibNull.inf
>
> GenericBdsLib|IntelFrameworkModulePkg/Library/GenericBdsL
> ib/GenericBdsLib.inf
> +
> SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.i
> nf
> +
> BmpSupportLib|MdeModulePkg/Library/BaseBmpSupportLib/Base
> BmpSupportLib.inf
>
> PlatformBdsLib|Silicon/Hisilicon/Library/PlatformIntelBds
> Lib/PlatformIntelBdsLib.inf
>
> CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDispl
> ayLib/CustomizedDisplayLib.inf
>
> diff --git a/Platform/Hisilicon/D03/D03.dsc
> b/Platform/Hisilicon/D03/D03.dsc
> index c49630637..e922f98d3 100644
> --- a/Platform/Hisilicon/D03/D03.dsc
> +++ b/Platform/Hisilicon/D03/D03.dsc
> @@ -66,6 +66,8 @@ [LibraryClasses.common]
>
> PlatformSysCtrlLib|Silicon/Hisilicon/Hi1610/Library/Platf
> ormSysCtrlLibHi1610/PlatformSysCtrlLibHi1610.inf
>
>
> GenericBdsLib|IntelFrameworkModulePkg/Library/GenericBdsL
> ib/GenericBdsLib.inf
> +
> SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.i
> nf
> +
> BmpSupportLib|MdeModulePkg/Library/BaseBmpSupportLib/Base
> BmpSupportLib.inf
>
> PlatformBdsLib|Silicon/Hisilicon/Library/PlatformIntelBds
> Lib/PlatformIntelBdsLib.inf
>
> BmcConfigBootLib|Silicon/Hisilicon/Library/BmcConfigBootL
> ib/BmcConfigBootLib.inf
>
> UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLi
> b/UefiBootManagerLib.inf
> diff --git a/Platform/Hisilicon/D05/D05.dsc
> b/Platform/Hisilicon/D05/D05.dsc
> index 0792b0814..a0922b388 100644
> --- a/Platform/Hisilicon/D05/D05.dsc
> +++ b/Platform/Hisilicon/D05/D05.dsc
> @@ -82,6 +82,8 @@ [LibraryClasses.common]
>
> PlatformSysCtrlLib|Silicon/Hisilicon/Hi1616/Library/Platf
> ormSysCtrlLibHi1616/PlatformSysCtrlLibHi1616.inf
>
>
> GenericBdsLib|IntelFrameworkModulePkg/Library/GenericBdsL
> ib/GenericBdsLib.inf
> +
> SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.i
> nf
> +
> BmpSupportLib|MdeModulePkg/Library/BaseBmpSupportLib/Base
> BmpSupportLib.inf
>
> PlatformBdsLib|Silicon/Hisilicon/Library/PlatformIntelBds
> Lib/PlatformIntelBdsLib.inf
>
> BmcConfigBootLib|Silicon/Hisilicon/Library/BmcConfigBootL
> ib/BmcConfigBootLib.inf
>
> UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLi
> b/UefiBootManagerLib.inf
> diff --git
> a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
> b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
> index 7e69eaba9..fdfaadd97 100644
> --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
> +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc
> @@ -75,6 +75,8 @@ [LibraryClasses.common]
>
> ArmGenericTimerCounterLib|ArmPkg/Library/ArmGenericTimerP
> hyCounterLib/ArmGenericTimerPhyCounterLib.inf
>
> BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
> +
> SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.i
> nf
> +
> BmpSupportLib|MdeModulePkg/Library/BaseBmpSupportLib/Base
> BmpSupportLib.inf
>
> SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/
> BaseSynchronizationLib.inf
>
> PerformanceLib|MdePkg/Library/BasePerformanceLibNull/Base
> PerformanceLibNull.inf
> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> diff --git
> a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoar
> d.dsc
> b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoar
> d.dsc
> index e35c17f0b..ece8ee7ad 100644
> ---
> a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoar
> d.dsc
> +++
> b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoar
> d.dsc
> @@ -75,6 +75,8 @@ [LibraryClasses.common]
>
> ArmGenericTimerCounterLib|ArmPkg/Library/ArmGenericTimerP
> hyCounterLib/ArmGenericTimerPhyCounterLib.inf
>
> BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
> +
> SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.i
> nf
> +
> BmpSupportLib|MdeModulePkg/Library/BaseBmpSupportLib/Base
> BmpSupportLib.inf
>
> SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/
> BaseSynchronizationLib.inf
>
> PerformanceLib|MdePkg/Library/BasePerformanceLibNull/Base
> PerformanceLibNull.inf
> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> --
> 2.14.2.windows.3
prev parent reply other threads:[~2018-02-14 21:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 18:37 [edk2-platforms Patch] Platform: Add SafeIntLib and BmpSupportLib to DSC files Kinney, Michael D
2018-02-14 21:14 ` Kinney, Michael D [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E92EE9817A31E24EB0585FDF735412F5B8966F78@ORSMSX113.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox