From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=michael.d.kinney@intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1BD4222402E16 for ; Wed, 28 Feb 2018 17:35:42 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Feb 2018 17:41:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,407,1515484800"; d="scan'208";a="34501649" Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by fmsmga001.fm.intel.com with ESMTP; 28 Feb 2018 17:41:50 -0800 Received: from orsmsx111.amr.corp.intel.com (10.22.240.12) by ORSMSX102.amr.corp.intel.com (10.22.225.129) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 28 Feb 2018 17:41:49 -0800 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.232]) by ORSMSX111.amr.corp.intel.com ([169.254.12.253]) with mapi id 14.03.0319.002; Wed, 28 Feb 2018 17:41:49 -0800 From: "Kinney, Michael D" To: =?utf-8?B?TWFydmluIEjDpHVzZXI=?= , "edk2-devel@lists.01.org" , "Kinney, Michael D" CC: "lersek@redhat.com" , "Gao, Liming" Thread-Topic: [edk2] [PATCH 1/2] MdePkg/Base.h: Ensure safe bitwise operations. Thread-Index: AQHTr+q3IxS4cmiO9UyN5haxybivfqO5L8MAgAAKh4CAAPKdAIAADDeAgAAlQgCAAAangP//vvnQgACMyID//9+d8A== Date: Thu, 1 Mar 2018 01:41:49 +0000 Message-ID: References: <62c9363b-7f27-cfff-492a-560660727b86@redhat.com> <366ffc0c-b55f-a3c1-973e-b80d3dd07d26@redhat.com> <2b22bfbd-24ce-e26c-9f1c-e5ba2816b48f@redhat.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Subject: Re: [PATCH 1/2] MdePkg/Base.h: Ensure safe bitwise operations. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Mar 2018 01:35:43 -0000 Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 SGkgTWFydmluLA0KDQpZZXMuICBJIGhhdmUgYmVlbiByZWFkaW5nIHRoZSB0aHJlYWQuDQoNCkxv dHMgb2YgcmVhbGx5IGdvb2QgYW5hbHlzaXMuDQoNCkhvd2V2ZXIsIGl0IGRvZXMgbm90IG1ha2Ug c2Vuc2UgdG8gbWUgdG8gYWRkDQondScgdG8gdGhlIHNtYWxsZXIgQklUeHgsIEJBU0V4eCwgYW5k IFNJWkV4eCANCm1hY3JvcyBpZiB3ZSBoYXZlIGNvbnN0YW50cyBpbiBvdGhlciBwbGFjZXMgdGhh dA0KZG8gbm90IGFkZCB0aGUgJ3UnLiBJIHRoaW5rIHRoaXMgcGF0Y2ggbWF5DQppbmNyZWFzZSB0 aGUgaW5jb25zaXN0ZW5jeSBvZiB0aGUgd2hvbGUgdHJlZS4NCg0KSWYgd2UgZG9u4oCZdCBtYWtl IHRoaXMgY2hhbmdlLCB3aGF0IHR5cGVzIG9mIA0KaXNzdWVzIGRvIHdlIG5lZWQgdG8gZml4IGFu ZCB3aGF0IHdvdWxkIHRoZSANCmZpeCBlbnRhaWw/DQoNCk1pa2UNCg0KPiAtLS0tLU9yaWdpbmFs IE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBNYXJ2aW4gSMOkdXNlciBbbWFpbHRvOk1hcnZpbi5IYWV1 c2VyQG91dGxvb2suY29tXQ0KPiBTZW50OiBXZWRuZXNkYXksIEZlYnJ1YXJ5IDI4LCAyMDE4IDEw OjUyIEFNDQo+IFRvOiBlZGsyLWRldmVsQGxpc3RzLjAxLm9yZzsgS2lubmV5LCBNaWNoYWVsIEQN Cj4gPG1pY2hhZWwuZC5raW5uZXlAaW50ZWwuY29tPg0KPiBDYzogbGVyc2VrQHJlZGhhdC5jb207 IEdhbywgTGltaW5nDQo+IDxsaW1pbmcuZ2FvQGludGVsLmNvbT4NCj4gU3ViamVjdDogUkU6IFtl ZGsyXSBbUEFUQ0ggMS8yXSBNZGVQa2cvQmFzZS5oOiBFbnN1cmUNCj4gc2FmZSBiaXR3aXNlIG9w ZXJhdGlvbnMuDQo+IA0KPiBIZXkgTWlrZSwNCj4gDQo+IFlvdSBhcmUgcmlnaHQsIHRoZSBwYXRj aCB3YXMgcHJlbWF0dXJlIGJlY2F1c2UgSSBkaWQNCj4gbm90IGNvbnNpZGVyIGFueSAnaW5jb3Jy ZWN0JyBvciAnY2xldmVyJyB1c2FnZXMgb2YNCj4gdGhlc2UgZGVmaW5pdGlvbnMuDQo+IFRoZSBw cm9ibGVtIGlzIG5vdCBwcmltYXJpbHkgdW5kZWZpbmVkIGJlaGF2aW9yLCBidXQNCj4gaW1wbGVt ZW50YXRpb24tZGVmaW5lZCBiZWhhdmlvci4NCj4gQW55IGJpdHdpc2Ugb3BlcmF0aW9uIHRvIGEg c2lnbmVkIGludGVnZXIgcmVzdWx0cyBpbg0KPiBpbXBsZW1lbnRhdGlvbi1kZWZpbmVkIGJlaGF2 aW9yLCB3aGljaCBjb21waWxlcnMNCj4gdXN1YWxseSBkbyBub3Qgd2FybiBhYm91dCwgd2hpbGUg d2VsbC1kZWZpbmVkIGJlaGF2aW9yDQo+IGlzIGRlc2lyYWJsZS4NCj4gDQo+IEhhdmUgeW91IHJl YWQgTGFzemxvJ3MgY29tbWVudHM/IFRoZXkgYXJlIHF1aXRlIGdvb2QgYXQNCj4gc2hvd2luZyB1 cCB3aGF0IGxvZ2ljcyBtaWdodCBiZSBhbmQgYXJlIHJlbGllZCBvbiwNCj4gd2hpY2ggaG93ZXZl ciBhcmUgbm90IGd1YXJhbnRlZWQgdG8gYmUgdGhlIGNhc2UgZm9yDQo+IG5vbi14ODYgYXJjaGl0 ZWN0dXJlcywNCj4gb3IgZXZlbiBmb3IgeDg2IGluIGNhc2UgYSBkZXZlbG9wbWVudCB0ZWFtIGRl Y2lkZXMgdG8NCj4gY2hhbmdlIHRoaXMgYmVoYXZpb3Igc29tZSBkYXkgb3IgYSBuZXcgdG9vbGNo YWluIG5vdA0KPiBoYXZpbmcgYWRvcHRlZCB0aGVtIGluIHRoZSBmaXJzdCBwbGFjZSBzaG91bGQg YmUgYWRkZWQuDQo+IA0KPiBGdXJ0aGVybW9yZSwgSSBkb24ndCB0aGluayBpbmNvbnNpc3RlbmN5 IGJldHdlZW4gdGhlDQo+IGRlZmluaXRpb25zIGdlbmVyYWxseSBpcyBkZXNpcmFibGUuDQo+IA0K PiBUaGFua3MsDQo+IE1hcnZpbi4NCj4gDQo+ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0N Cj4gPiBGcm9tOiBLaW5uZXksIE1pY2hhZWwgRCA8bWljaGFlbC5kLmtpbm5leUBpbnRlbC5jb20+ DQo+ID4gU2VudDogV2VkbmVzZGF5LCBGZWJydWFyeSAyOCwgMjAxOCA3OjM3IFBNDQo+ID4gVG86 IE1hcnZpbiBIw6R1c2VyIDxNYXJ2aW4uSGFldXNlckBvdXRsb29rLmNvbT47IGVkazItDQo+ID4g ZGV2ZWxAbGlzdHMuMDEub3JnOyBMYXN6bG8gRXJzZWsgPGxlcnNla0ByZWRoYXQuY29tPjsNCj4g S2lubmV5LCBNaWNoYWVsIEQNCj4gPiA8bWljaGFlbC5kLmtpbm5leUBpbnRlbC5jb20+DQo+ID4g Q2M6IEdhbywgTGltaW5nIDxsaW1pbmcuZ2FvQGludGVsLmNvbT4NCj4gPiBTdWJqZWN0OiBSRTog W2VkazJdIFtQQVRDSCAxLzJdIE1kZVBrZy9CYXNlLmg6IEVuc3VyZQ0KPiBzYWZlIGJpdHdpc2UN Cj4gPiBvcGVyYXRpb25zLg0KPiA+DQo+ID4gSGkgTWFydmluLA0KPiA+DQo+ID4gSSBkbyBub3Qg dGhpbmsgYWRkICd1JyB0byB0aGUgQklUeHggZGVmaW5lcyBkb2VzIG5vdA0KPiBzZWVtIHRvIGJl IGEgY29tcGxldGUNCj4gPiBzb2x1dGlvbi4gIENvZGUgY2FuIHVzZSBpbnRlZ2VyIGNvbnN0YW50 cyBpbiBsb3RzIG9mDQo+IHBsYWNlcyBpbmNsdWRpbmcgb3RoZXINCj4gPiAjZGVmaW5lcyBvciBp bmxpbmUgaW4gZXhwcmVzc2lvbnMuDQo+ID4NCj4gPiBJZiB3ZSBmb2xsb3cgeW91ciBzdWdnZXN0 aW9uIHdvdWxkbuKAmXQgd2UgbmVlZCB0byBhZGQNCj4gJ3UnIHRvIGV2ZXJ5IGNvbnN0YW50DQo+ ID4gdGhhdCBkb2VzIG5vdCBzdGFydCB3aXRoIGEgJy0nDQo+ID4gYW5kIG1pZ2h0IHBvdGVudGlh bGx5IGJlIHVzZWQgd2l0aCBhIGJpdCBvcGVyYXRpb24/DQo+ID4NCj4gPiBDb21waWxlcnMgYXJl IGRvaW5nIGEgZ29vZCBqb2Igb2YgZmluZGluZyB1bmRlZmluZWQNCj4gYmVoYXZpb3IuICBJc27i gJl0IHRoYXQNCj4gPiBzdWZmaWNpZW50IHRvIGZpeCB0aGUgaXNzdWVzIGlkZW50aWZpZWQ/DQo+ ID4NCj4gPiBNaWtlDQo+ID4NCj4gPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4g PiBGcm9tOiBNYXJ2aW4gSMOkdXNlcg0KPiBbbWFpbHRvOk1hcnZpbi5IYWV1c2VyQG91dGxvb2su Y29tXQ0KPiA+ID4gU2VudDogV2VkbmVzZGF5LCBGZWJydWFyeSAyOCwgMjAxOCA2OjIxIEFNDQo+ ID4gPiBUbzogZWRrMi1kZXZlbEBsaXN0cy4wMS5vcmc7IExhc3psbyBFcnNlaw0KPiA8bGVyc2Vr QHJlZGhhdC5jb20+DQo+ID4gPiBDYzogS2lubmV5LCBNaWNoYWVsIEQgPG1pY2hhZWwuZC5raW5u ZXlAaW50ZWwuY29tPjsNCj4gR2FvLCBMaW1pbmcNCj4gPiA+IDxsaW1pbmcuZ2FvQGludGVsLmNv bT4NCj4gPiA+IFN1YmplY3Q6IFJFOiBbZWRrMl0gW1BBVENIIDEvMl0gTWRlUGtnL0Jhc2UuaDoN Cj4gRW5zdXJlIHNhZmUgYml0d2lzZQ0KPiA+ID4gb3BlcmF0aW9ucy4NCj4gPiA+DQo+ID4gPiBI ZXkgTGFzemxvLA0KPiA+ID4NCj4gPiA+IEkgY3V0IHlvdXIgcmFudCBiZWNhdXNlIGl0IGlzIG5v dCBzdHJpY3RseSByZWxhdGVkDQo+IHRvIHRoaXMgcGF0Y2guDQo+ID4gPiBIb3dldmVyLCB0aGFu ayB5b3UgZm9yIGNvbXBvc2luZyBpdCBuZXZlcnRoZWxlc3MNCj4gYmVjYXVzZSBpdCB3YXMgYW4N Cj4gPiA+IGludGVyZXN0aW5nIHJlYWQhDQo+ID4gPiBDb21tZW50cyBhcmUgaW5saW5lLg0KPiA+ ID4NCj4gPiA+IE1pY2hhZWwsIExpbWluZywNCj4gPiA+IERvIHlvdSBoYXZlIGFueSBjb21tZW50 cyByZWdhcmRpbmcgdGhlIGRpc2N1c3Npb24/DQo+ID4gPiBUaGFua3MgaW4gYWR2YW5jZS4NCj4g PiA+DQo+ID4gPiBCZXN0IHJlZ2FyZHMsDQo+ID4gPiBNYXJ2aW4uDQo+ID4gPg0KPiA+ID4gPiAt LS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiA+ID4gPiBGcm9tOiBMYXN6bG8gRXJzZWsgPGxl cnNla0ByZWRoYXQuY29tPg0KPiA+ID4gPiBTZW50OiBXZWRuZXNkYXksIEZlYnJ1YXJ5IDI4LCAy MDE4IDI6NTcgUE0NCj4gPiA+ID4gVG86IE1hcnZpbiBIw6R1c2VyIDxNYXJ2aW4uSGFldXNlckBv dXRsb29rLmNvbT47DQo+IGVkazItDQo+ID4gPiA+IGRldmVsQGxpc3RzLjAxLm9yZw0KPiA+ID4g PiBDYzogbWljaGFlbC5kLmtpbm5leUBpbnRlbC5jb207DQo+IGxpbWluZy5nYW9AaW50ZWwuY29t DQo+ID4gPiA+IFN1YmplY3Q6IFJlOiBbZWRrMl0gW1BBVENIIDEvMl0gTWRlUGtnL0Jhc2UuaDoN Cj4gRW5zdXJlDQo+ID4gPiBzYWZlIGJpdHdpc2UNCj4gPiA+ID4gb3BlcmF0aW9ucy4NCj4gPiA+ ID4NCj4gPiA+ID4gT24gMDIvMjgvMTggMTI6NDMsIE1hcnZpbiBIw6R1c2VyIHdyb3RlOg0KPiA+ ID4gWy4uLl0NCj4gPiA+ID4gPiBhcyBlZGsyIGRvZXMgbm90IHN1cHBvcnQgdmVuZG9yIGV4dGVu c2lvbnMgc3VjaA0KPiBhcw0KPiA+ID4gX19pbnQxMjggYW55d2F5Lg0KPiA+ID4gPg0KPiA+ID4g PiBOb3QgKnlldCosIEkgZ3Vlc3MgOikgVUVGSSAyLjcgZG9lcyBsaXN0IFVJTlQxMjgNCj4gLw0K PiA+ID4gSU5UMTI4LCBpbiB0YWJsZSA1LCAiQ29tbW9uDQo+ID4gPiA+IFVFRkkgRGF0YSBUeXBl cyIuIEkgYmVsaWV2ZSB0aG9zZSB0eXBlZGVmcyBtYXkNCj4gaGF2ZQ0KPiA+ID4gYmVlbiBhZGRl ZCBmb3IgUklTQy1WLg0KPiA+ID4NCj4gPiA+IE9oIHlpa2VzLCBJIGhhdmUgbm90IG5vdGljZWQg dGhhdCBiZWZvcmUuIEJlc2lkZXMNCj4gdGhhdCBJIHdvbmRlciBob3cNCj4gPiA+IHRoYXQgd2ls bCBiZSBpbXBsZW1lbnRlZCBieSBlZGsyIGZvciBub24tIFJJU0MtVg0KPiBwbGF0Zm9ybXMsIG1h eWJlIHRoYXQNCj4gPiA+IHNob3VsZCBiZSBjb25zaWRlcmVkPw0KPiA+ID4gQXMgcmlkaWN1bG91 cyBhcyBpdCBzb3VuZHMsIG1heWJlIHNvbWUga2luZCBvZg0KPiBVSU5UX01BWCB0eXBlIChub3cN Cj4gPiA+IFVJTlQ2NCwgbGF0ZXIgVUlOVDEyOCkgc2hvdWxkIGJlIGludHJvZHVjZWQgYW5kIGFu eQ0KPiBCSVQgb3IgYml0bWFzaw0KPiA+ID4gZGVmaW5pdGlvbiBiZWluZyBleHBsaWNpdGx5IGNh c3RlZCB0byB0aGF0Pw0KPiA+ID4gQXJlIEJJVCBkZWZpbml0aW9ucyBvciBtYXNrcyBvY2Nhc2lv bmFsbHkgdXNlZCBpbg0KPiBwcmVwcm9jZXNzb3INCj4gPiA+IG9wZXJhdGlvbnM/IFRoYXQgbWln aHQgYnJlYWsgYWZ0ZXIgYWxsLg0KPiA+ID4gQW55d2F5LCBpZiB0aGF0IGlkZWEgd291bGQgYmUg YXBwcm92ZWQsIHRoZXJlDQo+IHJlYWxseSB3b3VsZCBoYXZlIHRvIGJlDQo+ID4gPiBhIG5vdGUg cmVnYXJkaW5nIHRoaXMgZGVzaWduIGluIHNvbWUgb2YgdGhlIEVESzINCj4gc3BlY2lmaWNhdGlv bnMsDQo+ID4gPiBwcm9iYWJseSBDIENvZGUgU3R5bGUuDQo+ID4gPg0KPiA+ID4gWy4uLl0NCj4g PiA+ID4NCj4gPiA+ID4gPiAtMSkgVGhlICd0cnVuY2F0aW5nIGNvbnN0YW50IHZhbHVlJyB3YXJu aW5nDQo+IHdvdWxkDQo+ID4gPiBwcm9iYWJseSBuZWVkIHRvIGJlDQo+ID4gPiA+ID4gZGlzYWJs ZWQgZ2xvYmFsbHksIGhvd2V2ZXIgSSBkb24ndCB1bmRlcnN0YW5kDQo+IGhvdw0KPiA+ID4gYW4g ZXhwbGljaXQgY2FzdCBpcw0KPiA+ID4gPiA+IGEgcHJvYmxlbSBhbnl3YXkuDQo+ID4gPiA+ID4N Cj4gPiA+ID4gPiBEaWQgSSBvdmVybG9vayBhbnl0aGluZyBjb250cmEgcmVnYXJkaW5nIHRoYXQ/ DQo+ID4gPiA+DQo+ID4gPiA+IEhtbW0uLi4gRG8geW91IHRoaW5rIGl0IGNvdWxkIGhhdmUgYSBw ZXJmb3JtYW5jZQ0KPiA+ID4gaW1wYWN0IG9uIDMyLWJpdA0KPiA+ID4gPiBwbGF0Zm9ybXM/IChJ IGRvbid0IHRoaW5rIHNvLCBhdCBsZWFzdCBub3QgaW4NCj4gPiA+IG9wdGltaXplZCAvIFJFTEVB U0UNCj4gPiA+ID4gYnVpbGRzLikNCj4gPiA+DQo+ID4gPiBJIGRvbid0IHRoaW5rIGFueSBwcm9w ZXIgb3B0aW1pemVyIHdvdWxkIG5vdA0KPiBvcHRpbWl6ZSB0aGlzLiBBZnRlciBhbGwsDQo+ID4g PiBpdCBjYW4gbm90IG9ubHkgZXZhbHVhdGUgdGhlIHZhbHVlIGRpcmVjdGx5IGFuZA0KPiBub3Rp Y2UgdGhhdCB0aGUgdmFsdWUNCj4gPiA+IGRvZXMgbm90IHJlYWNoIGludG8gdGhlICdsb25nIGxv bmcgcmFuZ2UnLCBidXQgYWxzbw0KPiBjb25zaWRlciB0aGUgdHlwZQ0KPiA+ID4gb2YgdGhlIG90 aGVyIG9wZXJhbmQuDQo+ID4gPg0KPiA+ID4gWy4uLl0NCg0K