Re: [Patch V2 0/9] Add DisplayUpdateProgressLib for capsules

["Kinney, Michael D" <michael.d.kinney@intel.com>]

I have also posted a branch for review. 

https://github.com/mdkinney/edk2/tree/Bug_801_DisplayUpdateProgressLib_V2

Mike


> -----Original Message-----
> From: Kinney, Michael D
> Sent: Wednesday, April 11, 2018 5:48 PM
> To: edk2-devel@lists.01.org
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Zeng, Star
> <star.zeng@intel.com>; Dong, Eric <eric.dong@intel.com>;
> Yao, Jiewen <jiewen.yao@intel.com>; Wei, David
> <david.wei@intel.com>; Guo, Mang <mang.guo@intel.com>;
> Steele, Kelly <kelly.steele@intel.com>; Kinney, Michael
> D <michael.d.kinney@intel.com>
> Subject: [Patch V2 0/9] Add DisplayUpdateProgressLib for
> capsules
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=801
> 
> Based on content from:
> 
> https://github.com/Microsoft/MS_UEFI/blob/share/MsCapsul
> eSupport/MsCapsuleUpdatePkg/Include/Library/DisplayUpdat
> eProgressLib.h
> https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsul
> eSupport/MsCapsuleUpdatePkg/Library/DisplayUpdateProgres
> sGraphicsLib
> https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsul
> eSupport/MsCapsuleUpdatePkg/Library/DisplayUpdateProgres
> sTextLib
> 
> Updates for V2
> ==============
> * Change DisplayUpdateProgressGraphicsLib to
> DisplayUpdateProgressLibGraphics
> * Change DisplayUpdateProgressTextLib to
> DisplayUpdateProgressLibText
> * Clarify that color in Firmware Management Progress
> Protocol is the foreground color
> * Add missing parameters to
> PerformFlashWriteWithProgress() function header.
> * Update PerformFlashWriteWithProgress() function header
> describing the use of
>   the start and end percentage values.
> * Update QuarkPlatformPkg
> PerformFlashWriteWithProgress() to call Progress() for
>   the end precentage.
> * Update Vlv2Tbl2DevicePkg
> PerformFlashWriteWithProgress() to call Progress()
>   for the end precentage.
> 
> Add DisplayUpdateProgressLib class along implementations
> for both graphical
> (Graphics Output Protocol based) and text (Simple Text
> Output Protocol based)
> consoles.  Also add the EDK II Firmware Management
> Progress Protocol that is an
> optional protocol that provides the progress bar color
> and a watchdog timeout
> value thaty can be used when a firmware image is updated
> in a firmware device.
> 
> * Add progress support to DxeCapsuleLibFmp
> * Add progress support to SystemFirmwareUpdateDxe
> * Add progress support to PlatformFlashAccessLib class
> and instances.
> * Reduce Print() calls during a firmware update.
> 
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: David Wei <david.wei@intel.com>
> Cc: Mang Guo <mang.guo@intel.com>
> Cc: Kelly Steele <kelly.steele@intel.com>
> 
> Signed-off-by: Michael D Kinney
> <michael.d.kinney@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> 
> Kinney, Michael D (3):
>   QuarkPlatformPkg: Add DisplayUpdateProgressLib mapping
>   MdeModulePkg/DxeCapsuleLibFmp: Add progress bar
> support
>   SignedCapsulePkg/SystemFirmwareUpdateDxe: Use progress
> API
> 
> Michael D Kinney (6):
>   MdeModulePkg: Add DisplayUpdateProgressLib class
>   MdeModulePkg: Add DisplayUpdateProgressLib instances
>   Vlv2Tbl2DevicePkg: Add DisplayUpdateProgressLib
> mapping
>   SignedCapsulePkg/PlatformFlashAccessLib: Add progress
> API
>   Vlv2TbltDevicePkg/PlatformFlashAccessLib: Add progress
> API
>   QuarkPlatformPkg/PlatformFlashAccessLib: Add progress
> API
> 
>  .../Include/Library/DisplayUpdateProgressLib.h     |
> 65 +++
>  .../Include/Protocol/FirmwareManagementProgress.h  |
> 51 +++
>  .../DisplayUpdateProgressLibGraphics.c             |
> 475 +++++++++++++++++++++
>  .../DisplayUpdateProgressLibGraphics.inf           |
> 60 +++
>  .../DisplayUpdateProgressLibGraphics.uni           |
> 18 +
>  .../DisplayUpdateProgressLibText.c                 |
> 174 ++++++++
>  .../DisplayUpdateProgressLibText.inf               |
> 53 +++
>  .../DisplayUpdateProgressLibText.uni               |
> 18 +
>  .../Library/DxeCapsuleLibFmp/DxeCapsuleLib.c       |
> 47 +-
>  .../Library/DxeCapsuleLibFmp/DxeCapsuleLib.inf     |
> 8 +-
>  .../DxeCapsuleLibFmp/DxeCapsuleProcessLib.c        |
> 84 +++-
>  .../DxeCapsuleLibFmp/DxeCapsuleProcessLibNull.c    |
> 21 +-
>  .../DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf      |
> 7 +-
>  MdeModulePkg/MdeModulePkg.dec                      |
> 11 +
>  MdeModulePkg/MdeModulePkg.dsc                      |
> 3 +
>  .../PlatformFlashAccessLibDxe.c                    |
> 78 +++-
>  QuarkPlatformPkg/Quark.dsc                         |
> 1 +
>  .../Include/Library/PlatformFlashAccessLib.h       |
> 49 ++-
>  .../PlatformFlashAccessLibNull.c                   |
> 70 ++-
>  .../SystemFirmwareUpdate/SystemFirmwareUpdateDxe.c |
> 90 +++-
>  .../PlatformFlashAccessLib.c                       |
> 102 +++--
>  .../PlatformFlashAccessLib.inf                     |
> 3 +-
>  Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc            |
> 1 +
>  Vlv2TbltDevicePkg/PlatformPkgIA32.dsc              |
> 1 +
>  Vlv2TbltDevicePkg/PlatformPkgX64.dsc               |
> 1 +
>  25 files changed, 1387 insertions(+), 104 deletions(-)
>  create mode 100644
> MdeModulePkg/Include/Library/DisplayUpdateProgressLib.h
>  create mode 100644
> MdeModulePkg/Include/Protocol/FirmwareManagementProgress
> .h
>  create mode 100644
> MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/Di
> splayUpdateProgressLibGraphics.c
>  create mode 100644
> MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/Di
> splayUpdateProgressLibGraphics.inf
>  create mode 100644
> MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/Di
> splayUpdateProgressLibGraphics.uni
>  create mode 100644
> MdeModulePkg/Library/DisplayUpdateProgressLibText/Displa
> yUpdateProgressLibText.c
>  create mode 100644
> MdeModulePkg/Library/DisplayUpdateProgressLibText/Displa
> yUpdateProgressLibText.inf
>  create mode 100644
> MdeModulePkg/Library/DisplayUpdateProgressLibText/Displa
> yUpdateProgressLibText.uni
> 
> --
> 2.14.2.windows.3