From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.120; helo=mga04.intel.com; envelope-from=michael.d.kinney@intel.com; receiver=edk2-devel@lists.01.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 63E17226CD782 for ; Wed, 11 Apr 2018 18:06:03 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Apr 2018 18:06:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,439,1517904000"; d="scan'208";a="33630029" Received: from orsmsx101.amr.corp.intel.com ([10.22.225.128]) by orsmga006.jf.intel.com with ESMTP; 11 Apr 2018 18:06:02 -0700 Received: from orsmsx162.amr.corp.intel.com (10.22.240.85) by ORSMSX101.amr.corp.intel.com (10.22.225.128) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 11 Apr 2018 18:06:02 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.55]) by ORSMSX162.amr.corp.intel.com ([169.254.3.45]) with mapi id 14.03.0319.002; Wed, 11 Apr 2018 18:06:02 -0700 From: "Kinney, Michael D" To: "edk2-devel@lists.01.org" , "Kinney, Michael D" CC: Sean Brogan , "Zeng, Star" , "Dong, Eric" , "Yao, Jiewen" , "Wei, David" , "Guo, Mang" , "Steele, Kelly" , Bret Barkelew Thread-Topic: [Patch V2 0/9] Add DisplayUpdateProgressLib for capsules Thread-Index: AQHT0ff/h81uasiCpUO2Qky1kWYYq6P8UCUg Date: Thu, 12 Apr 2018 01:06:01 +0000 Message-ID: References: <20180412004830.9904-1-michael.d.kinney@intel.com> In-Reply-To: <20180412004830.9904-1-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Subject: Re: [Patch V2 0/9] Add DisplayUpdateProgressLib for capsules X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Apr 2018 01:06:03 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I have also posted a branch for review.=20 https://github.com/mdkinney/edk2/tree/Bug_801_DisplayUpdateProgressLib_V2 Mike > -----Original Message----- > From: Kinney, Michael D > Sent: Wednesday, April 11, 2018 5:48 PM > To: edk2-devel@lists.01.org > Cc: Sean Brogan ; Zeng, Star > ; Dong, Eric ; > Yao, Jiewen ; Wei, David > ; Guo, Mang ; > Steele, Kelly ; Kinney, Michael > D > Subject: [Patch V2 0/9] Add DisplayUpdateProgressLib for > capsules >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D801 >=20 > Based on content from: >=20 > https://github.com/Microsoft/MS_UEFI/blob/share/MsCapsul > eSupport/MsCapsuleUpdatePkg/Include/Library/DisplayUpdat > eProgressLib.h > https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsul > eSupport/MsCapsuleUpdatePkg/Library/DisplayUpdateProgres > sGraphicsLib > https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsul > eSupport/MsCapsuleUpdatePkg/Library/DisplayUpdateProgres > sTextLib >=20 > Updates for V2 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > * Change DisplayUpdateProgressGraphicsLib to > DisplayUpdateProgressLibGraphics > * Change DisplayUpdateProgressTextLib to > DisplayUpdateProgressLibText > * Clarify that color in Firmware Management Progress > Protocol is the foreground color > * Add missing parameters to > PerformFlashWriteWithProgress() function header. > * Update PerformFlashWriteWithProgress() function header > describing the use of > the start and end percentage values. > * Update QuarkPlatformPkg > PerformFlashWriteWithProgress() to call Progress() for > the end precentage. > * Update Vlv2Tbl2DevicePkg > PerformFlashWriteWithProgress() to call Progress() > for the end precentage. >=20 > Add DisplayUpdateProgressLib class along implementations > for both graphical > (Graphics Output Protocol based) and text (Simple Text > Output Protocol based) > consoles. Also add the EDK II Firmware Management > Progress Protocol that is an > optional protocol that provides the progress bar color > and a watchdog timeout > value thaty can be used when a firmware image is updated > in a firmware device. >=20 > * Add progress support to DxeCapsuleLibFmp > * Add progress support to SystemFirmwareUpdateDxe > * Add progress support to PlatformFlashAccessLib class > and instances. > * Reduce Print() calls during a firmware update. >=20 > Cc: Sean Brogan > Cc: Star Zeng > Cc: Eric Dong > Cc: Jiewen Yao > Cc: David Wei > Cc: Mang Guo > Cc: Kelly Steele >=20 > Signed-off-by: Michael D Kinney > > Contributed-under: TianoCore Contribution Agreement 1.1 >=20 > Kinney, Michael D (3): > QuarkPlatformPkg: Add DisplayUpdateProgressLib mapping > MdeModulePkg/DxeCapsuleLibFmp: Add progress bar > support > SignedCapsulePkg/SystemFirmwareUpdateDxe: Use progress > API >=20 > Michael D Kinney (6): > MdeModulePkg: Add DisplayUpdateProgressLib class > MdeModulePkg: Add DisplayUpdateProgressLib instances > Vlv2Tbl2DevicePkg: Add DisplayUpdateProgressLib > mapping > SignedCapsulePkg/PlatformFlashAccessLib: Add progress > API > Vlv2TbltDevicePkg/PlatformFlashAccessLib: Add progress > API > QuarkPlatformPkg/PlatformFlashAccessLib: Add progress > API >=20 > .../Include/Library/DisplayUpdateProgressLib.h | > 65 +++ > .../Include/Protocol/FirmwareManagementProgress.h | > 51 +++ > .../DisplayUpdateProgressLibGraphics.c | > 475 +++++++++++++++++++++ > .../DisplayUpdateProgressLibGraphics.inf | > 60 +++ > .../DisplayUpdateProgressLibGraphics.uni | > 18 + > .../DisplayUpdateProgressLibText.c | > 174 ++++++++ > .../DisplayUpdateProgressLibText.inf | > 53 +++ > .../DisplayUpdateProgressLibText.uni | > 18 + > .../Library/DxeCapsuleLibFmp/DxeCapsuleLib.c | > 47 +- > .../Library/DxeCapsuleLibFmp/DxeCapsuleLib.inf | > 8 +- > .../DxeCapsuleLibFmp/DxeCapsuleProcessLib.c | > 84 +++- > .../DxeCapsuleLibFmp/DxeCapsuleProcessLibNull.c | > 21 +- > .../DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf | > 7 +- > MdeModulePkg/MdeModulePkg.dec | > 11 + > MdeModulePkg/MdeModulePkg.dsc | > 3 + > .../PlatformFlashAccessLibDxe.c | > 78 +++- > QuarkPlatformPkg/Quark.dsc | > 1 + > .../Include/Library/PlatformFlashAccessLib.h | > 49 ++- > .../PlatformFlashAccessLibNull.c | > 70 ++- > .../SystemFirmwareUpdate/SystemFirmwareUpdateDxe.c | > 90 +++- > .../PlatformFlashAccessLib.c | > 102 +++-- > .../PlatformFlashAccessLib.inf | > 3 +- > Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | > 1 + > Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | > 1 + > Vlv2TbltDevicePkg/PlatformPkgX64.dsc | > 1 + > 25 files changed, 1387 insertions(+), 104 deletions(-) > create mode 100644 > MdeModulePkg/Include/Library/DisplayUpdateProgressLib.h > create mode 100644 > MdeModulePkg/Include/Protocol/FirmwareManagementProgress > .h > create mode 100644 > MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/Di > splayUpdateProgressLibGraphics.c > create mode 100644 > MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/Di > splayUpdateProgressLibGraphics.inf > create mode 100644 > MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/Di > splayUpdateProgressLibGraphics.uni > create mode 100644 > MdeModulePkg/Library/DisplayUpdateProgressLibText/Displa > yUpdateProgressLibText.c > create mode 100644 > MdeModulePkg/Library/DisplayUpdateProgressLibText/Displa > yUpdateProgressLibText.inf > create mode 100644 > MdeModulePkg/Library/DisplayUpdateProgressLibText/Displa > yUpdateProgressLibText.uni >=20 > -- > 2.14.2.windows.3