public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Kinney, Michael D" <michael.d.kinney@intel.com>
To: "Bi, Dandan" <dandan.bi@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "Dong, Eric" <eric.dong@intel.com>, "Gao, Liming" <liming.gao@intel.com>
Subject: Re: [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu
Date: Thu, 12 Apr 2018 01:44:13 +0000	[thread overview]
Message-ID: <E92EE9817A31E24EB0585FDF735412F5B89C94EF@ORSMSX113.amr.corp.intel.com> (raw)
In-Reply-To: <20180412013138.113904-1-dandan.bi@intel.com>

Dandan Bi,

Is it possible to move the enter/exit event signaling
into the FormBrowwer SendForm() function?  The current
patch set adds these signal calls in all the places that
SendForm() is called and if one of these is missed, 
a notification will be missed.

Mike

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-
> bounces@lists.01.org] On Behalf Of Dandan Bi
> Sent: Wednesday, April 11, 2018 6:32 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric <eric.dong@intel.com>; Gao, Liming
> <liming.gao@intel.com>
> Subject: [edk2] [patch 0/3] MdeModulePkg/UiApp: Signal
> event when enter/exit setup menu
> 
> These changes are to support notify callbacks when
> enter/exit
> setup menu, since some driver may need to hook setup
> enter/exit
> points to do something.
> 
> We will signal setup enter/exit events for all setup
> menu
> enter/exit cases.Then the module which pay attention to
> these
> events can execute the callback.
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> 
> Dandan Bi (3):
>   MdeModulePkg/UiApp: Signal event when enter/exit setup
> menu
>   MdeModulePkg/BMMUiLib: Signal event when enter/exit
> setup menu
>   MdeModulePkg/BMUiLib: Signal event when enter/exit
> setup menu
> 
>  MdeModulePkg/Application/UiApp/FrontPage.c
> | 4 +++-
> 
> MdeModulePkg/Application/UiApp/FrontPageCustomizedUiSupp
> ort.c     | 3 ++-
>  MdeModulePkg/Application/UiApp/UiApp.inf
> | 4 +++-
> 
> .../BootMaintenanceManagerUiLib/BootMaintenanceManagerUi
> Lib.inf   | 4 +++-
> 
> MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootOpt
> ion.c     | 8 +++++++-
>  MdeModulePkg/Library/BootManagerUiLib/BootManager.c
> | 7 ++++++-
> 
> MdeModulePkg/Library/BootManagerUiLib/BootManagerUiLib.i
> nf        | 4 +++-
>  MdeModulePkg/MdeModulePkg.dec
> | 6 ++++++
>  8 files changed, 33 insertions(+), 7 deletions(-)
> 
> --
> 2.14.3.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


  parent reply	other threads:[~2018-04-12  1:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-12  1:31 [patch 0/3] MdeModulePkg/UiApp: Signal event when enter/exit setup menu Dandan Bi
2018-04-12  1:31 ` [patch 1/3] " Dandan Bi
2018-04-12  1:31 ` [patch 2/3] MdeModulePkg/BMMUiLib: " Dandan Bi
2018-04-12  1:31 ` [patch 3/3] MdeModulePkg/BMUiLib: " Dandan Bi
2018-04-12  1:44 ` Kinney, Michael D [this message]
2018-04-12  3:16   ` [patch 0/3] MdeModulePkg/UiApp: " Bi, Dandan
2018-04-12  3:46     ` Bi, Dandan
2018-04-12  3:49       ` Tim Lewis
2018-04-12  4:53         ` Bi, Dandan
2018-04-12  5:10           ` Tim Lewis
2018-04-12  6:02       ` Zeng, Star
2018-04-12  6:07         ` Bi, Dandan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E92EE9817A31E24EB0585FDF735412F5B89C94EF@ORSMSX113.amr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox