* [Patch][edk2-platforms/devel-MinnowBoardMax-UDK2017] Fix SMM stack size issue @ 2018-05-30 9:12 Guo, Mang 2018-05-30 15:12 ` Kinney, Michael D 0 siblings, 1 reply; 3+ messages in thread From: Guo, Mang @ 2018-05-30 9:12 UTC (permalink / raw) To: edk2-devel@lists.01.org; +Cc: Wei, David Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Guo Mang <mang.guo@intel.com> --- Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc index 6ebbb66..7f44f0a 100644 --- a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc +++ b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc @@ -1437,7 +1437,12 @@ $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fTPMInitPeim.inf # MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf - UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf + UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf { + <PcdsFixedAtBuild> + gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmStackSize|0x4000 + } + + UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.inf MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf UefiCpuPkg/CpuS3DataDxe/CpuS3DataDxe.inf -- 2.10.1.windows.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Patch][edk2-platforms/devel-MinnowBoardMax-UDK2017] Fix SMM stack size issue 2018-05-30 9:12 [Patch][edk2-platforms/devel-MinnowBoardMax-UDK2017] Fix SMM stack size issue Guo, Mang @ 2018-05-30 15:12 ` Kinney, Michael D 2018-05-31 6:48 ` Guo, Mang 0 siblings, 1 reply; 3+ messages in thread From: Kinney, Michael D @ 2018-05-30 15:12 UTC (permalink / raw) To: Guo, Mang, edk2-devel@lists.01.org, Kinney, Michael D; +Cc: Wei, David Guo, Can you please provide the old size and the new size in the commit message? Also, what changed that required a larger stack? Thanks, Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel- > bounces@lists.01.org] On Behalf Of Guo, Mang > Sent: Wednesday, May 30, 2018 2:13 AM > To: edk2-devel@lists.01.org > Cc: Wei, David <david.wei@intel.com> > Subject: [edk2] [Patch][edk2-platforms/devel- > MinnowBoardMax-UDK2017] Fix SMM stack size issue > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Guo Mang <mang.guo@intel.com> > --- > Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > index 6ebbb66..7f44f0a 100644 > --- a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > +++ b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > @@ -1437,7 +1437,12 @@ > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/ > IA32/fTPMInitPeim.inf > # > MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf > MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf > - UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf > + UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf { > + <PcdsFixedAtBuild> > + > gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmStackSize|0x4000 > + } > + > + > UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.inf > > MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf > UefiCpuPkg/CpuS3DataDxe/CpuS3DataDxe.inf > -- > 2.10.1.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Patch][edk2-platforms/devel-MinnowBoardMax-UDK2017] Fix SMM stack size issue 2018-05-30 15:12 ` Kinney, Michael D @ 2018-05-31 6:48 ` Guo, Mang 0 siblings, 0 replies; 3+ messages in thread From: Guo, Mang @ 2018-05-31 6:48 UTC (permalink / raw) To: Kinney, Michael D, edk2-devel@lists.01.org; +Cc: Wei, David Hi Mike, Old SMM stack size was 0x2000 which was not enough for Windows 10 16299 version. Because this version OS needs larger SMM stack size to set variable. SMM stack size was changed from 0x2000 to 0x4000 to fix this issue. Updated the patch to provide a complete description of the change in the commit message. Thanks, Mang -----Original Message----- From: Kinney, Michael D Sent: Wednesday, May 30, 2018 11:13 PM To: Guo, Mang; edk2-devel@lists.01.org; Kinney, Michael D Cc: Wei, David Subject: RE: [Patch][edk2-platforms/devel-MinnowBoardMax-UDK2017] Fix SMM stack size issue Guo, Can you please provide the old size and the new size in the commit message? Also, what changed that required a larger stack? Thanks, Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel- > bounces@lists.01.org] On Behalf Of Guo, Mang > Sent: Wednesday, May 30, 2018 2:13 AM > To: edk2-devel@lists.01.org > Cc: Wei, David <david.wei@intel.com> > Subject: [edk2] [Patch][edk2-platforms/devel- > MinnowBoardMax-UDK2017] Fix SMM stack size issue > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Guo Mang <mang.guo@intel.com> > --- > Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > index 6ebbb66..7f44f0a 100644 > --- a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > +++ b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > @@ -1437,7 +1437,12 @@ > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/ > IA32/fTPMInitPeim.inf > # > MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf > MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf > - UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf > + UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf { > + <PcdsFixedAtBuild> > + > gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmStackSize|0x4000 > + } > + > + > UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.inf > > MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf > UefiCpuPkg/CpuS3DataDxe/CpuS3DataDxe.inf > -- > 2.10.1.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-31 6:49 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-05-30 9:12 [Patch][edk2-platforms/devel-MinnowBoardMax-UDK2017] Fix SMM stack size issue Guo, Mang 2018-05-30 15:12 ` Kinney, Michael D 2018-05-31 6:48 ` Guo, Mang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox