From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=michael.d.kinney@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DAED6209688F2 for ; Mon, 4 Jun 2018 13:05:40 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Jun 2018 13:05:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,476,1520924400"; d="scan'208";a="46375699" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by orsmga007.jf.intel.com with ESMTP; 04 Jun 2018 13:05:40 -0700 Received: from orsmsx116.amr.corp.intel.com (10.22.240.14) by ORSMSX109.amr.corp.intel.com (10.22.240.7) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 4 Jun 2018 13:05:39 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.88]) by ORSMSX116.amr.corp.intel.com ([169.254.7.230]) with mapi id 14.03.0319.002; Mon, 4 Jun 2018 13:05:39 -0700 From: "Kinney, Michael D" To: "Zhu, Yonghong" , "edk2-devel@lists.01.org" , "Kinney, Michael D" CC: "Shaw, Kevin W" , "Gao, Liming" Thread-Topic: [edk2] [Patch 1/5] Build Spec: Add !error statement support Thread-Index: AQHT+Ho/MKZXjhR56U+X+BRKgzhiOqRQjXJA Date: Mon, 4 Jun 2018 20:05:38 +0000 Message-ID: References: <1527728184-1736-1-git-send-email-yonghong.zhu@intel.com> In-Reply-To: <1527728184-1736-1-git-send-email-yonghong.zhu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Subject: Re: [Patch 1/5] Build Spec: Add !error statement support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jun 2018 20:05:41 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Yonghong, I think it should be stated that the build tool also returns an error code. This allows scripts that invoke build to check the returned error code. Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel- > bounces@lists.01.org] On Behalf Of Yonghong Zhu > Sent: Wednesday, May 30, 2018 5:56 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; > Shaw, Kevin W ; Gao, Liming > > Subject: [edk2] [Patch 1/5] Build Spec: Add !error > statement support >=20 > Cc: Liming Gao > Cc: Michael Kinney > Cc: Kevin W Shaw > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Yonghong Zhu > --- > 8_pre-build_autogen_stage/82_auto-generation_process.md > | 6 ++++++ > README.md > | 3 ++- > 2 files changed, 8 insertions(+), 1 deletion(-) >=20 > diff --git a/8_pre-build_autogen_stage/82_auto- > generation_process.md b/8_pre- > build_autogen_stage/82_auto-generation_process.md > index 8f8f29b..abfa55c 100644 > --- a/8_pre-build_autogen_stage/82_auto- > generation_process.md > +++ b/8_pre-build_autogen_stage/82_auto- > generation_process.md > @@ -1058,10 +1058,16 @@ hash value file into the > directory specified by binary-destination at the build > When --hash and --binary-source are specified, build > tool will try to get the binary > files from the binary source directory at the build > phase. If the cached binary has > the same hash value, it will be directly used. > Otherwise, build tool will compile the > source files and generate the binary files. >=20 > +#### 8.2.4.16 !error Statement > + > +The DSC and FDF file can use `!error` statement. The > argument of this statement is an > +error message, it causes build tool to stop at the > location where the statement is > +encountered and error message following the `!error` > statement is output as a message. > + > ### 8.2.5 Post processing >=20 > Once all files are parsed, the build tools will do > following work for each EDK > II module: >=20 > diff --git a/README.md b/README.md > index 18e46c9..9ca8733 100644 > --- a/README.md > +++ b/README.md > @@ -223,6 +223,7 @@ Copyright (c) 2008-2017, Intel > Corporation. All rights reserved. > | | > [#775](https://bugzilla.tianocore.org/show_bug.cgi?id=3D77 > 5) Build spec: Add description about auto detect thread > number > | | > | | Add Flexible PCD value format into spec > | | > | | Update PCD value and SKU, DefaultStore > info in build report > | | > | | Clarify structure PCD field value > assignment precedence > | | > | | Update description for build handles > PCDs for SKU support > | | > -| | Add statement about module scoped > `` section override scope > | | > +| | Add statement about module scoped > `` section override scope > | | > +| | Add !error statement section > | | > -- > 2.6.1.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel