From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=michael.d.kinney@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 393CF210C42B9 for ; Fri, 27 Jul 2018 22:55:27 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jul 2018 22:55:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,412,1526367600"; d="scan'208";a="70645079" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by orsmga003.jf.intel.com with ESMTP; 27 Jul 2018 22:55:26 -0700 Received: from orsmsx155.amr.corp.intel.com (10.22.240.21) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 27 Jul 2018 22:55:26 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.96]) by ORSMSX155.amr.corp.intel.com ([169.254.7.59]) with mapi id 14.03.0319.002; Fri, 27 Jul 2018 22:55:25 -0700 From: "Kinney, Michael D" To: "Zeng, Star" , "edk2-devel@lists.01.org" , "Kinney, Michael D" Thread-Topic: [staging/FmpDevicePkg-master][PATCH] FmpDevicePkg: Remove DisplayUpdateProgressLib mapping for FmpDxe Thread-Index: AQHUJhBHOBuHPnR3G0iY9s0j16CEFKSkIvnw Date: Sat, 28 Jul 2018 05:55:25 +0000 Message-ID: References: <1532740442-5160-1-git-send-email-star.zeng@intel.com> In-Reply-To: <1532740442-5160-1-git-send-email-star.zeng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Subject: Re: [staging/FmpDevicePkg-master][PATCH] FmpDevicePkg: Remove DisplayUpdateProgressLib mapping for FmpDxe X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Jul 2018 05:55:27 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Michael D Kinney Mike > -----Original Message----- > From: Zeng, Star > Sent: Friday, July 27, 2018 6:14 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Kinney, Michael D > > Subject: [staging/FmpDevicePkg-master][PATCH] > FmpDevicePkg: Remove DisplayUpdateProgressLib mapping > for FmpDxe >=20 > FmpDxe does not consume DisplayUpdateProgressLib, so > remove the > mapping in FmpDevicePkg.dsc. > Also rename the ESRT GUIDs. >=20 > Cc: Michael D Kinney > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Star Zeng > --- > FmpDevicePkg/FmpDevicePkg.dsc | 14 +++++--------- > 1 file changed, 5 insertions(+), 9 deletions(-) >=20 > diff --git a/FmpDevicePkg/FmpDevicePkg.dsc > b/FmpDevicePkg/FmpDevicePkg.dsc > index 525640de2e1b..8d2436627dae 100644 > --- a/FmpDevicePkg/FmpDevicePkg.dsc > +++ b/FmpDevicePkg/FmpDevicePkg.dsc > @@ -43,8 +43,8 @@ [Defines] > # > # Define ESRT GUIDs for Firmware Management Protocol > instances > # > - DEFINE FMP_GRAPHICS_ESRT_GUID =3D B461B3BD-E62A-4A71- > 841C-50BA4E500267 > - DEFINE FMP_TEXT_ESRT_GUID =3D 226034C4-8B67-4536- > 8653-D6EE7CE5A316 > + DEFINE SYSTEM_FMP_ESRT_GUID =3D B461B3BD-E62A-4A71- > 841C-50BA4E500267 > + DEFINE DEVICE_FMP_ESRT_GUID =3D 226034C4-8B67-4536- > 8653-D6EE7CE5A316 >=20 > [LibraryClasses] >=20 > UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoin > t/UefiDriverEntryPoint.inf > @@ -116,11 +116,9 @@ [Components] > FmpDevicePkg/FmpDxe/FmpDxe.inf { > > # > - # FILE_GUID is FMP ESRT GUID > + # FILE_GUID is used as ESRT GUID > # > - FILE_GUID =3D $(FMP_GRAPHICS_ESRT_GUID) > - > - > DisplayUpdateProgressLib|MdeModulePkg/Library/DisplayUp > dateProgressLibGraphics/DisplayUpdateProgressLibGraphic > s.inf > + FILE_GUID =3D $(SYSTEM_FMP_ESRT_GUID) > } >=20 > FmpDevicePkg/FmpDxe/FmpDxe.inf { > @@ -128,9 +126,7 @@ [Components] > # > # FILE_GUID is used as ESRT GUID > # > - FILE_GUID =3D $(FMP_TEXT_ESRT_GUID) > - > - > DisplayUpdateProgressLib|MdeModulePkg/Library/DisplayUp > dateProgressLibText/DisplayUpdateProgressLibText.inf > + FILE_GUID =3D $(DEVICE_FMP_ESRT_GUID) > } >=20 > [BuildOptions] > -- > 2.7.0.windows.1