From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.120; helo=mga04.intel.com; envelope-from=michael.d.kinney@intel.com; receiver=edk2-devel@lists.01.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8855C210C42C4 for ; Fri, 27 Jul 2018 23:01:24 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jul 2018 23:01:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,412,1526367600"; d="scan'208";a="78541288" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by orsmga002.jf.intel.com with ESMTP; 27 Jul 2018 23:01:23 -0700 Received: from orsmsx152.amr.corp.intel.com (10.22.226.39) by ORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 27 Jul 2018 23:01:23 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.96]) by ORSMSX152.amr.corp.intel.com ([169.254.8.83]) with mapi id 14.03.0319.002; Fri, 27 Jul 2018 23:01:23 -0700 From: "Kinney, Michael D" To: "Zeng, Star" , "edk2-devel@lists.01.org" , "Kinney, Michael D" CC: "Zeng, Star" Thread-Topic: [edk2] [staging/FmpDevicePkg-master][PATCH] FmpDevicePkg FmpDxe: Add comment in mFmpDeviceLocked's declaration Thread-Index: AQHUJhaIizBp4jwQwUG9iXgFDO0a8aSkI32Q Date: Sat, 28 Jul 2018 06:01:22 +0000 Message-ID: References: <1532743124-15120-1-git-send-email-star.zeng@intel.com> In-Reply-To: <1532743124-15120-1-git-send-email-star.zeng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Subject: Re: [staging/FmpDevicePkg-master][PATCH] FmpDevicePkg FmpDxe: Add comment in mFmpDeviceLocked's declaration X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Jul 2018 06:01:24 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Star, I recommend using the following comment to describe this module global variable. // // Indicates if an attempt has been made to lock a=20 // FLASH storage device by calling FmpDeviceLock(). // A FLASH storage device may not support being locked, // so this variable is set to TRUE even if FmpDeviceLock() // returns an error. // Thanks, Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel- > bounces@lists.01.org] On Behalf Of Star Zeng > Sent: Friday, July 27, 2018 6:59 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; > Zeng, Star > Subject: [edk2] [staging/FmpDevicePkg-master][PATCH] > FmpDevicePkg FmpDxe: Add comment in mFmpDeviceLocked's > declaration >=20 > Add comment in mFmpDeviceLocked's declaration to make > it more clear. >=20 > Cc: Michael D Kinney > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Star Zeng > --- > FmpDevicePkg/FmpDxe/FmpDxe.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c > b/FmpDevicePkg/FmpDxe/FmpDxe.c > index 94fdf5608529..37bcaf19ec6d 100644 > --- a/FmpDevicePkg/FmpDxe/FmpDxe.c > +++ b/FmpDevicePkg/FmpDxe/FmpDxe.c > @@ -89,6 +89,10 @@ UINT64 mImageId =3D 0x1; > CHAR16 *mVersionName =3D NULL; >=20 > EFI_EVENT mFmpDeviceLockEvent; > +// > +// Indicates whether the FMP device is locked / the > lock operation is attempted or not. > +// It will be set to TRUE after calling > FmpDeviceLock(). > +// > BOOLEAN mFmpDeviceLocked =3D FALSE; >=20 > /** > -- > 2.7.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel