* [staging/FmpDevicePkg-master][PATCH] FmpDevicePkg FmpDxe: Return UNSUPPORTED if device has been locked
@ 2018-07-28 13:58 Star Zeng
2018-07-29 16:39 ` Kinney, Michael D
0 siblings, 1 reply; 2+ messages in thread
From: Star Zeng @ 2018-07-28 13:58 UTC (permalink / raw)
To: edk2-devel; +Cc: Star Zeng, Michael D Kinney
Instead of EFI_ACCESS_DENIED which is not defined in retval by
UEFI spec, return UNSUPPORTED if device has been locked in
SetTheImage().
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
FmpDevicePkg/FmpDxe/FmpDxe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c b/FmpDevicePkg/FmpDxe/FmpDxe.c
index fb02e34f708f..b25a1511c70c 100644
--- a/FmpDevicePkg/FmpDxe/FmpDxe.c
+++ b/FmpDevicePkg/FmpDxe/FmpDxe.c
@@ -928,7 +928,7 @@ SetTheImage (
//
if (mFmpDeviceLocked) {
DEBUG ((DEBUG_ERROR, "FmpDxe: SetTheImage() - Device is already locked. Can't update.\n"));
- Status = EFI_ACCESS_DENIED;
+ Status = EFI_UNSUPPORTED;
goto cleanup;
}
--
2.7.0.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [staging/FmpDevicePkg-master][PATCH] FmpDevicePkg FmpDxe: Return UNSUPPORTED if device has been locked
2018-07-28 13:58 [staging/FmpDevicePkg-master][PATCH] FmpDevicePkg FmpDxe: Return UNSUPPORTED if device has been locked Star Zeng
@ 2018-07-29 16:39 ` Kinney, Michael D
0 siblings, 0 replies; 2+ messages in thread
From: Kinney, Michael D @ 2018-07-29 16:39 UTC (permalink / raw)
To: Zeng, Star, edk2-devel@lists.01.org, Kinney, Michael D
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Mike
> -----Original Message-----
> From: Zeng, Star
> Sent: Saturday, July 28, 2018 6:58 AM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: [staging/FmpDevicePkg-master][PATCH]
> FmpDevicePkg FmpDxe: Return UNSUPPORTED if device has
> been locked
>
> Instead of EFI_ACCESS_DENIED which is not defined in
> retval by
> UEFI spec, return UNSUPPORTED if device has been locked
> in
> SetTheImage().
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
> FmpDevicePkg/FmpDxe/FmpDxe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c
> b/FmpDevicePkg/FmpDxe/FmpDxe.c
> index fb02e34f708f..b25a1511c70c 100644
> --- a/FmpDevicePkg/FmpDxe/FmpDxe.c
> +++ b/FmpDevicePkg/FmpDxe/FmpDxe.c
> @@ -928,7 +928,7 @@ SetTheImage (
> //
> if (mFmpDeviceLocked) {
> DEBUG ((DEBUG_ERROR, "FmpDxe: SetTheImage() -
> Device is already locked. Can't update.\n"));
> - Status = EFI_ACCESS_DENIED;
> + Status = EFI_UNSUPPORTED;
> goto cleanup;
> }
>
> --
> 2.7.0.windows.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-29 16:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-28 13:58 [staging/FmpDevicePkg-master][PATCH] FmpDevicePkg FmpDxe: Return UNSUPPORTED if device has been locked Star Zeng
2018-07-29 16:39 ` Kinney, Michael D
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox