From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=michael.d.kinney@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 32119210C4DA9 for ; Sun, 29 Jul 2018 09:39:50 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jul 2018 09:39:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,419,1526367600"; d="scan'208";a="249352676" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by fmsmga005.fm.intel.com with ESMTP; 29 Jul 2018 09:39:47 -0700 Received: from orsmsx116.amr.corp.intel.com (10.22.240.14) by ORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sun, 29 Jul 2018 09:39:40 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.96]) by ORSMSX116.amr.corp.intel.com ([169.254.7.98]) with mapi id 14.03.0319.002; Sun, 29 Jul 2018 09:39:40 -0700 From: "Kinney, Michael D" To: "Zeng, Star" , "edk2-devel@lists.01.org" , "Kinney, Michael D" Thread-Topic: [staging/FmpDevicePkg-master][PATCH] FmpDevicePkg FmpDxe: Return UNSUPPORTED if device has been locked Thread-Index: AQHUJnsGNhZ9ZvrZ20ehA/5NqmhEL6SmaHqg Date: Sun, 29 Jul 2018 16:39:39 +0000 Message-ID: References: <1532786284-13512-1-git-send-email-star.zeng@intel.com> In-Reply-To: <1532786284-13512-1-git-send-email-star.zeng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Subject: Re: [staging/FmpDevicePkg-master][PATCH] FmpDevicePkg FmpDxe: Return UNSUPPORTED if device has been locked X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Jul 2018 16:39:50 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Michael D Kinney Mike > -----Original Message----- > From: Zeng, Star > Sent: Saturday, July 28, 2018 6:58 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Kinney, Michael D > > Subject: [staging/FmpDevicePkg-master][PATCH] > FmpDevicePkg FmpDxe: Return UNSUPPORTED if device has > been locked >=20 > Instead of EFI_ACCESS_DENIED which is not defined in > retval by > UEFI spec, return UNSUPPORTED if device has been locked > in > SetTheImage(). >=20 > Cc: Michael D Kinney > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Star Zeng > --- > FmpDevicePkg/FmpDxe/FmpDxe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c > b/FmpDevicePkg/FmpDxe/FmpDxe.c > index fb02e34f708f..b25a1511c70c 100644 > --- a/FmpDevicePkg/FmpDxe/FmpDxe.c > +++ b/FmpDevicePkg/FmpDxe/FmpDxe.c > @@ -928,7 +928,7 @@ SetTheImage ( > // > if (mFmpDeviceLocked) { > DEBUG ((DEBUG_ERROR, "FmpDxe: SetTheImage() - > Device is already locked. Can't update.\n")); > - Status =3D EFI_ACCESS_DENIED; > + Status =3D EFI_UNSUPPORTED; > goto cleanup; > } >=20 > -- > 2.7.0.windows.1