* [staging/FmpDevicePkg-master][PATCH V2] FmpDevicePkg FmpDxe: Initialize DeviceLibLowestSupportedVersion
@ 2018-07-30 6:02 Star Zeng
2018-07-31 2:13 ` Kinney, Michael D
0 siblings, 1 reply; 2+ messages in thread
From: Star Zeng @ 2018-07-30 6:02 UTC (permalink / raw)
To: edk2-devel; +Cc: Star Zeng, Michael D Kinney
Some static tool reports "DeviceLibLowestSupportedVersion" is used,
but is uninitialized. It is false positive reporting based because
DeviceLibLowestSupportedVersion will have assigned value after
FmpDeviceGetLowestSupportedVersion() returns SUCCESS.
This patch updates the code to initialize
DeviceLibLowestSupportedVersion
to DEFAULT_LOWESTSUPPORTEDVERSION before calling
FmpDeviceGetLowestSupportedVersion().
It can pass the static tool's check.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
FmpDevicePkg/FmpDxe/FmpDxe.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c b/FmpDevicePkg/FmpDxe/FmpDxe.c
index b25a1511c70c..095cebaa7507 100644
--- a/FmpDevicePkg/FmpDxe/FmpDxe.c
+++ b/FmpDevicePkg/FmpDxe/FmpDxe.c
@@ -229,6 +229,7 @@ GetLowestSupportedVersion (
//
// Check the FmpDeviceLib
//
+ DeviceLibLowestSupportedVersion = DEFAULT_LOWESTSUPPORTEDVERSION;
Status = FmpDeviceGetLowestSupportedVersion (&DeviceLibLowestSupportedVersion);
if (EFI_ERROR (Status)) {
DeviceLibLowestSupportedVersion = DEFAULT_LOWESTSUPPORTEDVERSION;
--
2.7.0.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [staging/FmpDevicePkg-master][PATCH V2] FmpDevicePkg FmpDxe: Initialize DeviceLibLowestSupportedVersion
2018-07-30 6:02 [staging/FmpDevicePkg-master][PATCH V2] FmpDevicePkg FmpDxe: Initialize DeviceLibLowestSupportedVersion Star Zeng
@ 2018-07-31 2:13 ` Kinney, Michael D
0 siblings, 0 replies; 2+ messages in thread
From: Kinney, Michael D @ 2018-07-31 2:13 UTC (permalink / raw)
To: Zeng, Star, edk2-devel@lists.01.org, Kinney, Michael D
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Mike
> -----Original Message-----
> From: Zeng, Star
> Sent: Sunday, July 29, 2018 11:02 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: [staging/FmpDevicePkg-master][PATCH V2]
> FmpDevicePkg FmpDxe: Initialize
> DeviceLibLowestSupportedVersion
>
> Some static tool reports
> "DeviceLibLowestSupportedVersion" is used,
> but is uninitialized. It is false positive reporting
> based because
> DeviceLibLowestSupportedVersion will have assigned
> value after
> FmpDeviceGetLowestSupportedVersion() returns SUCCESS.
>
> This patch updates the code to initialize
> DeviceLibLowestSupportedVersion
> to DEFAULT_LOWESTSUPPORTEDVERSION before calling
> FmpDeviceGetLowestSupportedVersion().
> It can pass the static tool's check.
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
> FmpDevicePkg/FmpDxe/FmpDxe.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c
> b/FmpDevicePkg/FmpDxe/FmpDxe.c
> index b25a1511c70c..095cebaa7507 100644
> --- a/FmpDevicePkg/FmpDxe/FmpDxe.c
> +++ b/FmpDevicePkg/FmpDxe/FmpDxe.c
> @@ -229,6 +229,7 @@ GetLowestSupportedVersion (
> //
> // Check the FmpDeviceLib
> //
> + DeviceLibLowestSupportedVersion =
> DEFAULT_LOWESTSUPPORTEDVERSION;
> Status = FmpDeviceGetLowestSupportedVersion
> (&DeviceLibLowestSupportedVersion);
> if (EFI_ERROR (Status)) {
> DeviceLibLowestSupportedVersion =
> DEFAULT_LOWESTSUPPORTEDVERSION;
> --
> 2.7.0.windows.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-31 2:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-30 6:02 [staging/FmpDevicePkg-master][PATCH V2] FmpDevicePkg FmpDxe: Initialize DeviceLibLowestSupportedVersion Star Zeng
2018-07-31 2:13 ` Kinney, Michael D
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox