From: "Kinney, Michael D" <michael.d.kinney@intel.com>
To: "Zeng, Star" <star.zeng@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "Bi, Dandan" <dandan.bi@intel.com>,
"Gao, Liming" <liming.gao@intel.com>,
"Zeng, Star" <star.zeng@intel.com>,
"Chen, Hesheng" <hesheng.chen@intel.com>
Subject: Re: [PATCH] MdePkg FirmwareManagement.h: Fix code style issue
Date: Tue, 31 Jul 2018 02:15:55 +0000 [thread overview]
Message-ID: <E92EE9817A31E24EB0585FDF735412F5B8A9D8FF@ORSMSX113.amr.corp.intel.com> (raw)
In-Reply-To: <1532943889-5000-1-git-send-email-star.zeng@intel.com>
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Mike
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-
> bounces@lists.01.org] On Behalf Of Star Zeng
> Sent: Monday, July 30, 2018 2:45 AM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Bi,
> Dandan <dandan.bi@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Zeng, Star
> <star.zeng@intel.com>; Chen, Hesheng
> <hesheng.chen@intel.com>
> Subject: [edk2] [PATCH] MdePkg FirmwareManagement.h:
> Fix code style issue
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Hess Chen <hesheng.chen@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
> MdePkg/Include/Protocol/FirmwareManagement.h | 8 ++++-
> ---
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git
> a/MdePkg/Include/Protocol/FirmwareManagement.h
> b/MdePkg/Include/Protocol/FirmwareManagement.h
> index 7c8f1ce65ded..fdd5a7f2a34c 100644
> --- a/MdePkg/Include/Protocol/FirmwareManagement.h
> +++ b/MdePkg/Include/Protocol/FirmwareManagement.h
> @@ -317,11 +317,11 @@ EFI_STATUS
> This function allows a copy of the current firmware
> image to be created and saved.
> The saved copy could later been used, for example,
> in firmware image recovery or rollback.
>
> - @param[in] This A pointer to the
> EFI_FIRMWARE_MANAGEMENT_PROTOCOL instance.
> - @param[in] ImageIndex A unique number
> identifying the firmware image(s) within the device.
> + @param[in] This A pointer to the
> EFI_FIRMWARE_MANAGEMENT_PROTOCOL instance.
> + @param[in] ImageIndex A unique number
> identifying the firmware image(s) within the device.
> The number is between
> 1 and DescriptorCount.
> - @param[out] Image Points to the buffer
> where the current image is copied to.
> - @param[out] ImageSize On entry, points to
> the size of the buffer pointed to by Image, in bytes.
> + @param[in, out] Image Points to the buffer
> where the current image is copied to.
> + @param[in, out] ImageSize On entry, points to
> the size of the buffer pointed to by Image, in bytes.
> On return, points to
> the length of the image, in bytes.
>
> @retval EFI_SUCCESS The device was
> successfully updated with the new image.
> --
> 2.7.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2018-07-31 2:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 9:44 [PATCH] MdePkg FirmwareManagement.h: Fix code style issue Star Zeng
2018-07-31 0:44 ` Bi, Dandan
2018-07-31 2:15 ` Kinney, Michael D [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E92EE9817A31E24EB0585FDF735412F5B8A9D8FF@ORSMSX113.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox