* [PATCH] MdePkg FirmwareManagement.h: Fix code style issue
@ 2018-07-30 9:44 Star Zeng
2018-07-31 0:44 ` Bi, Dandan
2018-07-31 2:15 ` Kinney, Michael D
0 siblings, 2 replies; 3+ messages in thread
From: Star Zeng @ 2018-07-30 9:44 UTC (permalink / raw)
To: edk2-devel; +Cc: Star Zeng, Michael D Kinney, Liming Gao, Dandan Bi, Hess Chen
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
Cc: Hess Chen <hesheng.chen@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
MdePkg/Include/Protocol/FirmwareManagement.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/MdePkg/Include/Protocol/FirmwareManagement.h b/MdePkg/Include/Protocol/FirmwareManagement.h
index 7c8f1ce65ded..fdd5a7f2a34c 100644
--- a/MdePkg/Include/Protocol/FirmwareManagement.h
+++ b/MdePkg/Include/Protocol/FirmwareManagement.h
@@ -317,11 +317,11 @@ EFI_STATUS
This function allows a copy of the current firmware image to be created and saved.
The saved copy could later been used, for example, in firmware image recovery or rollback.
- @param[in] This A pointer to the EFI_FIRMWARE_MANAGEMENT_PROTOCOL instance.
- @param[in] ImageIndex A unique number identifying the firmware image(s) within the device.
+ @param[in] This A pointer to the EFI_FIRMWARE_MANAGEMENT_PROTOCOL instance.
+ @param[in] ImageIndex A unique number identifying the firmware image(s) within the device.
The number is between 1 and DescriptorCount.
- @param[out] Image Points to the buffer where the current image is copied to.
- @param[out] ImageSize On entry, points to the size of the buffer pointed to by Image, in bytes.
+ @param[in, out] Image Points to the buffer where the current image is copied to.
+ @param[in, out] ImageSize On entry, points to the size of the buffer pointed to by Image, in bytes.
On return, points to the length of the image, in bytes.
@retval EFI_SUCCESS The device was successfully updated with the new image.
--
2.7.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] MdePkg FirmwareManagement.h: Fix code style issue
2018-07-30 9:44 [PATCH] MdePkg FirmwareManagement.h: Fix code style issue Star Zeng
@ 2018-07-31 0:44 ` Bi, Dandan
2018-07-31 2:15 ` Kinney, Michael D
1 sibling, 0 replies; 3+ messages in thread
From: Bi, Dandan @ 2018-07-31 0:44 UTC (permalink / raw)
To: Zeng, Star, edk2-devel@lists.01.org
Cc: Kinney, Michael D, Gao, Liming, Zeng, Star, Chen, Hesheng
Reviewed-by: Dandan Bi <dandan.bi@intel.com>
Thanks,
Dandan
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Star Zeng
Sent: Monday, July 30, 2018 5:45 PM
To: edk2-devel@lists.01.org
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Bi, Dandan <dandan.bi@intel.com>; Gao, Liming <liming.gao@intel.com>; Zeng, Star <star.zeng@intel.com>; Chen, Hesheng <hesheng.chen@intel.com>
Subject: [edk2] [PATCH] MdePkg FirmwareManagement.h: Fix code style issue
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
Cc: Hess Chen <hesheng.chen@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
MdePkg/Include/Protocol/FirmwareManagement.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/MdePkg/Include/Protocol/FirmwareManagement.h b/MdePkg/Include/Protocol/FirmwareManagement.h
index 7c8f1ce65ded..fdd5a7f2a34c 100644
--- a/MdePkg/Include/Protocol/FirmwareManagement.h
+++ b/MdePkg/Include/Protocol/FirmwareManagement.h
@@ -317,11 +317,11 @@ EFI_STATUS
This function allows a copy of the current firmware image to be created and saved.
The saved copy could later been used, for example, in firmware image recovery or rollback.
- @param[in] This A pointer to the EFI_FIRMWARE_MANAGEMENT_PROTOCOL instance.
- @param[in] ImageIndex A unique number identifying the firmware image(s) within the device.
+ @param[in] This A pointer to the EFI_FIRMWARE_MANAGEMENT_PROTOCOL instance.
+ @param[in] ImageIndex A unique number identifying the firmware image(s) within the device.
The number is between 1 and DescriptorCount.
- @param[out] Image Points to the buffer where the current image is copied to.
- @param[out] ImageSize On entry, points to the size of the buffer pointed to by Image, in bytes.
+ @param[in, out] Image Points to the buffer where the current image is copied to.
+ @param[in, out] ImageSize On entry, points to the size of the buffer pointed to by Image, in bytes.
On return, points to the length of the image, in bytes.
@retval EFI_SUCCESS The device was successfully updated with the new image.
--
2.7.0.windows.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] MdePkg FirmwareManagement.h: Fix code style issue
2018-07-30 9:44 [PATCH] MdePkg FirmwareManagement.h: Fix code style issue Star Zeng
2018-07-31 0:44 ` Bi, Dandan
@ 2018-07-31 2:15 ` Kinney, Michael D
1 sibling, 0 replies; 3+ messages in thread
From: Kinney, Michael D @ 2018-07-31 2:15 UTC (permalink / raw)
To: Zeng, Star, edk2-devel@lists.01.org, Kinney, Michael D
Cc: Bi, Dandan, Gao, Liming, Zeng, Star, Chen, Hesheng
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
Mike
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-
> bounces@lists.01.org] On Behalf Of Star Zeng
> Sent: Monday, July 30, 2018 2:45 AM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Bi,
> Dandan <dandan.bi@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Zeng, Star
> <star.zeng@intel.com>; Chen, Hesheng
> <hesheng.chen@intel.com>
> Subject: [edk2] [PATCH] MdePkg FirmwareManagement.h:
> Fix code style issue
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Hess Chen <hesheng.chen@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
> MdePkg/Include/Protocol/FirmwareManagement.h | 8 ++++-
> ---
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git
> a/MdePkg/Include/Protocol/FirmwareManagement.h
> b/MdePkg/Include/Protocol/FirmwareManagement.h
> index 7c8f1ce65ded..fdd5a7f2a34c 100644
> --- a/MdePkg/Include/Protocol/FirmwareManagement.h
> +++ b/MdePkg/Include/Protocol/FirmwareManagement.h
> @@ -317,11 +317,11 @@ EFI_STATUS
> This function allows a copy of the current firmware
> image to be created and saved.
> The saved copy could later been used, for example,
> in firmware image recovery or rollback.
>
> - @param[in] This A pointer to the
> EFI_FIRMWARE_MANAGEMENT_PROTOCOL instance.
> - @param[in] ImageIndex A unique number
> identifying the firmware image(s) within the device.
> + @param[in] This A pointer to the
> EFI_FIRMWARE_MANAGEMENT_PROTOCOL instance.
> + @param[in] ImageIndex A unique number
> identifying the firmware image(s) within the device.
> The number is between
> 1 and DescriptorCount.
> - @param[out] Image Points to the buffer
> where the current image is copied to.
> - @param[out] ImageSize On entry, points to
> the size of the buffer pointed to by Image, in bytes.
> + @param[in, out] Image Points to the buffer
> where the current image is copied to.
> + @param[in, out] ImageSize On entry, points to
> the size of the buffer pointed to by Image, in bytes.
> On return, points to
> the length of the image, in bytes.
>
> @retval EFI_SUCCESS The device was
> successfully updated with the new image.
> --
> 2.7.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-31 2:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-30 9:44 [PATCH] MdePkg FirmwareManagement.h: Fix code style issue Star Zeng
2018-07-31 0:44 ` Bi, Dandan
2018-07-31 2:15 ` Kinney, Michael D
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox