From: "Kinney, Michael D" <michael.d.kinney@intel.com>
To: "Zeng, Star" <star.zeng@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [PATCH] FmpDevicePkg: Remove useless lib mapping in dsc
Date: Wed, 1 Aug 2018 14:14:55 +0000 [thread overview]
Message-ID: <E92EE9817A31E24EB0585FDF735412F5B8A9F84C@ORSMSX113.amr.corp.intel.com> (raw)
In-Reply-To: <1533119422-9408-1-git-send-email-star.zeng@intel.com>
Star,
The ARM and AARCH64 specific lib mappings should not be removed.
That will break the FmpDevicePkg build for ARM and AARCH64.
Mike
> -----Original Message-----
> From: Zeng, Star
> Sent: Wednesday, August 1, 2018 3:30 AM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: [PATCH] FmpDevicePkg: Remove useless lib
> mapping in dsc
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>
>
> NOTE: This patch is based on thread
> https://lists.01.org/pipermail/edk2-devel/2018-
> July/027810.html.
>
> ---
> FmpDevicePkg/FmpDevicePkg.dsc | 34 -------------------
> ---------------
> 1 file changed, 34 deletions(-)
>
> diff --git a/FmpDevicePkg/FmpDevicePkg.dsc
> b/FmpDevicePkg/FmpDevicePkg.dsc
> index 8d2436627dae..c04cb0efe86e 100644
> --- a/FmpDevicePkg/FmpDevicePkg.dsc
> +++ b/FmpDevicePkg/FmpDevicePkg.dsc
> @@ -48,58 +48,24 @@ [Defines]
>
> [LibraryClasses]
>
> UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoin
> t/UefiDriverEntryPoint.inf
> -
> UefiApplicationEntryPoint|MdePkg/Library/UefiApplicatio
> nEntryPoint/UefiApplicationEntryPoint.inf
>
> UefiBootServicesTableLib|MdePkg/Library/UefiBootService
> sTableLib/UefiBootServicesTableLib.inf
> UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
>
> UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeS
> ervicesTableLib/UefiRuntimeServicesTableLib.inf
> -
> UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntim
> eLib.inf
>
> MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocation
> Lib/UefiMemoryAllocationLib.inf
>
> DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevi
> cePathLib.inf
> - UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf
> -
> UefiScsiLib|MdePkg/Library/UefiScsiLib/UefiScsiLib.inf
> BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
>
> BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLi
> b.inf
> -
> SynchronizationLib|MdePkg/Library/BaseSynchronizationLi
> b/BaseSynchronizationLib.inf
>
> PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
>
> DebugLib|MdePkg/Library/UefiDebugLibStdErr/UefiDebugLib
> StdErr.inf
>
> DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintEr
> rorLevelLib/BaseDebugPrintErrorLevelLib.inf
> -
> PostCodeLib|MdePkg/Library/BasePostCodeLibPort80/BasePo
> stCodeLibPort80.inf
>
> PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
> -
> DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeService
> sLib.inf
> -
> -
> UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeS
> ervicesTableLib/UefiRuntimeServicesTableLib.inf
> - UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
> -
> DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevi
> cePathLib.inf
> -
> UefiBootManagerLib|MdeModulePkg/Library/UefiBootManager
> Lib/UefiBootManagerLib.inf
> -
> DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/
> DxeServicesTableLib.inf
> -
> MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocation
> Lib/UefiMemoryAllocationLib.inf
> - HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
>
> OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
>
> IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLi
> b.inf
>
> BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLi
> b.inf
>
> FmpAuthenticationLib|SecurityPkg/Library/FmpAuthenticat
> ionLibPkcs7/FmpAuthenticationLibPkcs7.inf
> -
>
> CapsuleUpdatePolicyLib|FmpDevicePkg/Library/CapsuleUpda
> tePolicyLibNull/CapsuleUpdatePolicyLibNull.inf
>
> FmpPayloadHeaderLib|FmpDevicePkg/Library/FmpPayloadHead
> erLibV1/FmpPayloadHeaderLibV1.inf
>
> FmpDeviceLib|FmpDevicePkg/Library/FmpDeviceLibNull/FmpD
> eviceLibNull.inf
> -
> BmpSupportLib|MdeModulePkg/Library/BaseBmpSupportLib/Ba
> seBmpSupportLib.inf
> -
> SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib
> .inf
> -
> CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCap
> suleLib.inf
> -
> -[LibraryClasses.ARM, LibraryClasses.AARCH64]
> - #
> - # It is not possible to prevent the ARM compiler for
> generic intrinsic functions.
> - # This library provides the instrinsic functions
> generate by a given compiler.
> - # [LibraryClasses.ARM, LibraryClasses.AARCH64] and
> NULL mean link this library
> - # into all ARM and AARCH64 images.
> - #
> -
> NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntri
> nsicsLib.inf
> -
> - # Add support for stack protector
> -
> NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib
> .inf
> -
> -[LibraryClasses.ARM]
> -
> ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftF
> loatLib.inf
>
> [Components]
> #
> --
> 2.7.0.windows.1
next prev parent reply other threads:[~2018-08-01 14:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 10:30 [PATCH] FmpDevicePkg: Remove useless lib mapping in dsc Star Zeng
2018-08-01 14:14 ` Kinney, Michael D [this message]
2018-08-01 23:20 ` Kinney, Michael D
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E92EE9817A31E24EB0585FDF735412F5B8A9F84C@ORSMSX113.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox