From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=michael.d.kinney@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B4CCB210C2D92 for ; Wed, 1 Aug 2018 07:15:07 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Aug 2018 07:15:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,432,1526367600"; d="scan'208";a="250210026" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by fmsmga005.fm.intel.com with ESMTP; 01 Aug 2018 07:14:56 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.96]) by ORSMSX104.amr.corp.intel.com ([169.254.4.198]) with mapi id 14.03.0319.002; Wed, 1 Aug 2018 07:14:55 -0700 From: "Kinney, Michael D" To: "Zeng, Star" , "edk2-devel@lists.01.org" , "Kinney, Michael D" Thread-Topic: [PATCH] FmpDevicePkg: Remove useless lib mapping in dsc Thread-Index: AQHUKYKs47HSs2iSmkCvsIWuptvR1qSq8BTw Date: Wed, 1 Aug 2018 14:14:55 +0000 Message-ID: References: <1533119422-9408-1-git-send-email-star.zeng@intel.com> In-Reply-To: <1533119422-9408-1-git-send-email-star.zeng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Subject: Re: [PATCH] FmpDevicePkg: Remove useless lib mapping in dsc X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Aug 2018 14:15:07 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Star, The ARM and AARCH64 specific lib mappings should not be removed. That will break the FmpDevicePkg build for ARM and AARCH64. Mike > -----Original Message----- > From: Zeng, Star > Sent: Wednesday, August 1, 2018 3:30 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Kinney, Michael D > > Subject: [PATCH] FmpDevicePkg: Remove useless lib > mapping in dsc >=20 > Cc: Michael D Kinney > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Star Zeng >=20 > NOTE: This patch is based on thread > https://lists.01.org/pipermail/edk2-devel/2018- > July/027810.html. >=20 > --- > FmpDevicePkg/FmpDevicePkg.dsc | 34 ------------------- > --------------- > 1 file changed, 34 deletions(-) >=20 > diff --git a/FmpDevicePkg/FmpDevicePkg.dsc > b/FmpDevicePkg/FmpDevicePkg.dsc > index 8d2436627dae..c04cb0efe86e 100644 > --- a/FmpDevicePkg/FmpDevicePkg.dsc > +++ b/FmpDevicePkg/FmpDevicePkg.dsc > @@ -48,58 +48,24 @@ [Defines] >=20 > [LibraryClasses] >=20 > UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoin > t/UefiDriverEntryPoint.inf > - > UefiApplicationEntryPoint|MdePkg/Library/UefiApplicatio > nEntryPoint/UefiApplicationEntryPoint.inf >=20 > UefiBootServicesTableLib|MdePkg/Library/UefiBootService > sTableLib/UefiBootServicesTableLib.inf > UefiLib|MdePkg/Library/UefiLib/UefiLib.inf >=20 > UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeS > ervicesTableLib/UefiRuntimeServicesTableLib.inf > - > UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntim > eLib.inf >=20 > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocation > Lib/UefiMemoryAllocationLib.inf >=20 > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevi > cePathLib.inf > - UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf > - > UefiScsiLib|MdePkg/Library/UefiScsiLib/UefiScsiLib.inf > BaseLib|MdePkg/Library/BaseLib/BaseLib.inf >=20 > BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLi > b.inf > - > SynchronizationLib|MdePkg/Library/BaseSynchronizationLi > b/BaseSynchronizationLib.inf >=20 > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf >=20 > DebugLib|MdePkg/Library/UefiDebugLibStdErr/UefiDebugLib > StdErr.inf >=20 > DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintEr > rorLevelLib/BaseDebugPrintErrorLevelLib.inf > - > PostCodeLib|MdePkg/Library/BasePostCodeLibPort80/BasePo > stCodeLibPort80.inf >=20 > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > - > DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeService > sLib.inf > - > - > UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeS > ervicesTableLib/UefiRuntimeServicesTableLib.inf > - UefiLib|MdePkg/Library/UefiLib/UefiLib.inf > - > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevi > cePathLib.inf > - > UefiBootManagerLib|MdeModulePkg/Library/UefiBootManager > Lib/UefiBootManagerLib.inf > - > DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/ > DxeServicesTableLib.inf > - > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocation > Lib/UefiMemoryAllocationLib.inf > - HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf >=20 > OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf >=20 > IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLi > b.inf >=20 > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLi > b.inf >=20 > FmpAuthenticationLib|SecurityPkg/Library/FmpAuthenticat > ionLibPkcs7/FmpAuthenticationLibPkcs7.inf > - >=20 > CapsuleUpdatePolicyLib|FmpDevicePkg/Library/CapsuleUpda > tePolicyLibNull/CapsuleUpdatePolicyLibNull.inf >=20 > FmpPayloadHeaderLib|FmpDevicePkg/Library/FmpPayloadHead > erLibV1/FmpPayloadHeaderLibV1.inf >=20 > FmpDeviceLib|FmpDevicePkg/Library/FmpDeviceLibNull/FmpD > eviceLibNull.inf > - > BmpSupportLib|MdeModulePkg/Library/BaseBmpSupportLib/Ba > seBmpSupportLib.inf > - > SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib > .inf > - > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCap > suleLib.inf > - > -[LibraryClasses.ARM, LibraryClasses.AARCH64] > - # > - # It is not possible to prevent the ARM compiler for > generic intrinsic functions. > - # This library provides the instrinsic functions > generate by a given compiler. > - # [LibraryClasses.ARM, LibraryClasses.AARCH64] and > NULL mean link this library > - # into all ARM and AARCH64 images. > - # > - > NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntri > nsicsLib.inf > - > - # Add support for stack protector > - > NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib > .inf > - > -[LibraryClasses.ARM] > - > ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftF > loatLib.inf >=20 > [Components] > # > -- > 2.7.0.windows.1