From: "Kinney, Michael D" <michael.d.kinney@intel.com>
To: "Zeng, Star" <star.zeng@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "Ni, Ruiyu" <ruiyu.ni@intel.com>, "Dong, Eric" <eric.dong@intel.com>
Subject: Re: [Patch v5 21/21] MdeModulePkg/BdsDxe: Move display of test key usage into BDS module
Date: Wed, 1 Aug 2018 22:39:25 +0000 [thread overview]
Message-ID: <E92EE9817A31E24EB0585FDF735412F5B8A9FBB5@ORSMSX113.amr.corp.intel.com> (raw)
In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103BB8B58D@shsmsx102.ccr.corp.intel.com>
Star,
I agree. I will integrate into a V6 patch series.
Thanks,
Mike
> -----Original Message-----
> From: Zeng, Star
> Sent: Wednesday, August 1, 2018 12:53 AM
> To: Kinney, Michael D <michael.d.kinney@intel.com>;
> edk2-devel@lists.01.org
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Dong, Eric
> <eric.dong@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: RE: [Patch v5 21/21] MdeModulePkg/BdsDxe: Move
> display of test key usage into BDS module
>
> A very minor comment.
>
> if (PcdGetBool (PcdTestKeyUsed))
> can be used directly instead of
> if (PcdGetBool (PcdTestKeyUsed) == TRUE)
>
> With update, Reviewed-by: Star Zeng
> <star.zeng@intel.com>.
>
>
> Thanks,
> Star
> -----Original Message-----
> From: Kinney, Michael D
> Sent: Wednesday, August 1, 2018 2:55 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Zeng, Star
> <star.zeng@intel.com>; Dong, Eric
> <eric.dong@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: [Patch v5 21/21] MdeModulePkg/BdsDxe: Move
> display of test key usage into BDS module
>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Michael D Kinney
> <michael.d.kinney@intel.com>
> ---
> MdeModulePkg/Universal/BdsDxe/BdsDxe.inf | 1 +
> MdeModulePkg/Universal/BdsDxe/BdsEntry.c | 12
> ++++++++++++
> 2 files changed, 13 insertions(+)
>
> diff --git a/MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
> b/MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
> index 7e644aa995..7030d67907 100644
> --- a/MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
> +++ b/MdeModulePkg/Universal/BdsDxe/BdsDxe.inf
> @@ -100,6 +100,7 @@ [Pcd]
> gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareRevision
> ## CONSUMES
>
> gEfiMdeModulePkgTokenSpaceGuid.PcdConInConnectOnDemand
> ## CONSUMES
>
> gEfiMdeModulePkgTokenSpaceGuid.PcdErrorCodeSetVariable
> ## SOMETIMES_CONSUMES
> + gEfiMdeModulePkgTokenSpaceGuid.PcdTestKeyUsed
> ## CONSUMES
>
> [Depex]
> TRUE
> diff --git a/MdeModulePkg/Universal/BdsDxe/BdsEntry.c
> b/MdeModulePkg/Universal/BdsDxe/BdsEntry.c
> index a25663ea43..b9ca31741e 100644
> --- a/MdeModulePkg/Universal/BdsDxe/BdsEntry.c
> +++ b/MdeModulePkg/Universal/BdsDxe/BdsEntry.c
> @@ -884,6 +884,18 @@ BdsEntry (
>
> PERF_INMODULE_BEGIN("PlatformBootManagerAfterConsole");
> PlatformBootManagerAfterConsole ();
>
> PERF_INMODULE_END("PlatformBootManagerAfterConsole");
> +
> + //
> + // If any component set PcdTestKeyUsed to TRUE
> because use of a test key
> + // was detected, then display a warning message on
> the debug log and the console
> + //
> + if (PcdGetBool (PcdTestKeyUsed) == TRUE) {
> + DEBUG ((DEBUG_ERROR,
> "**********************************\n"));
> + DEBUG ((DEBUG_ERROR, "** WARNING: Test Key is
> used. **\n"));
> + DEBUG ((DEBUG_ERROR,
> "**********************************\n"));
> + Print (L"** WARNING: Test Key is used. **\n");
> + }
> +
> //
> // Boot to Boot Manager Menu when
> EFI_OS_INDICATIONS_BOOT_TO_FW_UI is set. Skip
> HotkeyBoot
> //
> --
> 2.14.2.windows.3
prev parent reply other threads:[~2018-08-01 22:39 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 6:55 [Patch v5 00/21] Add FmpDevicePkg Kinney, Michael D
2018-08-01 6:55 ` [Patch v5 01/21] FmpDevicePkg: Add package, library classes, and PCDs Kinney, Michael D
2018-08-01 7:50 ` Zeng, Star
2018-08-01 6:55 ` [Patch v5 02/21] FmpDevicePkg: Add library instances Kinney, Michael D
2018-08-01 7:50 ` Zeng, Star
2018-08-01 6:55 ` [Patch v5 03/21] FmpDevicePkg: Add FmpDxe module Kinney, Michael D
2018-08-01 7:50 ` Zeng, Star
2018-08-01 6:55 ` [Patch v5 04/21] FmpDevicePkg: Add DSC file to build all package components Kinney, Michael D
2018-08-01 7:50 ` Zeng, Star
2018-08-01 6:55 ` [Patch v5 05/21] FmpDevicePkg FmpDxe: Update function comment for FmpDxeEntryPoint Kinney, Michael D
2018-08-01 6:55 ` [Patch v5 06/21] FmpDevicePkg FmpDxe: Return 0 when LSV check is not required Kinney, Michael D
2018-08-01 6:55 ` [Patch v5 07/21] FmpDevicePkg: Remove IPF Kinney, Michael D
2018-08-01 6:55 ` [Patch v5 08/21] FmpDevicePkg: Add DISABLE_NEW_DEPRECATED_INTERFACES build options Kinney, Michael D
2018-08-01 6:55 ` [Patch v5 09/21] FmpDevicePkg FmpDxe: Check Progress!= NULL before calling Progress(100) Kinney, Michael D
2018-08-01 6:55 ` [Patch v5 10/21] FmpDevicePkg FmpDxe: Add EFI_ABORTED in retval of CheckTheImage() Kinney, Michael D
2018-08-01 6:55 ` [Patch v5 11/21] FmpDevicePkg FmpDxe: Fix typo "EFI_SECURITY_VIOLATIO" Kinney, Michael D
2018-08-01 6:55 ` [Patch v5 12/21] FmpDevicePkg: Remove DisplayUpdateProgressLib mapping for FmpDxe Kinney, Michael D
2018-08-01 6:55 ` [Patch v5 13/21] FmpDevicePkg FmpDxe: Add NULL check to return Value from GetVariable2 Kinney, Michael D
2018-08-01 6:55 ` [Patch v5 14/21] FmpDevicePkg FmpDxe: Check ImageIndex first before Image/ImageSize Kinney, Michael D
2018-08-01 6:55 ` [Patch v5 15/21] FmpDevicePkg FmpDxe: Use Attributes to know whether reset is required Kinney, Michael D
2018-08-01 6:55 ` [Patch v5 16/21] FmpDevicePkg FmpDxe: Add comment in mFmpDeviceLocked's declaration Kinney, Michael D
2018-08-01 6:55 ` [Patch v5 17/21] FmpDevicePkg FmpDxe: Return UNSUPPORTED if device has been locked Kinney, Michael D
2018-08-01 6:55 ` [Patch v5 18/21] FmpDevicePkg FmpDxe: Initialize DeviceLibLowestSupportedVersion Kinney, Michael D
2018-08-01 6:55 ` [Patch v5 19/21] FmpDevicePkg: Fix code style issue Kinney, Michael D
2018-08-01 6:55 ` [Patch v5 20/21] FmpDevicePkg FmpDxe: Use local variable to store test key digest size Kinney, Michael D
2018-08-01 6:55 ` [Patch v5 21/21] MdeModulePkg/BdsDxe: Move display of test key usage into BDS module Kinney, Michael D
2018-08-01 7:53 ` Zeng, Star
2018-08-01 22:39 ` Kinney, Michael D [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E92EE9817A31E24EB0585FDF735412F5B8A9FBB5@ORSMSX113.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox