From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=michael.d.kinney@intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0BEED210D43A6 for ; Wed, 1 Aug 2018 15:39:26 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Aug 2018 15:39:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,433,1526367600"; d="scan'208";a="221014036" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by orsmga004.jf.intel.com with ESMTP; 01 Aug 2018 15:39:26 -0700 Received: from orsmsx155.amr.corp.intel.com (10.22.240.21) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 1 Aug 2018 15:39:25 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.96]) by ORSMSX155.amr.corp.intel.com ([169.254.7.59]) with mapi id 14.03.0319.002; Wed, 1 Aug 2018 15:39:25 -0700 From: "Kinney, Michael D" To: "Zeng, Star" , "edk2-devel@lists.01.org" , "Kinney, Michael D" CC: "Ni, Ruiyu" , "Dong, Eric" Thread-Topic: [Patch v5 21/21] MdeModulePkg/BdsDxe: Move display of test key usage into BDS module Thread-Index: AQHUKWUOI8eKg2cCdkWxiN8TCeu1D6Sq+/cAgACBnhA= Date: Wed, 1 Aug 2018 22:39:25 +0000 Message-ID: References: <20180801065722.9500-1-michael.d.kinney@intel.com> <20180801065722.9500-22-michael.d.kinney@intel.com> <0C09AFA07DD0434D9E2A0C6AEB0483103BB8B58D@shsmsx102.ccr.corp.intel.com> In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103BB8B58D@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Subject: Re: [Patch v5 21/21] MdeModulePkg/BdsDxe: Move display of test key usage into BDS module X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Aug 2018 22:39:27 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Star, I agree. I will integrate into a V6 patch series. Thanks, Mike > -----Original Message----- > From: Zeng, Star > Sent: Wednesday, August 1, 2018 12:53 AM > To: Kinney, Michael D ; > edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Dong, Eric > ; Zeng, Star > Subject: RE: [Patch v5 21/21] MdeModulePkg/BdsDxe: Move > display of test key usage into BDS module >=20 > A very minor comment. >=20 > if (PcdGetBool (PcdTestKeyUsed)) > can be used directly instead of > if (PcdGetBool (PcdTestKeyUsed) =3D=3D TRUE) >=20 > With update, Reviewed-by: Star Zeng > . >=20 >=20 > Thanks, > Star > -----Original Message----- > From: Kinney, Michael D > Sent: Wednesday, August 1, 2018 2:55 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Zeng, Star > ; Dong, Eric > ; Kinney, Michael D > > Subject: [Patch v5 21/21] MdeModulePkg/BdsDxe: Move > display of test key usage into BDS module >=20 > Cc: Ruiyu Ni > Cc: Star Zeng > Cc: Eric Dong > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Michael D Kinney > > --- > MdeModulePkg/Universal/BdsDxe/BdsDxe.inf | 1 + > MdeModulePkg/Universal/BdsDxe/BdsEntry.c | 12 > ++++++++++++ > 2 files changed, 13 insertions(+) >=20 > diff --git a/MdeModulePkg/Universal/BdsDxe/BdsDxe.inf > b/MdeModulePkg/Universal/BdsDxe/BdsDxe.inf > index 7e644aa995..7030d67907 100644 > --- a/MdeModulePkg/Universal/BdsDxe/BdsDxe.inf > +++ b/MdeModulePkg/Universal/BdsDxe/BdsDxe.inf > @@ -100,6 +100,7 @@ [Pcd] > gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareRevision > ## CONSUMES >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdConInConnectOnDemand > ## CONSUMES >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdErrorCodeSetVariable > ## SOMETIMES_CONSUMES > + gEfiMdeModulePkgTokenSpaceGuid.PcdTestKeyUsed > ## CONSUMES >=20 > [Depex] > TRUE > diff --git a/MdeModulePkg/Universal/BdsDxe/BdsEntry.c > b/MdeModulePkg/Universal/BdsDxe/BdsEntry.c > index a25663ea43..b9ca31741e 100644 > --- a/MdeModulePkg/Universal/BdsDxe/BdsEntry.c > +++ b/MdeModulePkg/Universal/BdsDxe/BdsEntry.c > @@ -884,6 +884,18 @@ BdsEntry ( >=20 > PERF_INMODULE_BEGIN("PlatformBootManagerAfterConsole"); > PlatformBootManagerAfterConsole (); >=20 > PERF_INMODULE_END("PlatformBootManagerAfterConsole"); > + > + // > + // If any component set PcdTestKeyUsed to TRUE > because use of a test key > + // was detected, then display a warning message on > the debug log and the console > + // > + if (PcdGetBool (PcdTestKeyUsed) =3D=3D TRUE) { > + DEBUG ((DEBUG_ERROR, > "**********************************\n")); > + DEBUG ((DEBUG_ERROR, "** WARNING: Test Key is > used. **\n")); > + DEBUG ((DEBUG_ERROR, > "**********************************\n")); > + Print (L"** WARNING: Test Key is used. **\n"); > + } > + > // > // Boot to Boot Manager Menu when > EFI_OS_INDICATIONS_BOOT_TO_FW_UI is set. Skip > HotkeyBoot > // > -- > 2.14.2.windows.3