public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Kinney, Michael D" <michael.d.kinney@intel.com>
To: "Zeng, Star" <star.zeng@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [PATCH] FmpDevicePkg FmpDxe: Fix XCODE build failure
Date: Wed, 1 Aug 2018 22:49:13 +0000	[thread overview]
Message-ID: <E92EE9817A31E24EB0585FDF735412F5B8A9FBD1@ORSMSX113.amr.corp.intel.com> (raw)
In-Reply-To: <1533119470-33260-1-git-send-email-star.zeng@intel.com>

Star,

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

I have integrated this patch into a V6 patch series.

Mike

> -----Original Message-----
> From: Zeng, Star
> Sent: Wednesday, August 1, 2018 3:31 AM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: [PATCH] FmpDevicePkg FmpDxe: Fix XCODE build
> failure
> 
> FmpDxe.c:517:18: error: equality comparison with
> extraneous
> parentheses [-Werror,-Wparentheses-equality]
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> 
> NOTE: This patch is based on thread
> https://lists.01.org/pipermail/edk2-devel/2018-
> July/027810.html.
> 
> ---
>  FmpDevicePkg/FmpDxe/FmpDxe.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c
> b/FmpDevicePkg/FmpDxe/FmpDxe.c
> index 0f3396c2ef83..eb3a9b0e32c2 100644
> --- a/FmpDevicePkg/FmpDxe/FmpDxe.c
> +++ b/FmpDevicePkg/FmpDxe/FmpDxe.c
> @@ -514,7 +514,7 @@ GetTheImage (
>      goto cleanup;
>    }
> 
> -  if ((ImageSize == NULL)) {
> +  if (ImageSize == NULL) {
>      DEBUG ((DEBUG_ERROR, "FmpDxe: GetImage() -
> ImageSize Pointer Parameter is NULL.\n"));
>      Status = EFI_INVALID_PARAMETER;
>      goto cleanup;
> --
> 2.7.0.windows.1



      reply	other threads:[~2018-08-01 22:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-01 10:31 [PATCH] FmpDevicePkg FmpDxe: Fix XCODE build failure Star Zeng
2018-08-01 22:49 ` Kinney, Michael D [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E92EE9817A31E24EB0585FDF735412F5B8A9FBD1@ORSMSX113.amr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox