From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=michael.d.kinney@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8FD93210D43A9 for ; Wed, 1 Aug 2018 15:49:15 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Aug 2018 15:49:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,433,1526367600"; d="scan'208";a="76539561" Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by fmsmga004.fm.intel.com with ESMTP; 01 Aug 2018 15:49:14 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.96]) by ORSMSX102.amr.corp.intel.com ([169.254.3.209]) with mapi id 14.03.0319.002; Wed, 1 Aug 2018 15:49:14 -0700 From: "Kinney, Michael D" To: "Zeng, Star" , "edk2-devel@lists.01.org" , "Kinney, Michael D" Thread-Topic: [PATCH] FmpDevicePkg FmpDxe: Fix XCODE build failure Thread-Index: AQHUKYLKqDPo3UnqzUu9F7fq7UxeQqSrgHVQ Date: Wed, 1 Aug 2018 22:49:13 +0000 Message-ID: References: <1533119470-33260-1-git-send-email-star.zeng@intel.com> In-Reply-To: <1533119470-33260-1-git-send-email-star.zeng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Subject: Re: [PATCH] FmpDevicePkg FmpDxe: Fix XCODE build failure X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Aug 2018 22:49:15 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Star, Reviewed-by: Michael D Kinney I have integrated this patch into a V6 patch series. Mike > -----Original Message----- > From: Zeng, Star > Sent: Wednesday, August 1, 2018 3:31 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Kinney, Michael D > > Subject: [PATCH] FmpDevicePkg FmpDxe: Fix XCODE build > failure >=20 > FmpDxe.c:517:18: error: equality comparison with > extraneous > parentheses [-Werror,-Wparentheses-equality] >=20 > Cc: Michael D Kinney > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Star Zeng >=20 > NOTE: This patch is based on thread > https://lists.01.org/pipermail/edk2-devel/2018- > July/027810.html. >=20 > --- > FmpDevicePkg/FmpDxe/FmpDxe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c > b/FmpDevicePkg/FmpDxe/FmpDxe.c > index 0f3396c2ef83..eb3a9b0e32c2 100644 > --- a/FmpDevicePkg/FmpDxe/FmpDxe.c > +++ b/FmpDevicePkg/FmpDxe/FmpDxe.c > @@ -514,7 +514,7 @@ GetTheImage ( > goto cleanup; > } >=20 > - if ((ImageSize =3D=3D NULL)) { > + if (ImageSize =3D=3D NULL) { > DEBUG ((DEBUG_ERROR, "FmpDxe: GetImage() - > ImageSize Pointer Parameter is NULL.\n")); > Status =3D EFI_INVALID_PARAMETER; > goto cleanup; > -- > 2.7.0.windows.1