From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=michael.d.kinney@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7AD19210F1551 for ; Tue, 14 Aug 2018 11:37:36 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Aug 2018 11:37:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,239,1531810800"; d="scan'208";a="83350817" Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by orsmga002.jf.intel.com with ESMTP; 14 Aug 2018 11:37:36 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.72]) by ORSMSX108.amr.corp.intel.com ([169.254.2.233]) with mapi id 14.03.0319.002; Tue, 14 Aug 2018 11:37:35 -0700 From: "Kinney, Michael D" To: Leif Lindholm , Ming Huang , "Kinney, Michael D" CC: "huangming23@huawei.com" , "edk2-devel@lists.01.org" , "Gao, Liming" , "mengfanrong@huawei.com" , "guoheyi@huawei.com" , "zhangjinsong2@huawei.com" , "linaro-uefi@lists.linaro.org" , "wanghuiqiang@huawei.com" , "huangdaode@hisilicon.com" Thread-Topic: [edk2] [PATCH edk2/MdePkg v1 1/1] MdePkg Cper.h: Add generic error macros for ARM platform Thread-Index: AQHUMkUQe1EW1wi2GkWRGx2SiaitIKS/7GKA//+pzfA= Date: Tue, 14 Aug 2018 18:37:35 +0000 Message-ID: References: <20180812140148.31669-1-ming.huang@linaro.org> <20180812140148.31669-2-ming.huang@linaro.org> <20180814164229.obh5rx3ecbk6su6z@bivouac.eciton.net> In-Reply-To: <20180814164229.obh5rx3ecbk6su6z@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Subject: Re: [PATCH edk2/MdePkg v1 1/1] MdePkg Cper.h: Add generic error macros for ARM platform X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Aug 2018 18:37:36 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Leif, I have no objections to this commit being made before the edk2 stable tag. I see a Bugzilla for this topic as well: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1087 I have updated the Bugzilla approving this change for edk2-stable201808. Thanks, Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel- > bounces@lists.01.org] On Behalf Of Leif Lindholm > Sent: Tuesday, August 14, 2018 9:42 AM > To: Ming Huang > Cc: huangming23@huawei.com; edk2-devel@lists.01.org; > Gao, Liming ; > mengfanrong@huawei.com; guoheyi@huawei.com; > zhangjinsong2@huawei.com; linaro-uefi@lists.linaro.org; > Kinney, Michael D ; > wanghuiqiang@huawei.com; huangdaode@hisilicon.com > Subject: Re: [edk2] [PATCH edk2/MdePkg v1 1/1] MdePkg > Cper.h: Add generic error macros for ARM platform >=20 > On Sun, Aug 12, 2018 at 10:01:48PM +0800, Ming Huang > wrote: > > Contributed-under: TianoCore Contribution Agreement > 1.1 > > Signed-off-by: Ming Huang >=20 > Mike, Liming. > Could we merge this during the quiet period? > It's basically an omission - these are defined since > (at least) UEFI 2.6. >=20 > > --- > > MdePkg/Include/Guid/Cper.h | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/MdePkg/Include/Guid/Cper.h > b/MdePkg/Include/Guid/Cper.h > > index 5ddd4c715ebc..525bfe57b21b 100644 > > --- a/MdePkg/Include/Guid/Cper.h > > +++ b/MdePkg/Include/Guid/Cper.h > > @@ -256,6 +256,7 @@ typedef struct { > > ///@{ > > #define EFI_GENERIC_ERROR_PROC_TYPE_IA32_X64 > 0x00 > > #define EFI_GENERIC_ERROR_PROC_TYPE_IA64 > 0x01 > > +#define EFI_GENERIC_ERROR_PROC_TYPE_ARM > 0x02 > > ///@} > > > > /// > > @@ -265,6 +266,8 @@ typedef struct { > > #define EFI_GENERIC_ERROR_PROC_ISA_IA32 > 0x00 > > #define EFI_GENERIC_ERROR_PROC_ISA_IA64 > 0x01 > > #define EFI_GENERIC_ERROR_PROC_ISA_X64 > 0x02 > > +#define EFI_GENERIC_ERROR_PROC_ISA_ARM32 > 0x03 > > +#define EFI_GENERIC_ERROR_PROC_ISA_ARM64 > 0x04 >=20 > Looking at the spec though, these are called: > ARM A32/T32 and > ARM A64 >=20 > For architectural correctness, I think the names should > be > EFI_GENERIC_ERROR_PROC_ISA_A32_T32 > EFI_GENERIC_ERROR_PROC_ISA_A64 > or > EFI_GENERIC_ERROR_PROC_ISA_ARM_A32_T32 > EFI_GENERIC_ERROR_PROC_ISA_ARM_A64 > which gives some form of glorious symmetry against the > EFI_GENERIC_ERROR_PROC_TYPE_IA32_X64 above :) >=20 > With either change, as preferred by the package > maintainers: > Reviewed-by: Leif Lindholm >=20 > > ///@} > > > > /// > > -- > > 2.17.0 > > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel