Re: EDK II Stable Tag release edk2-stable201808 and quiet period starting today

["Kinney, Michael D" <michael.d.kinney@intel.com>]

Laszlo,

Thank you for this valuable feedback on the commit
activity in the quiet period.  I agree with your analysis.

Bugzillas should have been entered for all of these
changes and discussed on the mailing list and approved
before commit.

We will learn from this experience and apply it as we
complete the current quiet period and apply to future
ones.

At this time, I am only aware of one additional change
request before adding the edk2-stable201808 tag:

https://bugzilla.tianocore.org/show_bug.cgi?id=1087

Thanks,

Mike

> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Tuesday, August 14, 2018 8:12 AM
> To: Kinney, Michael D <michael.d.kinney@intel.com>;
> edk2-devel@lists.01.org; leif.lindholm@linaro.org;
> Andrew Fish (afish@apple.com) <afish@apple.com>;
> Richardson, Brian <brian.richardson@intel.com>
> Subject: Re: [edk2] EDK II Stable Tag release edk2-
> stable201808 and quiet period starting today
> 
> On 08/08/18 16:16, Kinney, Michael D wrote:
> > Hello,
> >
> > I sent an RFC for review on EDK II stable tags.
> >
> > https://lists.01.org/pipermail/edk2-devel/2018-
> June/026474.html
> >
> > There were no objections and we would like to move
> forward
> > with the an EDK II Stable Tag release.  The original
> goal was
> > 8/10/2018.  I have seen a request to move the stable
> tag
> > release out a few days.
> >
> > I recommend we target 8/15/2018 and start a quiet
> period
> > on edk2/master starting today.  This means critical
> bug
> > fixes only on edk2/master.  New features and large
> changes
> > should be held until the edk2-stable201808 tag is
> created.
> >
> > Please use Bugzilla for the critical issues that must
> be
> > fixed before the tag is created.
> >
> > https://bugzilla.tianocore.org/
> 
> The following commits have been pushed since we entered
> the quiet period
> (the last commit before it was 9e6c4f1527e6,
> "FmpDevicePkg FmpDxe: Lock
> variables in entrypoint instead of callback"):
> 
>    1  3781f14c31e0
> SecurityPkg/Library/Tpm2DeviceLibDTpm: fix
> s/Constructor/CONSTRUCTOR
> 
> This is a critical bugfix, satisfying the requirement.
> 
>    2  b3e1e343fe34 SecurityPkg: HashLib: Update HashLib
> file GUID
> 
> Can also be considered an important bugfix (GUID
> duplication), although
> the commit does not name a TianoCore BZ.
> 
>    3  10ea1b6853f9 Maintainers.txt: Add FmpDevicePkg
> maintainers
> 
> Can be considered an important bugfix (no maintainers
> listed for a
> top-level package). Misses a TianoCore BZ reference.
> 
>    4  45e076b7a720 Vlv2TbltDevicePkg/Override/Bds: Add
> test key notification
>    5  dc65dd5be697 Vlv2TbltDevicePkg/Feature/Capsule:
> Add FmpDeviceLib instances
>    6  d3049066ca25 Vlv2TbltDevicePkg/Capsule: Add
> scripts to generate capsules
>    7  1aa9314e3a84 Vlv2TbltDevicePkg: Update DSC/FDF to
> use FmpDevicePkg
> 
> These commits violate the quiet period. They add a
> feature.
> 
>    8  667abfaf8a16 UefiCpuPkg: Removing ipf which is no
> longer supported from edk2.
>    9  df49a85dbcc6 CorebootModulePkg: Removing ipf from
> edk2.
>   10  04c7f9023ffe CorebootPayloadPkg: Removing ipf
> from edk2.
>   11  4fcb0d54584f NetworkPkg: Removing ipf which is no
> longer supported from edk2.
>   12  87f9867f5536 QuarkPlatformPkg: Removing ipf which
> is no longer supported from edk2.
>   13  fda6abd64f02 QuarkSocPkg: Removing ipf which is
> no longer supported from edk2.
>   14  22ec06c8aaa1 Vlv2TbltDevicePkg: Removing ipf
> which from edk2.
> 
> These commits also violate the quiet period. They
> implement a valid
> cleanup, but not a critical bugfix. They should have
> been delayed.
> 
> Laszlo