public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Kinney, Michael D" <michael.d.kinney@intel.com>
To: Laszlo Ersek <lersek@redhat.com>,
	"Ni, Ruiyu" <ruiyu.ni@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Yao, Jiewen" <jiewen.yao@intel.com>,
	"Gao, Liming" <liming.gao@intel.com>
Subject: Re: [PATCH v3] MdePkg/SynchronizationLib: fix Interlocked[De|In]crement return value
Date: Wed, 26 Sep 2018 17:39:00 +0000	[thread overview]
Message-ID: <E92EE9817A31E24EB0585FDF735412F5B8AF461A@ORSMSX113.amr.corp.intel.com> (raw)
In-Reply-To: <ff709a5a-3add-5602-ab17-d065d399f9d1@redhat.com>

Laszlo,

Thanks for filing the BZ.  Converting inline assembly to
NASM source files is a really good direction to improve
the readability and maintainability of the code by
consolidating to one assembly source format.

Thanks,
 
Mike

> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Tuesday, September 25, 2018 12:26 PM
> To: Ni, Ruiyu <ruiyu.ni@intel.com>; edk2-
> devel@lists.01.org
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Yao,
> Jiewen <jiewen.yao@intel.com>; Gao, Liming
> <liming.gao@intel.com>
> Subject: Re: [edk2] [PATCH v3]
> MdePkg/SynchronizationLib: fix Interlocked[De|In]crement
> return value
> 
> On 09/25/18 20:29, Laszlo Ersek wrote:
> 
> > So here's what I'm going to do. I will submit a
> standalone, "surgical"
> > patch, for fixing the regression introduced in
> 17634d026f96.
> 
> Filed
> <https://bugzilla.tianocore.org/show_bug.cgi?id=1207>
> about that.
> 
> > Additionally, I will file a TianoCore BZ about the
> *other* bugs in
> > GccInline.c, and suggest that we fix those issues by
> eliminating the
> > GCC-specific variant altogether.
> 
> That one is
> <https://bugzilla.tianocore.org/show_bug.cgi?id=1208>.
> 
> Thanks
> Laszlo

      reply	other threads:[~2018-09-26 17:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-13  9:50 [PATCH v3] MdePkg/SynchronizationLib: fix Interlocked[De|In]crement return value Ruiyu Ni
2018-09-21  7:45 ` Gao, Liming
2018-09-25 14:08 ` Laszlo Ersek
2018-09-25 14:22 ` Laszlo Ersek
2018-09-25 16:18   ` Laszlo Ersek
2018-09-25 18:29     ` Laszlo Ersek
2018-09-25 19:25       ` Laszlo Ersek
2018-09-26 17:39         ` Kinney, Michael D [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E92EE9817A31E24EB0585FDF735412F5B8AF461A@ORSMSX113.amr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox