From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=michael.d.kinney@intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9C80721188C50 for ; Thu, 1 Nov 2018 10:19:43 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Nov 2018 10:19:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,452,1534834800"; d="scan'208";a="87880110" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by orsmga006.jf.intel.com with ESMTP; 01 Nov 2018 10:19:42 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.125]) by ORSMSX106.amr.corp.intel.com ([169.254.1.161]) with mapi id 14.03.0415.000; Thu, 1 Nov 2018 10:19:42 -0700 From: "Kinney, Michael D" To: Leif Lindholm , "edk2-devel@lists.01.org" , "Kinney, Michael D" CC: "Carsey, Jaben" , Daryl McDaniel Thread-Topic: [edk2] [PATCH 1/6] AppPkg: fix webserver build for !Ia32/X64 Thread-Index: AQHUcfjHF9OkJGKtOkigDTInfZmCUqU7KQzg Date: Thu, 1 Nov 2018 17:19:42 +0000 Message-ID: References: <20181101153642.11315-1-leif.lindholm@linaro.org> <20181101153642.11315-2-leif.lindholm@linaro.org> In-Reply-To: <20181101153642.11315-2-leif.lindholm@linaro.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Subject: Re: [PATCH 1/6] AppPkg: fix webserver build for !Ia32/X64 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Nov 2018 17:19:43 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Leif, The MSR definitions are only used by Mtrr.c, and Mtrr.c is only used for IA32 and X64 builds in the INF file. It would be simpler to move the #include into Mtrr.c. That would avoid the use of #if. Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel- > bounces@lists.01.org] On Behalf Of Leif Lindholm > Sent: Thursday, November 1, 2018 8:37 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben ; Daryl > McDaniel > Subject: [edk2] [PATCH 1/6] AppPkg: fix webserver build > for !Ia32/X64 >=20 > The WebServer application is really quite Ia32/X64 > specific, but fundamentally > it builds for other architectures as long as the > architecture-specific > #include > header file is filtered out. > So add an architecture-based filter on that to enable > AppPkg.dsc to build for > AARCH64/ARM (both listed in SUPPORTED_ARCHITECTURES). >=20 > Cc: Daryl McDaniel > Cc: Jaben Carsey > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Leif Lindholm > --- >=20 > Note: there is definitely a case here for just > disabling this component > for !Ia32/X64, but the _interesting_ bits of this > application are > completely architecture independent, so my > preference would be to > do this for now, and worry about remaining issues > (like MTRR dump) > at some point in the future. >=20 > AppPkg/Applications/Sockets/WebServer/WebServer.h | 2 > ++ > 1 file changed, 2 insertions(+) >=20 > diff --git > a/AppPkg/Applications/Sockets/WebServer/WebServer.h > b/AppPkg/Applications/Sockets/WebServer/WebServer.h > index 21b07b63df..610abdcf9e 100644 > --- a/AppPkg/Applications/Sockets/WebServer/WebServer.h > +++ b/AppPkg/Applications/Sockets/WebServer/WebServer.h > @@ -20,7 +20,9 @@ >=20 > #include >=20 > +#if defined(__x86_64__) || defined(__i386__) > #include > +#endif > #include > #include > #include > -- > 2.11.0 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel