public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Kinney, Michael D" <michael.d.kinney@intel.com>
To: Leif Lindholm <leif.lindholm@linaro.org>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "Gao, Liming" <liming.gao@intel.com>
Subject: Re: [PATCH 3/6] IntelFrameworkPkg: fix build for AARCH64/ARM
Date: Thu, 1 Nov 2018 17:23:38 +0000	[thread overview]
Message-ID: <E92EE9817A31E24EB0585FDF735412F5B8B287E8@ORSMSX113.amr.corp.intel.com> (raw)
In-Reply-To: <20181101153642.11315-4-leif.lindholm@linaro.org>

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

Mike


> -----Original Message-----
> From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
> Sent: Thursday, November 1, 2018 8:37 AM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>;
> Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH 3/6] IntelFrameworkPkg: fix build for
> AARCH64/ARM
> 
> Contrary to what the name suggests, some modules in
> this package are used
> on other architecture. ARM is already listed in
> SUPPORTED_ARCHITECTURES
> in the .dsc, but AARCH64 was never added - so do that.
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
>  IntelFrameworkPkg/IntelFrameworkPkg.dsc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/IntelFrameworkPkg/IntelFrameworkPkg.dsc
> b/IntelFrameworkPkg/IntelFrameworkPkg.dsc
> index bd5df8c5d9..f957af78fb 100644
> --- a/IntelFrameworkPkg/IntelFrameworkPkg.dsc
> +++ b/IntelFrameworkPkg/IntelFrameworkPkg.dsc
> @@ -26,7 +26,7 @@ [Defines]
>    PLATFORM_VERSION               = 0.96
>    DSC_SPECIFICATION              = 0x00010005
>    OUTPUT_DIRECTORY               =
> Build/IntelFramework
> -  SUPPORTED_ARCHITECTURES        = IA32|X64|EBC|ARM
> +  SUPPORTED_ARCHITECTURES        =
> IA32|X64|EBC|ARM|AARCH64
>    BUILD_TARGETS                  = DEBUG|RELEASE|NOOPT
>    SKUID_IDENTIFIER               = DEFAULT
> 
> --
> 2.11.0



  reply	other threads:[~2018-11-01 17:23 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-01 15:36 [PATCH 0/6] fix top-level package builds for AARCH64/ARM Leif Lindholm
2018-11-01 15:36 ` [PATCH 1/6] AppPkg: fix webserver build for !Ia32/X64 Leif Lindholm
2018-11-01 17:19   ` Kinney, Michael D
2018-11-01 17:56     ` Leif Lindholm
2018-11-01 15:36 ` [PATCH 2/6] IntelFrameworkModulePkg: fix build for AARCH64/ARM Leif Lindholm
2018-11-02  1:39   ` Gao, Liming
2018-11-02 10:15     ` Leif Lindholm
2018-11-02 14:20       ` Gao, Liming
2018-11-01 15:36 ` [PATCH 3/6] IntelFrameworkPkg: " Leif Lindholm
2018-11-01 17:23   ` Kinney, Michael D [this message]
2018-11-01 15:36 ` [PATCH 4/6] MdeModulePkg: drop DebugSupportDxe from AARCH64 components Leif Lindholm
2018-11-02  1:24   ` Zeng, Star
2018-11-01 15:36 ` [PATCH 5/6] SecurityPkg: fix package build on ARM Leif Lindholm
2018-11-02  0:00   ` Yao, Jiewen
2018-11-01 15:36 ` [PATCH 6/6] SignedCapsulePkg: enable package build for AARCH64/ARM Leif Lindholm
2018-11-02  0:00   ` Yao, Jiewen
2019-02-04 17:13 ` [PATCH 0/6] fix top-level package builds " Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E92EE9817A31E24EB0585FDF735412F5B8B287E8@ORSMSX113.amr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox