public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Kinney, Michael D" <michael.d.kinney@intel.com>
To: "Yao, Jiewen" <jiewen.yao@intel.com>,
	"Cohen, Eugene" <eugene@hp.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	"Zhang, Chao B" <chao.b.zhang@intel.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "Bin, Sung-Uk (???)" <sunguk-bin@hp.com>
Subject: Re: [PATCH 1/4] SecurityPkg: enable TPM components to build for ARM and AARCH64
Date: Tue, 13 Nov 2018 22:59:20 +0000	[thread overview]
Message-ID: <E92EE9817A31E24EB0585FDF735412F5B8B2F89E@ORSMSX113.amr.corp.intel.com> (raw)
In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503F3EB72C@shsmsx102.ccr.corp.intel.com>

Jiewen,

There are I2C examples for TPM12 in the
QuarkPlatformPkg.  Would that we a good example
too?

Could this new lib class be used for both 
TPM12 and TPM20 devices?

Mike

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-
> bounces@lists.01.org] On Behalf Of Yao, Jiewen
> Sent: Tuesday, November 13, 2018 2:22 PM
> To: Cohen, Eugene <eugene@hp.com>; edk2-
> devel@lists.01.org; Zhang, Chao B
> <chao.b.zhang@intel.com>
> Cc: Bin, Sung-Uk (???) <sunguk-bin@hp.com>
> Subject: Re: [edk2] [PATCH 1/4] SecurityPkg: enable TPM
> components to build for ARM and AARCH64
> 
> HI Eugene
> Thanks to enable SPI TPM chip.
> In general, I am OK on this patch series.
> 
> There are some additional work here.
> 1) Please split this patch to 2. The TpmIoLib is not
> present in at this point of time. We should add it
> after TpmIoLib instance is added.
> 
> 2) Since this patch series adds the dependency of
> TpmIoLib, please update *all* impacted platform in
> EDKII repo and EDKII platform repo.
> We need make sure this patch series does not break any
> existing platform build.
> 
> 3) I hope, (if possible) you can provide one *real
> example* on how to add SPI instance, to demonstrate the
> usage and value of this one more layer abstraction.
> 
> Thank you
> Yao Jiewen
> 
> 
> > -----Original Message-----
> > From: Cohen, Eugene [mailto:eugene@hp.com]
> > Sent: Wednesday, November 14, 2018 6:13 AM
> > To: edk2-devel@lists.01.org; Yao, Jiewen
> <jiewen.yao@intel.com>; Zhang,
> > Chao B <chao.b.zhang@intel.com>
> > Cc: Bin, Sung-Uk (빈성욱) <sunguk-bin@hp.com>
> > Subject: [PATCH 1/4] SecurityPkg: enable TPM
> components to build for ARM
> > and AARCH64
> >
> >  SecurityPkg: enable TPM components to build for ARM
> and AARCH64
> >
> > Contributed-under: TianoCore Contribution Agreement
> 1.1
> > Cc: Chao Zhang <chao.b.zhang@intel.com>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Signed-off-by: Eugene Cohen <eugene@hp.com>
> > ---
> >  SecurityPkg/SecurityPkg.dsc | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/SecurityPkg/SecurityPkg.dsc
> b/SecurityPkg/SecurityPkg.dsc
> > index 68a2953..6fb9ad2 100644
> > --- a/SecurityPkg/SecurityPkg.dsc
> > +++ b/SecurityPkg/SecurityPkg.dsc
> > @@ -53,6 +53,7 @@
> >
> IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLi
> b.inf
> >
> OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
> >
> IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrin
> sic.inf
> > +
> TpmIoLib|SecurityPkg/Library/TpmIoLibMmio/TpmIoLibMmio.
> inf
> >
> TpmCommLib|SecurityPkg/Library/TpmCommLib/TpmCommLib.in
> f
> >
> >
> PlatformSecureLib|SecurityPkg/Library/PlatformSecureLib
> Null/PlatformSecu
> > reLibNull.inf
> >
> >
> TcgPhysicalPresenceLib|SecurityPkg/Library/DxeTcgPhysic
> alPresenceLib/Dxe
> > TcgPhysicalPresenceLib.inf
> > @@ -199,7 +200,7 @@
> >  [Components.IA32, Components.X64, Components.ARM,
> > Components.AARCH64]
> >
> SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
> >
> > -[Components.IA32, Components.X64]
> > +[Components.IA32, Components.X64 Components.ARM,
> > Components.AARCH64]
> >  #
> >
> SecurityPkg/UserIdentification/PwdCredentialProviderDxe
> /PwdCredentialPr
> > oviderDxe.inf
> >  #
> >
> SecurityPkg/UserIdentification/UsbCredentialProviderDxe
> /UsbCredentialPro
> > viderDxe.inf
> >
> >
> SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/S
> ecureBootConfi
> > gDxe.inf
> > --
> > 2.7.4
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel

      parent reply	other threads:[~2018-11-13 22:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-13 22:12 [PATCH 1/4] SecurityPkg: enable TPM components to build for ARM and AARCH64 Cohen, Eugene
2018-11-13 22:21 ` Yao, Jiewen
2018-11-13 22:49   ` Cohen, Eugene
2018-11-14  0:28     ` Yao, Jiewen
2018-11-13 22:59   ` Kinney, Michael D [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E92EE9817A31E24EB0585FDF735412F5B8B2F89E@ORSMSX113.amr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox